From 22f66d35e55069488cbba95d3fef6f89eb952da8 Mon Sep 17 00:00:00 2001 From: Chris Hunt Date: Fri, 11 Jul 2025 16:19:34 +0100 Subject: [PATCH] Throw error if image doesn't have an extension #1446 --- app/Http/Controllers/ItemController.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/Http/Controllers/ItemController.php b/app/Http/Controllers/ItemController.php index 27d41066..967ab225 100644 --- a/app/Http/Controllers/ItemController.php +++ b/app/Http/Controllers/ItemController.php @@ -250,6 +250,9 @@ class ItemController extends Controller $file = $request->input('icon'); $path_parts = pathinfo($file); + if (!isset($path_parts['extension'])) { + throw ValidationException::withMessages(['file' => 'Icon URL must have a valid file extension.']); + } $extension = $path_parts['extension']; $contents = file_get_contents($request->input('icon'), false, stream_context_create($options));