From f3a5be79dc5a954ff01104995796884b18bdcc87 Mon Sep 17 00:00:00 2001 From: Shift Date: Fri, 16 Feb 2024 21:13:14 +0000 Subject: [PATCH] Remove redundant typing from DocBlocks --- app/Application.php | 19 ---------- app/Console/Commands/RegisterApp.php | 5 --- app/Console/Kernel.php | 5 --- app/Http/Controllers/Auth/LoginController.php | 12 ------ .../Controllers/Auth/RegisterController.php | 6 --- app/Http/Controllers/HealthController.php | 7 ---- app/Http/Controllers/HomeController.php | 2 - app/Http/Controllers/ImportController.php | 3 -- app/Http/Controllers/ItemController.php | 37 ------------------ app/Http/Controllers/ItemRestController.php | 18 --------- app/Http/Controllers/SearchController.php | 1 - app/Http/Controllers/SettingsController.php | 15 -------- app/Http/Controllers/TagController.php | 18 --------- app/Http/Controllers/UserController.php | 18 --------- app/Http/Middleware/CheckAllowed.php | 3 -- .../Middleware/RedirectIfAuthenticated.php | 5 --- app/Item.php | 38 ------------------- app/Jobs/ProcessApps.php | 1 - app/Jobs/UpdateApps.php | 4 -- app/Providers/AppServiceProvider.php | 16 -------- app/Providers/AuthServiceProvider.php | 2 - app/Providers/EventServiceProvider.php | 4 -- app/Providers/RouteServiceProvider.php | 8 ---- app/Setting.php | 15 -------- app/SettingGroup.php | 3 -- database/factories/ItemFactory.php | 2 - database/factories/ItemTagFactory.php | 2 - database/factories/UserFactory.php | 2 - .../2018_01_27_155922_create_items_table.php | 4 -- ...018_02_04_185524_create_settings_table.php | 4 -- ..._04_185802_create_setting_groups_table.php | 4 -- ...175830_add_columns_to_items_for_groups.php | 4 -- .../migrations/2018_02_16_193703_item_tag.php | 4 -- .../2018_10_12_122907_create_users_table.php | 4 -- ...12_123036_create_password_resets_table.php | 4 -- ...0_12_131222_add_user_id_to_items_table.php | 4 -- ...140451_create_setting_user_pivot_table.php | 4 -- ...10_18_110905_create_applications_table.php | 4 -- ..._10_23_132008_add_class_to_items_table.php | 4 -- .../2018_10_31_191604_create_jobs_table.php | 4 -- ..._11_06_112434_create_failed_jobs_table.php | 4 -- .../2022_03_15_140911_add_appid_to_items.php | 4 -- ..._03_16_093044_add_class_to_application.php | 4 -- ...16_181343_add_app_description_to_items.php | 4 -- ...16_000000_rename_password_resets_table.php | 4 -- database/seeders/DatabaseSeeder.php | 2 - database/seeders/SettingsSeeder.php | 2 - database/seeders/UsersSeeder.php | 2 - tests/CreatesApplication.php | 2 - .../database/seeders/SettingsSeederTest.php | 2 - tests/Unit/helpers/IsImageTest.php | 9 ----- tests/Unit/helpers/SlugTest.php | 3 -- tests/Unit/lang/LangTest.php | 2 - 53 files changed, 363 deletions(-) diff --git a/app/Application.php b/app/Application.php index f6860305..9509e283 100644 --- a/app/Application.php +++ b/app/Application.php @@ -66,17 +66,11 @@ class Application extends Model return $this->icon; } - /** - * @return string - */ public function iconView(): string { return asset('storage/'.$this->icon); } - /** - * @return string - */ public function defaultColour(): string { // check if light or dark @@ -87,9 +81,6 @@ class Application extends Model return '#161b1f'; } - /** - * @return string - */ public function class(): string { $name = $this->name; @@ -100,7 +91,6 @@ class Application extends Model /** * @param $name - * @return string */ public static function classFromName($name): string { @@ -111,9 +101,6 @@ class Application extends Model return $class; } - /** - * @return Collection - */ public static function apps(): Collection { $json = json_decode(file_get_contents(storage_path('app/supportedapps.json'))) ?? []; @@ -122,9 +109,6 @@ class Application extends Model return $apps->sortBy('name', SORT_NATURAL | SORT_FLAG_CASE); } - /** - * @return array - */ public static function autocomplete(): array { $apps = self::apps(); @@ -193,9 +177,6 @@ class Application extends Model return $app; } - /** - * @return array - */ public static function applist(): array { $list = []; diff --git a/app/Console/Commands/RegisterApp.php b/app/Console/Commands/RegisterApp.php index cff18228..66d139ff 100644 --- a/app/Console/Commands/RegisterApp.php +++ b/app/Console/Commands/RegisterApp.php @@ -35,8 +35,6 @@ class RegisterApp extends Command /** * Execute the console command. - * - * @return void */ public function handle(): void { @@ -56,8 +54,6 @@ class RegisterApp extends Command /** * @param $folder - * @param bool $remove - * @return void */ public function addApp($folder, bool $remove = false): void { @@ -96,7 +92,6 @@ class RegisterApp extends Command /** * @param $appFolder * @param $icon - * @return void */ private function saveIcon($appFolder, $icon): void { diff --git a/app/Console/Kernel.php b/app/Console/Kernel.php index a702d9ee..4798a7e9 100644 --- a/app/Console/Kernel.php +++ b/app/Console/Kernel.php @@ -9,9 +9,6 @@ class Kernel extends ConsoleKernel { /** * Define the application's command schedule. - * - * @param Schedule $schedule - * @return void */ protected function schedule(Schedule $schedule): void { @@ -21,8 +18,6 @@ class Kernel extends ConsoleKernel /** * Register the commands for the application. - * - * @return void */ protected function commands(): void { diff --git a/app/Http/Controllers/Auth/LoginController.php b/app/Http/Controllers/Auth/LoginController.php index dcf6d59c..7b5be765 100644 --- a/app/Http/Controllers/Auth/LoginController.php +++ b/app/Http/Controllers/Auth/LoginController.php @@ -49,9 +49,6 @@ class LoginController extends Controller $this->middleware('guest')->except(['logout','autologin']); } - /** - * @return string - */ public function username(): string { return 'username'; @@ -60,8 +57,6 @@ class LoginController extends Controller /** * Handle a login request to the application. * - * @param Request $request - * @return Response * * @throws ValidationException */ @@ -97,10 +92,6 @@ class LoginController extends Controller { } - /** - * @param User $user - * @return RedirectResponse - */ public function setUser(User $user): RedirectResponse { Auth::logout(); @@ -111,7 +102,6 @@ class LoginController extends Controller /** * @param $uuid - * @return RedirectResponse */ public function autologin($uuid): RedirectResponse { @@ -141,9 +131,7 @@ class LoginController extends Controller } /** - * @param Request $request * @param $user - * @return RedirectResponse */ protected function authenticated(Request $request, $user): RedirectResponse { diff --git a/app/Http/Controllers/Auth/RegisterController.php b/app/Http/Controllers/Auth/RegisterController.php index 3c4fd440..09b546b0 100644 --- a/app/Http/Controllers/Auth/RegisterController.php +++ b/app/Http/Controllers/Auth/RegisterController.php @@ -41,9 +41,6 @@ class RegisterController extends Controller /** * Get a validator for an incoming registration request. - * - * @param array $data - * @return \Illuminate\Contracts\Validation\Validator */ protected function validator(array $data): \Illuminate\Contracts\Validation\Validator { @@ -56,9 +53,6 @@ class RegisterController extends Controller /** * Create a new user instance after a valid registration. - * - * @param array $data - * @return User */ protected function create(array $data): User { diff --git a/app/Http/Controllers/HealthController.php b/app/Http/Controllers/HealthController.php index e6ddcc42..be2aaa3a 100644 --- a/app/Http/Controllers/HealthController.php +++ b/app/Http/Controllers/HealthController.php @@ -12,17 +12,11 @@ use Illuminate\Support\Facades\RateLimiter; class HealthController extends Controller { - /** - * @return int - */ private static function getUsers(): int { return User::count(); } - /** - * @return int - */ private static function getItems(): int { return Item::select('id') @@ -34,7 +28,6 @@ class HealthController extends Controller /** * Handle the incoming request. * - * @param Request $request * @return JsonResponse|Response * @throws BindingResolutionException */ diff --git a/app/Http/Controllers/HomeController.php b/app/Http/Controllers/HomeController.php index 2d8ae6da..1e7fa357 100644 --- a/app/Http/Controllers/HomeController.php +++ b/app/Http/Controllers/HomeController.php @@ -19,8 +19,6 @@ class HomeController extends Controller /** * Show the application dashboard. - * - * @return RedirectResponse */ public function index(): RedirectResponse { diff --git a/app/Http/Controllers/ImportController.php b/app/Http/Controllers/ImportController.php index 78debb0a..43068372 100644 --- a/app/Http/Controllers/ImportController.php +++ b/app/Http/Controllers/ImportController.php @@ -20,9 +20,6 @@ class ImportController extends Controller /** * Handle the incoming request. - * - * @param Request $request - * @return View */ public function __invoke(Request $request): View { diff --git a/app/Http/Controllers/ItemController.php b/app/Http/Controllers/ItemController.php index 84d4d3f9..fa4c1ae3 100644 --- a/app/Http/Controllers/ItemController.php +++ b/app/Http/Controllers/ItemController.php @@ -32,8 +32,6 @@ class ItemController extends Controller /** * Display a listing of the resource on the dashboard. - * - * @return View */ public function dash(): View { @@ -69,7 +67,6 @@ class ItemController extends Controller * Pin item on the dashboard. * * @param $id - * @return RedirectResponse */ public function pin($id): RedirectResponse { @@ -85,7 +82,6 @@ class ItemController extends Controller * Unpin item on the dashboard. * * @param $id - * @return RedirectResponse */ public function unpin($id): RedirectResponse { @@ -135,9 +131,6 @@ class ItemController extends Controller /** * Display a listing of the resource. - * - * @param Request $request - * @return View */ public function index(Request $request): View { @@ -154,8 +147,6 @@ class ItemController extends Controller /** * Show the form for creating a new resource. - * - * @return View */ public function create(): View { @@ -169,9 +160,6 @@ class ItemController extends Controller /** * Show the form for editing the specified resource. - * - * @param int $id - * @return View */ public function edit(int $id): View { @@ -194,9 +182,7 @@ class ItemController extends Controller } /** - * @param Request $request * @param null $id - * @return Item * @throws ValidationException */ public static function storelogic(Request $request, $id = null): Item @@ -287,9 +273,6 @@ class ItemController extends Controller /** * Store a newly created resource in storage. - * - * @param Request $request - * @return RedirectResponse */ public function store(Request $request): RedirectResponse { @@ -303,9 +286,6 @@ class ItemController extends Controller /** * Display the specified resource. - * - * @param int $id - * @return void */ public function show(int $id): void { @@ -314,10 +294,6 @@ class ItemController extends Controller /** * Update the specified resource in storage. - * - * @param Request $request - * @param int $id - * @return RedirectResponse */ public function update(Request $request, int $id): RedirectResponse { @@ -330,10 +306,6 @@ class ItemController extends Controller /** * Remove the specified resource from storage. - * - * @param Request $request - * @param int $id - * @return RedirectResponse */ public function destroy(Request $request, int $id): RedirectResponse { @@ -355,9 +327,6 @@ class ItemController extends Controller /** * Restore the specified resource from soft deletion. - * - * @param int $id - * @return RedirectResponse */ public function restore(int $id): RedirectResponse { @@ -375,8 +344,6 @@ class ItemController extends Controller /** * Return details for supported apps * - * @param Request $request - * @return string|null * @throws GuzzleException */ public function appload(Request $request): ?string @@ -419,7 +386,6 @@ class ItemController extends Controller } /** - * @param Request $request * @return void */ public function testConfig(Request $request) @@ -448,9 +414,7 @@ class ItemController extends Controller /** * @param $url - * @param array $attrs * @param array|bool $overridevars - * @return ResponseInterface|null * @throws GuzzleException */ public function execute($url, array $attrs = [], $overridevars = false): ?ResponseInterface @@ -481,7 +445,6 @@ class ItemController extends Controller /** * @param $url - * @return StreamInterface * @throws GuzzleException */ public function websitelookup($url): StreamInterface diff --git a/app/Http/Controllers/ItemRestController.php b/app/Http/Controllers/ItemRestController.php index ff908e4a..f962e154 100644 --- a/app/Http/Controllers/ItemRestController.php +++ b/app/Http/Controllers/ItemRestController.php @@ -17,8 +17,6 @@ class ItemRestController extends Controller /** * Display a listing of the resource. - * - * @return Collection */ public function index(): Collection { @@ -49,9 +47,6 @@ class ItemRestController extends Controller /** * Store a newly created resource in storage. - * - * @param Request $request - * @return object */ public function store(Request $request): object { @@ -66,9 +61,6 @@ class ItemRestController extends Controller /** * Display the specified resource. - * - * @param Item $item - * @return Response */ public function show(Item $item): Response { @@ -77,9 +69,6 @@ class ItemRestController extends Controller /** * Show the form for editing the specified resource. - * - * @param Item $item - * @return Response */ public function edit(Item $item): Response { @@ -88,10 +77,6 @@ class ItemRestController extends Controller /** * Update the specified resource in storage. - * - * @param Request $request - * @param Item $item - * @return Response */ public function update(Request $request, Item $item): Response { @@ -100,9 +85,6 @@ class ItemRestController extends Controller /** * Remove the specified resource from storage. - * - * @param Item $item - * @return Response */ public function destroy(Item $item): Response { diff --git a/app/Http/Controllers/SearchController.php b/app/Http/Controllers/SearchController.php index 2ffc5923..3b58551a 100644 --- a/app/Http/Controllers/SearchController.php +++ b/app/Http/Controllers/SearchController.php @@ -11,7 +11,6 @@ use Illuminate\Routing\Redirector; class SearchController extends Controller { /** - * @param Request $request * @return Application|RedirectResponse|Redirector|mixed|void */ public function index(Request $request) diff --git a/app/Http/Controllers/SettingsController.php b/app/Http/Controllers/SettingsController.php index 89af0dcf..8f48055e 100644 --- a/app/Http/Controllers/SettingsController.php +++ b/app/Http/Controllers/SettingsController.php @@ -17,9 +17,6 @@ class SettingsController extends Controller $this->middleware('allowed'); } - /** - * @return View - */ public function index(): View { $settings = SettingGroup::with([ @@ -32,7 +29,6 @@ class SettingsController extends Controller } /** - * @param int $id * * @return RedirectResponse|View */ @@ -59,12 +55,6 @@ class SettingsController extends Controller } } - /** - * @param Request $request - * @param int $id - * - * @return RedirectResponse - */ public function update(Request $request, int $id): RedirectResponse { $setting = Setting::find($id); @@ -114,11 +104,6 @@ class SettingsController extends Controller } } - /** - * @param int $id - * - * @return RedirectResponse - */ public function clear(int $id): RedirectResponse { $user = $this->user(); diff --git a/app/Http/Controllers/TagController.php b/app/Http/Controllers/TagController.php index 4460bce4..6999689b 100644 --- a/app/Http/Controllers/TagController.php +++ b/app/Http/Controllers/TagController.php @@ -49,9 +49,6 @@ class TagController extends Controller /** * Store a newly created resource in storage. - * - * @param Request $request - * @return RedirectResponse */ public function store(Request $request): RedirectResponse { @@ -90,7 +87,6 @@ class TagController extends Controller * Display the specified resource. * * @param $slug - * @return View */ public function show($slug): View { @@ -105,9 +101,6 @@ class TagController extends Controller /** * Show the form for editing the specified resource. - * - * @param int $id - * @return View */ public function edit(int $id): View { @@ -121,10 +114,6 @@ class TagController extends Controller /** * Update the specified resource in storage. - * - * @param Request $request - * @param int $id - * @return RedirectResponse */ public function update(Request $request, int $id): RedirectResponse { @@ -156,10 +145,6 @@ class TagController extends Controller /** * Remove the specified resource from storage. - * - * @param Request $request - * @param int $id - * @return RedirectResponse */ public function destroy(Request $request, int $id): RedirectResponse { @@ -181,9 +166,6 @@ class TagController extends Controller /** * Restore the specified resource from soft deletion. - * - * @param int $id - * @return RedirectResponse */ public function restore(int $id): RedirectResponse { diff --git a/app/Http/Controllers/UserController.php b/app/Http/Controllers/UserController.php index b426878b..2892366e 100644 --- a/app/Http/Controllers/UserController.php +++ b/app/Http/Controllers/UserController.php @@ -19,8 +19,6 @@ class UserController extends Controller /** * Display a listing of the resource. - * - * @return View */ public function index(): View { @@ -31,8 +29,6 @@ class UserController extends Controller /** * Show the form for creating a new resource. - * - * @return View */ public function create(): View { @@ -51,9 +47,6 @@ class UserController extends Controller /** * Store a newly created resource in storage. - * - * @param Request $request - * @return RedirectResponse */ public function store(Request $request): RedirectResponse { @@ -93,9 +86,6 @@ class UserController extends Controller /** * Display the specified resource. - * - * @param int $id - * @return void */ public function show(int $id): void { @@ -104,9 +94,6 @@ class UserController extends Controller /** * Show the form for editing the specified resource. - * - * @param User $user - * @return View */ public function edit(User $user): View { @@ -117,10 +104,6 @@ class UserController extends Controller /** * Update the specified resource in storage. - * - * @param Request $request - * @param User $user - * @return RedirectResponse */ public function update(Request $request, User $user): RedirectResponse { @@ -166,7 +149,6 @@ class UserController extends Controller /** * Remove the specified resource from storage. * - * @param User $user * @return RedirectResponse | void */ public function destroy(User $user): RedirectResponse diff --git a/app/Http/Middleware/CheckAllowed.php b/app/Http/Middleware/CheckAllowed.php index 1ab898a0..d243820e 100644 --- a/app/Http/Middleware/CheckAllowed.php +++ b/app/Http/Middleware/CheckAllowed.php @@ -16,9 +16,6 @@ class CheckAllowed /** * Handle an incoming request. * - * @param Request $request - * @param Closure $next - * @return mixed * @throws AuthenticationException */ public function handle(Request $request, Closure $next): Response diff --git a/app/Http/Middleware/RedirectIfAuthenticated.php b/app/Http/Middleware/RedirectIfAuthenticated.php index 0f0674e0..a7e2579d 100644 --- a/app/Http/Middleware/RedirectIfAuthenticated.php +++ b/app/Http/Middleware/RedirectIfAuthenticated.php @@ -11,11 +11,6 @@ class RedirectIfAuthenticated { /** * Handle an incoming request. - * - * @param Request $request - * @param Closure $next - * @param string|null $guard - * @return mixed */ public function handle(Request $request, Closure $next, string $guard = null): Response { diff --git a/app/Item.php b/app/Item.php index e89943a2..b7bdd326 100644 --- a/app/Item.php +++ b/app/Item.php @@ -76,9 +76,6 @@ class Item extends Model use HasFactory; - /** - * @return void - */ protected static function boot(): void { parent::boot(); @@ -113,9 +110,6 @@ class Item extends Model /** * Scope a query to only include pinned items. - * - * @param Builder $query - * @return Builder */ public function scopePinned(Builder $query): Builder { @@ -153,9 +147,6 @@ class Item extends Model return $tagdetails; } - /** - * @return string - */ public function getTagClass(): string { $tags = $this->tags(); @@ -170,17 +161,11 @@ class Item extends Model return implode(' ', $slugs); } - /** - * @return BelongsToMany - */ public function parents(): BelongsToMany { return $this->belongsToMany(Item::class, 'item_tag', 'item_id', 'tag_id'); } - /** - * @return BelongsToMany - */ public function children(): BelongsToMany { return $this->belongsToMany(Item::class, 'item_tag', 'tag_id', 'item_id'); @@ -198,9 +183,6 @@ class Item extends Model } } - /** - * @return string - */ public function getDroppableAttribute(): string { if ((int) $this->type === 1) { @@ -210,9 +192,6 @@ class Item extends Model } } - /** - * @return string - */ public function getLinkTargetAttribute(): string { $target = Setting::fetch('window_target'); @@ -224,9 +203,6 @@ class Item extends Model } } - /** - * @return string - */ public function getLinkIconAttribute(): string { if ((int) $this->type === 1) { @@ -236,9 +212,6 @@ class Item extends Model } } - /** - * @return string - */ public function getLinkTypeAttribute(): string { if ((int) $this->type === 1) { @@ -279,9 +252,6 @@ class Item extends Model return $query->where('type', $typeid); } - /** - * @return bool - */ public function enhanced(): bool { /*if(isset($this->class) && !empty($this->class)) { @@ -295,7 +265,6 @@ class Item extends Model /** * @param $class - * @return bool */ public static function isEnhanced($class): bool { @@ -321,9 +290,6 @@ class Item extends Model return ((bool) ($app instanceof SearchInterface)) ? $app : false; } - /** - * @return bool - */ public function enabled(): bool { if ($this->enhanced()) { @@ -369,7 +335,6 @@ class Item extends Model /** * @param $class - * @return Application|null */ public static function applicationDetails($class): ?Application { @@ -386,7 +351,6 @@ class Item extends Model /** * @param $class - * @return string */ public static function getApplicationDescription($class): string { @@ -400,8 +364,6 @@ class Item extends Model /** * Get the user that owns the item. - * - * @return BelongsTo */ public function user(): BelongsTo { diff --git a/app/Jobs/ProcessApps.php b/app/Jobs/ProcessApps.php index 1ce0a4d3..68276127 100644 --- a/app/Jobs/ProcessApps.php +++ b/app/Jobs/ProcessApps.php @@ -32,7 +32,6 @@ class ProcessApps implements ShouldQueue, ShouldBeUnique /** * Execute the job. * - * @return void * @throws GuzzleException */ public function handle(): void diff --git a/app/Jobs/UpdateApps.php b/app/Jobs/UpdateApps.php index 77b6eb9d..636792b4 100644 --- a/app/Jobs/UpdateApps.php +++ b/app/Jobs/UpdateApps.php @@ -30,7 +30,6 @@ class UpdateApps implements ShouldQueue, ShouldBeUnique /** * Execute the job. * - * @return void * @throws GuzzleException */ public function handle(): void @@ -50,9 +49,6 @@ class UpdateApps implements ShouldQueue, ShouldBeUnique Cache::lock('updateApps')->forceRelease(); } - /** - * @return void - */ public function failed($exception): void { Cache::lock('updateApps')->forceRelease(); diff --git a/app/Providers/AppServiceProvider.php b/app/Providers/AppServiceProvider.php index 21bfa6f1..5f9748aa 100644 --- a/app/Providers/AppServiceProvider.php +++ b/app/Providers/AppServiceProvider.php @@ -19,8 +19,6 @@ class AppServiceProvider extends ServiceProvider { /** * Bootstrap any application services. - * - * @return void */ public function boot(): void { @@ -105,8 +103,6 @@ class AppServiceProvider extends ServiceProvider /** * Generate app key if missing and .env exists - * - * @return void */ public function genKey(): void { @@ -119,8 +115,6 @@ class AppServiceProvider extends ServiceProvider /** * Register any application services. - * - * @return void */ public function register(): void { @@ -136,7 +130,6 @@ class AppServiceProvider extends ServiceProvider /** * Check if database needs an update or do first time database setup * - * @return void * @throws ContainerExceptionInterface * @throws NotFoundExceptionInterface */ @@ -158,9 +151,6 @@ class AppServiceProvider extends ServiceProvider } } - /** - * @return void - */ public function createEnvFile(): void { if (!is_file(base_path('.env'))) { @@ -170,9 +160,6 @@ class AppServiceProvider extends ServiceProvider $this->genKey(); } - /** - * @return bool - */ private function needsDBUpdate(): bool { if (!Schema::hasTable('settings')) { @@ -185,9 +172,6 @@ class AppServiceProvider extends ServiceProvider return version_compare($app_version, $db_version) === 1; } - /** - * @return void - */ private function updateApps(): void { // This lock ensures that the job is not invoked multiple times. diff --git a/app/Providers/AuthServiceProvider.php b/app/Providers/AuthServiceProvider.php index a119d6f9..e22ccf18 100644 --- a/app/Providers/AuthServiceProvider.php +++ b/app/Providers/AuthServiceProvider.php @@ -17,8 +17,6 @@ class AuthServiceProvider extends ServiceProvider /** * Register any authentication / authorization services. - * - * @return void */ public function boot(): void { diff --git a/app/Providers/EventServiceProvider.php b/app/Providers/EventServiceProvider.php index 072aa29e..57bb737a 100644 --- a/app/Providers/EventServiceProvider.php +++ b/app/Providers/EventServiceProvider.php @@ -19,8 +19,6 @@ class EventServiceProvider extends ServiceProvider /** * Register any events for your application. - * - * @return void */ public function boot(): void { @@ -31,8 +29,6 @@ class EventServiceProvider extends ServiceProvider /** * Determine if events and listeners should be automatically discovered. - * - * @return bool */ public function shouldDiscoverEvents(): bool { diff --git a/app/Providers/RouteServiceProvider.php b/app/Providers/RouteServiceProvider.php index 76c28314..e8bd7d8e 100644 --- a/app/Providers/RouteServiceProvider.php +++ b/app/Providers/RouteServiceProvider.php @@ -17,8 +17,6 @@ class RouteServiceProvider extends ServiceProvider /** * Define your route model bindings, pattern filters, etc. - * - * @return void */ public function boot(): void { @@ -29,8 +27,6 @@ class RouteServiceProvider extends ServiceProvider /** * Define the routes for the application. - * - * @return void */ public function map(): void { @@ -45,8 +41,6 @@ class RouteServiceProvider extends ServiceProvider * Define the "web" routes for the application. * * These routes all receive session state, CSRF protection, etc. - * - * @return void */ protected function mapWebRoutes(): void { @@ -58,8 +52,6 @@ class RouteServiceProvider extends ServiceProvider * Define the "api" routes for the application. * * These routes are typically stateless. - * - * @return void */ protected function mapApiRoutes(): void { diff --git a/app/Setting.php b/app/Setting.php index 243a1adf..360f3c6c 100644 --- a/app/Setting.php +++ b/app/Setting.php @@ -70,10 +70,6 @@ class Setting extends Model */ protected static $cache = []; - /** - * @param Request $request - * @return object - */ public static function getInput(Request $request): object { return (object) [ @@ -198,16 +194,12 @@ class Setting extends Model return $value; } - /** - * @return BelongsTo - */ public function group(): BelongsTo { return $this->belongsTo(\App\SettingGroup::class, 'group_id'); } /** - * @param string $key * * @return mixed */ @@ -220,7 +212,6 @@ class Setting extends Model // @codingStandardsIgnoreStart /** - * @param string $key * * @return mixed */ @@ -267,7 +258,6 @@ class Setting extends Model } /** - * @param string $key * @param $value */ public static function add(string $key, $value) @@ -275,11 +265,6 @@ class Setting extends Model self::$cache[$key] = $value; } - /** - * @param string $key - * - * @return bool - */ public static function cached(string $key): bool { return array_key_exists($key, self::$cache); diff --git a/app/SettingGroup.php b/app/SettingGroup.php index b6d59c87..1544bfc7 100644 --- a/app/SettingGroup.php +++ b/app/SettingGroup.php @@ -37,9 +37,6 @@ class SettingGroup extends Model */ public $timestamps = false; - /** - * @return HasMany - */ public function settings(): HasMany { return $this->hasMany(\App\Setting::class, 'group_id'); diff --git a/database/factories/ItemFactory.php b/database/factories/ItemFactory.php index edbd66d8..3ab4097e 100644 --- a/database/factories/ItemFactory.php +++ b/database/factories/ItemFactory.php @@ -9,8 +9,6 @@ class ItemFactory extends Factory { /** * Define the model's default state. - * - * @return array */ public function definition(): array { diff --git a/database/factories/ItemTagFactory.php b/database/factories/ItemTagFactory.php index cb928a0b..2e2901d2 100644 --- a/database/factories/ItemTagFactory.php +++ b/database/factories/ItemTagFactory.php @@ -10,8 +10,6 @@ class ItemTagFactory extends Factory { /** * Define the model's default state. - * - * @return array */ public function definition(): array { diff --git a/database/factories/UserFactory.php b/database/factories/UserFactory.php index f5f88257..e965b777 100644 --- a/database/factories/UserFactory.php +++ b/database/factories/UserFactory.php @@ -29,8 +29,6 @@ class UserFactory extends Factory /** * Indicate that the model's email address should be unverified. - * - * @return \Illuminate\Database\Eloquent\Factories\Factory */ public function unverified(): Factory { diff --git a/database/migrations/2018_01_27_155922_create_items_table.php b/database/migrations/2018_01_27_155922_create_items_table.php index e6c9267a..ed9577b1 100644 --- a/database/migrations/2018_01_27_155922_create_items_table.php +++ b/database/migrations/2018_01_27_155922_create_items_table.php @@ -8,8 +8,6 @@ return new class extends Migration { /** * Run the migrations. - * - * @return void */ public function up(): void { @@ -29,8 +27,6 @@ return new class extends Migration /** * Reverse the migrations. - * - * @return void */ public function down(): void { diff --git a/database/migrations/2018_02_04_185524_create_settings_table.php b/database/migrations/2018_02_04_185524_create_settings_table.php index a18660bf..f9273079 100644 --- a/database/migrations/2018_02_04_185524_create_settings_table.php +++ b/database/migrations/2018_02_04_185524_create_settings_table.php @@ -8,8 +8,6 @@ return new class extends Migration { /** * Run the migrations. - * - * @return void */ public function up(): void { @@ -28,8 +26,6 @@ return new class extends Migration /** * Reverse the migrations. - * - * @return void */ public function down(): void { diff --git a/database/migrations/2018_02_04_185802_create_setting_groups_table.php b/database/migrations/2018_02_04_185802_create_setting_groups_table.php index acc80592..6600bb1b 100644 --- a/database/migrations/2018_02_04_185802_create_setting_groups_table.php +++ b/database/migrations/2018_02_04_185802_create_setting_groups_table.php @@ -8,8 +8,6 @@ return new class extends Migration { /** * Run the migrations. - * - * @return void */ public function up(): void { @@ -22,8 +20,6 @@ return new class extends Migration /** * Reverse the migrations. - * - * @return void */ public function down(): void { diff --git a/database/migrations/2018_02_16_175830_add_columns_to_items_for_groups.php b/database/migrations/2018_02_16_175830_add_columns_to_items_for_groups.php index 09575c4f..1cc0b018 100644 --- a/database/migrations/2018_02_16_175830_add_columns_to_items_for_groups.php +++ b/database/migrations/2018_02_16_175830_add_columns_to_items_for_groups.php @@ -8,8 +8,6 @@ return new class extends Migration { /** * Run the migrations. - * - * @return void */ public function up(): void { @@ -20,8 +18,6 @@ return new class extends Migration /** * Reverse the migrations. - * - * @return void */ public function down(): void { diff --git a/database/migrations/2018_02_16_193703_item_tag.php b/database/migrations/2018_02_16_193703_item_tag.php index 0bc65ddf..0d088891 100644 --- a/database/migrations/2018_02_16_193703_item_tag.php +++ b/database/migrations/2018_02_16_193703_item_tag.php @@ -8,8 +8,6 @@ return new class extends Migration { /** * Run the migrations. - * - * @return void */ public function up(): void { @@ -25,8 +23,6 @@ return new class extends Migration /** * Reverse the migrations. - * - * @return void */ public function down(): void { diff --git a/database/migrations/2018_10_12_122907_create_users_table.php b/database/migrations/2018_10_12_122907_create_users_table.php index 396ca29c..30947620 100644 --- a/database/migrations/2018_10_12_122907_create_users_table.php +++ b/database/migrations/2018_10_12_122907_create_users_table.php @@ -8,8 +8,6 @@ return new class extends Migration { /** * Run the migrations. - * - * @return void */ public function up(): void { @@ -28,8 +26,6 @@ return new class extends Migration /** * Reverse the migrations. - * - * @return void */ public function down(): void { diff --git a/database/migrations/2018_10_12_123036_create_password_resets_table.php b/database/migrations/2018_10_12_123036_create_password_resets_table.php index b4d45de2..4f42fe69 100644 --- a/database/migrations/2018_10_12_123036_create_password_resets_table.php +++ b/database/migrations/2018_10_12_123036_create_password_resets_table.php @@ -8,8 +8,6 @@ return new class extends Migration { /** * Run the migrations. - * - * @return void */ public function up(): void { @@ -22,8 +20,6 @@ return new class extends Migration /** * Reverse the migrations. - * - * @return void */ public function down(): void { diff --git a/database/migrations/2018_10_12_131222_add_user_id_to_items_table.php b/database/migrations/2018_10_12_131222_add_user_id_to_items_table.php index abf267a1..c499f103 100644 --- a/database/migrations/2018_10_12_131222_add_user_id_to_items_table.php +++ b/database/migrations/2018_10_12_131222_add_user_id_to_items_table.php @@ -8,8 +8,6 @@ return new class extends Migration { /** * Run the migrations. - * - * @return void */ public function up(): void { @@ -20,8 +18,6 @@ return new class extends Migration /** * Reverse the migrations. - * - * @return void */ public function down(): void { diff --git a/database/migrations/2018_10_12_140451_create_setting_user_pivot_table.php b/database/migrations/2018_10_12_140451_create_setting_user_pivot_table.php index 26f92076..157c9944 100644 --- a/database/migrations/2018_10_12_140451_create_setting_user_pivot_table.php +++ b/database/migrations/2018_10_12_140451_create_setting_user_pivot_table.php @@ -8,8 +8,6 @@ return new class extends Migration { /** * Run the migrations. - * - * @return void */ public function up(): void { @@ -25,8 +23,6 @@ return new class extends Migration /** * Reverse the migrations. - * - * @return void */ public function down(): void { diff --git a/database/migrations/2018_10_18_110905_create_applications_table.php b/database/migrations/2018_10_18_110905_create_applications_table.php index f4bb3cc8..daa82b44 100644 --- a/database/migrations/2018_10_18_110905_create_applications_table.php +++ b/database/migrations/2018_10_18_110905_create_applications_table.php @@ -8,8 +8,6 @@ return new class extends Migration { /** * Run the migrations. - * - * @return void */ public function up(): void { @@ -30,8 +28,6 @@ return new class extends Migration /** * Reverse the migrations. - * - * @return void */ public function down(): void { diff --git a/database/migrations/2018_10_23_132008_add_class_to_items_table.php b/database/migrations/2018_10_23_132008_add_class_to_items_table.php index 63c63e7d..2fae9bc1 100644 --- a/database/migrations/2018_10_23_132008_add_class_to_items_table.php +++ b/database/migrations/2018_10_23_132008_add_class_to_items_table.php @@ -8,8 +8,6 @@ return new class extends Migration { /** * Run the migrations. - * - * @return void */ public function up(): void { @@ -20,8 +18,6 @@ return new class extends Migration /** * Reverse the migrations. - * - * @return void */ public function down(): void { diff --git a/database/migrations/2018_10_31_191604_create_jobs_table.php b/database/migrations/2018_10_31_191604_create_jobs_table.php index 560ae54b..6098d9b1 100644 --- a/database/migrations/2018_10_31_191604_create_jobs_table.php +++ b/database/migrations/2018_10_31_191604_create_jobs_table.php @@ -8,8 +8,6 @@ return new class extends Migration { /** * Run the migrations. - * - * @return void */ public function up(): void { @@ -26,8 +24,6 @@ return new class extends Migration /** * Reverse the migrations. - * - * @return void */ public function down(): void { diff --git a/database/migrations/2018_11_06_112434_create_failed_jobs_table.php b/database/migrations/2018_11_06_112434_create_failed_jobs_table.php index 3bafc3bf..b1b6dfcd 100644 --- a/database/migrations/2018_11_06_112434_create_failed_jobs_table.php +++ b/database/migrations/2018_11_06_112434_create_failed_jobs_table.php @@ -8,8 +8,6 @@ return new class extends Migration { /** * Run the migrations. - * - * @return void */ public function up(): void { @@ -25,8 +23,6 @@ return new class extends Migration /** * Reverse the migrations. - * - * @return void */ public function down(): void { diff --git a/database/migrations/2022_03_15_140911_add_appid_to_items.php b/database/migrations/2022_03_15_140911_add_appid_to_items.php index d89f014a..2ca107fe 100644 --- a/database/migrations/2022_03_15_140911_add_appid_to_items.php +++ b/database/migrations/2022_03_15_140911_add_appid_to_items.php @@ -8,8 +8,6 @@ return new class extends Migration { /** * Run the migrations. - * - * @return void */ public function up(): void { @@ -20,8 +18,6 @@ return new class extends Migration /** * Reverse the migrations. - * - * @return void */ public function down(): void { diff --git a/database/migrations/2022_03_16_093044_add_class_to_application.php b/database/migrations/2022_03_16_093044_add_class_to_application.php index 11fc36b1..8dbd80ca 100644 --- a/database/migrations/2022_03_16_093044_add_class_to_application.php +++ b/database/migrations/2022_03_16_093044_add_class_to_application.php @@ -8,8 +8,6 @@ return new class extends Migration { /** * Run the migrations. - * - * @return void */ public function up(): void { @@ -20,8 +18,6 @@ return new class extends Migration /** * Reverse the migrations. - * - * @return void */ public function down(): void { diff --git a/database/migrations/2022_03_16_181343_add_app_description_to_items.php b/database/migrations/2022_03_16_181343_add_app_description_to_items.php index 250e35bb..cdb6981f 100644 --- a/database/migrations/2022_03_16_181343_add_app_description_to_items.php +++ b/database/migrations/2022_03_16_181343_add_app_description_to_items.php @@ -8,8 +8,6 @@ return new class extends Migration { /** * Run the migrations. - * - * @return void */ public function up(): void { @@ -20,8 +18,6 @@ return new class extends Migration /** * Reverse the migrations. - * - * @return void */ public function down(): void { diff --git a/database/migrations/2024_02_16_000000_rename_password_resets_table.php b/database/migrations/2024_02_16_000000_rename_password_resets_table.php index ab300e6e..f0ad3757 100644 --- a/database/migrations/2024_02_16_000000_rename_password_resets_table.php +++ b/database/migrations/2024_02_16_000000_rename_password_resets_table.php @@ -8,8 +8,6 @@ return new class extends Migration { /** * Run the migrations. - * - * @return void */ public function up(): void { @@ -18,8 +16,6 @@ return new class extends Migration /** * Reverse the migrations. - * - * @return void */ public function down(): void { diff --git a/database/seeders/DatabaseSeeder.php b/database/seeders/DatabaseSeeder.php index 5a983e90..5cd1737c 100644 --- a/database/seeders/DatabaseSeeder.php +++ b/database/seeders/DatabaseSeeder.php @@ -8,8 +8,6 @@ class DatabaseSeeder extends Seeder { /** * Run the database seeds. - * - * @return void */ public function run(): void { diff --git a/database/seeders/SettingsSeeder.php b/database/seeders/SettingsSeeder.php index 47704ab0..ff000ca0 100644 --- a/database/seeders/SettingsSeeder.php +++ b/database/seeders/SettingsSeeder.php @@ -52,8 +52,6 @@ class SettingsSeeder extends Seeder /** * Run the database seeds. - * - * @return void */ public function run(): void { diff --git a/database/seeders/UsersSeeder.php b/database/seeders/UsersSeeder.php index 69230021..1c729a27 100644 --- a/database/seeders/UsersSeeder.php +++ b/database/seeders/UsersSeeder.php @@ -9,8 +9,6 @@ class UsersSeeder extends Seeder { /** * Run the database seeds. - * - * @return void */ public function run(): void { diff --git a/tests/CreatesApplication.php b/tests/CreatesApplication.php index ebba2703..e2dc0db5 100644 --- a/tests/CreatesApplication.php +++ b/tests/CreatesApplication.php @@ -9,8 +9,6 @@ trait CreatesApplication { /** * Creates the application. - * - * @return \Illuminate\Foundation\Application */ public function createApplication(): Application { diff --git a/tests/Unit/database/seeders/SettingsSeederTest.php b/tests/Unit/database/seeders/SettingsSeederTest.php index 25320f26..d257092b 100644 --- a/tests/Unit/database/seeders/SettingsSeederTest.php +++ b/tests/Unit/database/seeders/SettingsSeederTest.php @@ -9,8 +9,6 @@ class SettingsSeederTest extends TestCase { /** * All language keys are defined in all languages based on the en language file. - * - * @return void */ public function test_returns_a_jsonmap_with_same_amount_of_items_as_language_directories_present(): void { diff --git a/tests/Unit/helpers/IsImageTest.php b/tests/Unit/helpers/IsImageTest.php index 189d097b..facad313 100644 --- a/tests/Unit/helpers/IsImageTest.php +++ b/tests/Unit/helpers/IsImageTest.php @@ -6,9 +6,6 @@ use Tests\TestCase; class IsImageTest extends TestCase { - /** - * @return void - */ public function test_returns_true_when_file_is_image(): void { $file = file_get_contents(__DIR__ . '/fixtures/heimdall-icon-small.png'); @@ -18,9 +15,6 @@ class IsImageTest extends TestCase $this->assertTrue($actual); } - /** - * @return void - */ public function test_returns_false_when_file_extension_is_image_but_content_is_not(): void { $actual = isImage("", "png"); @@ -28,9 +22,6 @@ class IsImageTest extends TestCase $this->assertFalse($actual); } - /** - * @return void - */ public function test_returns_false_when_file_extension_is_not_image_but_content_is(): void { $file = file_get_contents(__DIR__ . '/fixtures/heimdall-icon-small.png'); diff --git a/tests/Unit/helpers/SlugTest.php b/tests/Unit/helpers/SlugTest.php index fdb63203..17aed922 100644 --- a/tests/Unit/helpers/SlugTest.php +++ b/tests/Unit/helpers/SlugTest.php @@ -6,9 +6,6 @@ use Tests\TestCase; class SlugTest extends TestCase { - /** - * @return void - */ public function test_slug_returns_valid_tag_for_cn_characters_when_language_is_set_to_en_US(): void { $tag = str_slug('中文測試', '-', 'en_US'); diff --git a/tests/Unit/lang/LangTest.php b/tests/Unit/lang/LangTest.php index dc84c8e8..7712811f 100644 --- a/tests/Unit/lang/LangTest.php +++ b/tests/Unit/lang/LangTest.php @@ -8,8 +8,6 @@ class LangTest extends TestCase { /** * All language keys are defined in all languages based on the en language file. - * - * @return void */ public function test_all_language_keys_are_defined(): void {