Deprecate UMASK_SET in favor of UMASK in baseimage

This commit is contained in:
Roxedus
2021-01-20 13:11:01 +01:00
parent 7487834749
commit 7badc41d09
3 changed files with 14 additions and 16 deletions

View File

@@ -85,7 +85,6 @@ services:
- PUID=1000
- PGID=1000
- TZ=Europe/London
- UMASK_SET=<022> #optional
volumes:
- /path/to/library:/config
- path/to/tvseries:/data/tvshows
@@ -112,7 +111,6 @@ docker run -d \
-e PUID=1000 \
-e PGID=1000 \
-e TZ=Europe/London \
-e UMASK_SET=<022> `#optional` \
-p 8096:8096 \
-p 8920:8920 `#optional` \
-v /path/to/library:/config \
@@ -141,7 +139,6 @@ Container images are configured using parameters passed at runtime (such as thos
| `-e PUID=1000` | for UserID - see below for explanation |
| `-e PGID=1000` | for GroupID - see below for explanation |
| `-e TZ=Europe/London` | Specify a timezone to use EG Europe/London |
| `-e UMASK_SET=<022>` | for umask setting of Emby, default if left unset is 022. |
| `-v /config` | Jellyfin data storage location. *This can grow very large, 50gb+ is likely for a large collection.* |
| `-v /data/tvshows` | Media goes here. Add as many as needed e.g. `/data/movies`, `/data/tv`, etc. |
| `-v /data/movies` | Media goes here. Add as many as needed e.g. `/data/movies`, `/data/tv`, etc. |
@@ -300,6 +297,7 @@ Once registered you can define the dockerfile to use with `-f Dockerfile.aarch64
## Versions
* **20.01.21:"** - Deprecate `UMASK_SET` in favor of UMASK in baseimage, see above for more information.
* **05.01.21:** - Add nvidia.icd file to fix missing tonemapping using Nvidia HW.
* **23.11.20:** - Rebase to Focal, branch off Bionic.
* **22.07.20:** - Install nightly from unstable.

View File

@@ -35,9 +35,7 @@ param_usage_include_env: true
param_env_vars:
- { env_var: "TZ", env_value: "Europe/London", desc: "Specify a timezone to use EG Europe/London"}
# optional container parameters
opt_param_usage_include_env: true
opt_param_env_vars:
- { env_var: "UMASK_SET", env_value: "<022>", desc: "for umask setting of Emby, default if left unset is 022."}
opt_param_usage_include_env: false
opt_param_usage_include_vols: true
opt_param_volumes:
- { vol_path: "/opt/vc/lib", vol_host_path: "/opt/vc/lib", desc: "Path for Raspberry Pi OpenMAX libs *optional*." }
@@ -100,6 +98,7 @@ app_setup_block: |
# changelog
changelogs:
- { date: 20.01.21:", desc: "Deprecate `UMASK_SET` in favor of UMASK in baseimage, see above for more information." }
- { date: "05.01.21:", desc: "Add nvidia.icd file to fix missing tonemapping using Nvidia HW." }
- { date: "23.11.20:", desc: "Rebase to Focal, branch off Bionic." }
- { date: "22.07.20:", desc: "Install nightly from unstable." }

View File

@@ -6,9 +6,10 @@ JELLYFIN_LOG_DIR="/config/log" \
JELLYFIN_CACHE_DIR="/config/cache" \
JELLYFIN_WEB_DIR="/usr/share/jellyfin/web"
# set umask
UMASK_SET=${UMASK_SET:-022}
umask "$UMASK_SET"
if [ -n "${UMASK_SET}" ] && [ -z "${UMASK}" ]; then
echo -e "You are using a legacy method of defining umask\nplease update your environment variable from UMASK_SET to UMASK\nto keep the functionality after July 2021"
umask ${UMASK_SET}
fi
exec \
s6-setuidgid abc /usr/bin/jellyfin \