mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-31 21:28:11 +09:00 
			
		
		
		
	Improve install code to avoid low-level mistakes. (#17779)
* Improve install code to avoid low-level mistakes. If a user tries to do a re-install in a Gitea database, they gets a warning and double check. When Gitea runs, it never create empty app.ini automatically. Also some small (related) refactoring: * Refactor db.InitEngine related logic make it more clean (especially for the install code) * Move some i18n strings out from setting.go to make the setting.go can be easily maintained. * Show errors in CLI code if an incorrect app.ini is used. * APP_DATA_PATH is created when installing, and checked when starting (no empty directory is created any more).
This commit is contained in:
		| @@ -164,8 +164,8 @@ func initIntegrationTest() { | ||||
| 	} | ||||
|  | ||||
| 	setting.SetCustomPathAndConf("", "", "") | ||||
| 	setting.NewContext() | ||||
| 	util.RemoveAll(models.LocalCopyPath()) | ||||
| 	setting.LoadForTest() | ||||
| 	_ = util.RemoveAll(models.LocalCopyPath()) | ||||
| 	git.CheckLFSVersion() | ||||
| 	setting.InitDBConfig() | ||||
| 	if err := storage.Init(); err != nil { | ||||
| @@ -240,7 +240,8 @@ func initIntegrationTest() { | ||||
| 		} | ||||
| 		defer db.Close() | ||||
| 	} | ||||
| 	routers.GlobalInit(graceful.GetManager().HammerContext()) | ||||
|  | ||||
| 	routers.GlobalInitInstalled(graceful.GetManager().HammerContext()) | ||||
| } | ||||
|  | ||||
| func prepareTestEnv(t testing.TB, skip ...int) func() { | ||||
| @@ -254,6 +255,7 @@ func prepareTestEnv(t testing.TB, skip ...int) func() { | ||||
| 	assert.NoError(t, util.RemoveAll(setting.RepoRootPath)) | ||||
|  | ||||
| 	assert.NoError(t, util.CopyDir(path.Join(filepath.Dir(setting.AppPath), "integrations/gitea-repositories-meta"), setting.RepoRootPath)) | ||||
|  | ||||
| 	return deferFn | ||||
| } | ||||
|  | ||||
|   | ||||
		Reference in New Issue
	
	Block a user