refactor: clarify GOOS detection (#39620)

Introduce `consts.IsWindows`, now it's clearer to see how Windows build works

modules/setting/path.go

@@ -10,6 +10,7 @@ import (
 	"path/filepath"
 	"strings"
 
+	"gitea.dev/modules/consts"
 	"gitea.dev/modules/log"
 	"gitea.dev/modules/tempdir"
 )
@@ -39,7 +40,7 @@ var (
 func getAppPath() (string, error) {
 	var appPath string
 	var err error
-	if IsWindows && filepath.IsAbs(os.Args[0]) {
+	if consts.IsWindows && filepath.IsAbs(os.Args[0]) {
 		appPath = filepath.Clean(os.Args[0])
 	} else {
 		appPath, err = exec.LookPath(os.Args[0])

modules/setting/setting.go

@@ -8,18 +8,16 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
-	"runtime"
 	"strings"
 	"time"
 
+	"gitea.dev/modules/consts"
 	"gitea.dev/modules/log"
 	"gitea.dev/modules/optional"
 	"gitea.dev/modules/user"
 	"gitea.dev/modules/util"
 )
 
-const IsWindows = runtime.GOOS == "windows"
-
 var (
 	// AppVer is the version of the current build of Gitea. It is set in main.go from main.Version.
 	AppVer string
@@ -52,7 +50,7 @@ func init() {
 // This check is ignored under Windows since SSH remote login is not the main
 // method to login on Windows.
 func IsRunUserMatchCurrentUser(runUser string) (string, bool) {
-	if IsWindows || SSH.StartBuiltinServer {
+	if consts.IsWindows || SSH.StartBuiltinServer {
 		return "", true
 	}
 

modules/setting/testenv.go

@@ -12,6 +12,7 @@ import (
 	"strings"
 
 	"gitea.dev/modules/auth/password/hash"
+	"gitea.dev/modules/consts"
 	"gitea.dev/modules/log"
 	"gitea.dev/modules/util"
 
@@ -66,7 +67,7 @@ func SetupGiteaTestEnv() {
 		StaticRootPath = giteaRoot
 		// during testing, the AppPath must point to the pre-built Gitea binary in the source root
 		// it needs to be called by git hooks
-		AppPath = filepath.Join(giteaRoot, "gitea") + util.Iif(IsWindows, ".exe", "")
+		AppPath = filepath.Join(giteaRoot, "gitea") + util.Iif(consts.IsWindows, ".exe", "")
 	}
 
 	initGiteaConf := func() string {