mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-31 21:28:11 +09:00 
			
		
		
		
	Clarify path param naming (#32969)
In history (from some legacy frameworks), both `:name` and `name` are supported as path path name, `:name` is an alias to `name`. To make code consistent, now we should only use `name` but not `:name`. Also added panic check in related functions to make sure the name won't be abused in case some downstreams still use them.
This commit is contained in:
		| @@ -40,7 +40,7 @@ func (org *Organization) CanReadUnit(ctx *Context, unitType unit.Type) bool { | ||||
| } | ||||
|  | ||||
| func GetOrganizationByParams(ctx *Context) { | ||||
| 	orgName := ctx.PathParam(":org") | ||||
| 	orgName := ctx.PathParam("org") | ||||
|  | ||||
| 	var err error | ||||
|  | ||||
| @@ -220,7 +220,7 @@ func HandleOrgAssignment(ctx *Context, args ...bool) { | ||||
| 		ctx.Data["NumTeams"] = len(ctx.Org.Teams) | ||||
| 	} | ||||
|  | ||||
| 	teamName := ctx.PathParam(":team") | ||||
| 	teamName := ctx.PathParam("team") | ||||
| 	if len(teamName) > 0 { | ||||
| 		teamExists := false | ||||
| 		for _, team := range ctx.Org.Teams { | ||||
|   | ||||
		Reference in New Issue
	
	Block a user