mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-31 21:28:11 +09:00 
			
		
		
		
	Refactor web package and context package (#25298)
1. The "web" package shouldn't depends on "modules/context" package, instead, let each "web context" register themselves to the "web" package. 2. The old Init/Free doesn't make sense, so simplify it * The ctx in "Init(ctx)" is never used, and shouldn't be used that way * The "Free" is never called and shouldn't be called because the SSPI instance is shared --------- Co-authored-by: Giteabot <teabot@gitea.io>
This commit is contained in:
		| @@ -64,7 +64,6 @@ | ||||
| package v1 | ||||
|  | ||||
| import ( | ||||
| 	gocontext "context" | ||||
| 	"fmt" | ||||
| 	"net/http" | ||||
| 	"strings" | ||||
| @@ -705,7 +704,7 @@ func buildAuthGroup() *auth.Group { | ||||
| } | ||||
|  | ||||
| // Routes registers all v1 APIs routes to web application. | ||||
| func Routes(ctx gocontext.Context) *web.Route { | ||||
| func Routes() *web.Route { | ||||
| 	m := web.NewRoute() | ||||
|  | ||||
| 	m.Use(securityHeaders()) | ||||
| @@ -722,13 +721,8 @@ func Routes(ctx gocontext.Context) *web.Route { | ||||
| 	} | ||||
| 	m.Use(context.APIContexter()) | ||||
|  | ||||
| 	group := buildAuthGroup() | ||||
| 	if err := group.Init(ctx); err != nil { | ||||
| 		log.Error("Could not initialize '%s' auth method, error: %s", group.Name(), err) | ||||
| 	} | ||||
|  | ||||
| 	// Get user from session if logged in. | ||||
| 	m.Use(auth.APIAuth(group)) | ||||
| 	m.Use(auth.APIAuth(buildAuthGroup())) | ||||
|  | ||||
| 	m.Use(auth.VerifyAuthWithOptionsAPI(&auth.VerifyOptions{ | ||||
| 		SignInRequired: setting.Service.RequireSignInView, | ||||
|   | ||||
		Reference in New Issue
	
	Block a user