chore: clean up tests (#37715)

1. use MockVariableValue as much as possible
2. use wg.Go as much as possible instead of Add/Done
3. simplify global lock's DefaultLocker logic to make it easier to test
4. introduce a general approach for getting external service config in
CI
5. remove unclear & unnecessary "t.Skip"
6. use modern generic syntax for remaining "DecodeJSON" calls
7. clarify test result for "list gitignore templates" and "list
licenses"
This commit is contained in:
wxiaoguang
2026-05-15 22:26:36 +08:00
committed by GitHub
parent cf0f25b798
commit 59db4154eb
39 changed files with 208 additions and 313 deletions

View File

@@ -10,6 +10,7 @@ import (
"code.gitea.io/gitea/modules/options"
repo_module "code.gitea.io/gitea/modules/repository"
"code.gitea.io/gitea/modules/setting"
api "code.gitea.io/gitea/modules/structs"
"code.gitea.io/gitea/tests"
@@ -22,8 +23,12 @@ func TestAPIListLicenseTemplates(t *testing.T) {
req := NewRequest(t, "GET", "/api/v1/licenses")
resp := MakeRequest(t, req, http.StatusOK)
// This tests if the API returns a list of strings
DecodeJSON(t, resp, []api.LicensesTemplateListEntry{})
licenseList := DecodeJSON(t, resp, []api.LicensesTemplateListEntry{})
assert.Contains(t, licenseList, api.LicensesTemplateListEntry{
Key: "MIT",
Name: "MIT",
URL: setting.AppURL + "api/v1/licenses/MIT",
})
}
func TestAPIGetLicenseTemplateInfo(t *testing.T) {