mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-31 21:28:11 +09:00 
			
		
		
		
	Fix sub-command log level (#25537)
More fix for #24981 * #24981 Close #22361 * #22361 There were many patches for Gitea's sub-commands to satisfy the facts: * Some sub-commands shouldn't output any log, otherwise the git protocol would be broken * Sometimes the users want to see "verbose" or "quiet" outputs That's a longstanding problem, and very fragile. This PR is only a quick patch for the problem. In the future, the sub-command system should be refactored to a clear solution. ---- Other changes: * Use `ReplaceAllWriters` to replace `RemoveAllWriters().AddWriters(writer)`, then it's an atomic operation. * Remove unnecessary `syncLevelInternal` calls, because `AddWriters/addWritersInternal` already calls it. Co-authored-by: Giteabot <teabot@gitea.io>
This commit is contained in:
		| @@ -35,6 +35,7 @@ var CmdWeb = cli.Command{ | ||||
| 	Usage: "Start Gitea web server", | ||||
| 	Description: `Gitea web server is the only thing you need to run, | ||||
| and it takes care of all the other things for you`, | ||||
| 	Before: PrepareConsoleLoggerLevel(log.INFO), | ||||
| 	Action: runWeb, | ||||
| 	Flags: []cli.Flag{ | ||||
| 		cli.StringFlag{ | ||||
| @@ -206,11 +207,6 @@ func servePprof() { | ||||
| } | ||||
|  | ||||
| func runWeb(ctx *cli.Context) error { | ||||
| 	if ctx.Bool("verbose") { | ||||
| 		setupConsoleLogger(log.TRACE, log.CanColorStdout, os.Stdout) | ||||
| 	} else if ctx.Bool("quiet") { | ||||
| 		setupConsoleLogger(log.FATAL, log.CanColorStdout, os.Stdout) | ||||
| 	} | ||||
| 	defer func() { | ||||
| 		if panicked := recover(); panicked != nil { | ||||
| 			log.Fatal("PANIC: %v\n%s", panicked, log.Stack(2)) | ||||
|   | ||||
		Reference in New Issue
	
	Block a user