mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-29 10:57:44 +09:00 
			
		
		
		
	Avoiding accessing undefined mentionValues (#26461)
The `window.config.mentionValues` might be undefined: 
```
{{if or .Participants .Assignees .MentionableTeams}}
    mentionValues: ...
{{end}}
```
			
			
This commit is contained in:
		| @@ -31,7 +31,7 @@ function makeCollections({mentions, emoji}) { | ||||
|  | ||||
|   if (mentions) { | ||||
|     collections.push({ | ||||
|       values: window.config.mentionValues, | ||||
|       values: window.config.mentionValues ?? [], | ||||
|       requireLeadingSpace: true, | ||||
|       menuItemTemplate: (item) => { | ||||
|         return ` | ||||
|   | ||||
| @@ -32,7 +32,7 @@ export function matchMention(queryText) { | ||||
|  | ||||
|   // results is a map of weights, lower is better | ||||
|   const results = new Map(); | ||||
|   for (const obj of window.config.mentionValues) { | ||||
|   for (const obj of window.config.mentionValues ?? []) { | ||||
|     const index = obj.key.toLowerCase().indexOf(query); | ||||
|     if (index === -1) continue; | ||||
|     const existing = results.get(obj); | ||||
|   | ||||
		Reference in New Issue
	
	Block a user