mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-29 10:57:44 +09:00 
			
		
		
		
	Handle push rejection in branch and upload (#10854)
* Handle push rejections and push out-of-date in branch creation and file upload. * Remove the duplicated sanitize from services/pull/merge * Move the errors Err(Merge)PushOutOfDate and ErrPushRejected to modules/git * Handle errors better in the upload file dialogs Fix #10460 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
This commit is contained in:
		| @@ -385,15 +385,13 @@ func rawMerge(pr *models.PullRequest, doer *models.User, mergeStyle models.Merge | ||||
| 	// Push back to upstream. | ||||
| 	if err := git.NewCommand("push", "origin", baseBranch+":"+pr.BaseBranch).RunInDirTimeoutEnvPipeline(env, -1, tmpBasePath, &outbuf, &errbuf); err != nil { | ||||
| 		if strings.Contains(errbuf.String(), "non-fast-forward") { | ||||
| 			return "", models.ErrMergePushOutOfDate{ | ||||
| 				Style:  mergeStyle, | ||||
| 			return "", &git.ErrPushOutOfDate{ | ||||
| 				StdOut: outbuf.String(), | ||||
| 				StdErr: errbuf.String(), | ||||
| 				Err:    err, | ||||
| 			} | ||||
| 		} else if strings.Contains(errbuf.String(), "! [remote rejected]") { | ||||
| 			err := models.ErrPushRejected{ | ||||
| 				Style:  mergeStyle, | ||||
| 			err := &git.ErrPushRejected{ | ||||
| 				StdOut: outbuf.String(), | ||||
| 				StdErr: errbuf.String(), | ||||
| 				Err:    err, | ||||
|   | ||||
		Reference in New Issue
	
	Block a user