mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-31 21:28:11 +09:00 
			
		
		
		
	Refactor AssertExistsAndLoadBean to use generics (#20797)
* Refactor AssertExistsAndLoadBean to use generics * Fix tests Co-authored-by: zeripath <art27@cantab.net>
This commit is contained in:
		| @@ -20,9 +20,9 @@ import ( | ||||
| func TestCreateComment(t *testing.T) { | ||||
| 	assert.NoError(t, unittest.PrepareTestDatabase()) | ||||
|  | ||||
| 	issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{}).(*issues_model.Issue) | ||||
| 	repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: issue.RepoID}).(*repo_model.Repository) | ||||
| 	doer := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID}).(*user_model.User) | ||||
| 	issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{}) | ||||
| 	repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: issue.RepoID}) | ||||
| 	doer := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID}) | ||||
|  | ||||
| 	now := time.Now().Unix() | ||||
| 	comment, err := issues_model.CreateComment(&issues_model.CreateCommentOptions{ | ||||
| @@ -42,15 +42,15 @@ func TestCreateComment(t *testing.T) { | ||||
| 	unittest.AssertInt64InRange(t, now, then, int64(comment.CreatedUnix)) | ||||
| 	unittest.AssertExistsAndLoadBean(t, comment) // assert actually added to DB | ||||
|  | ||||
| 	updatedIssue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: issue.ID}).(*issues_model.Issue) | ||||
| 	updatedIssue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: issue.ID}) | ||||
| 	unittest.AssertInt64InRange(t, now, then, int64(updatedIssue.UpdatedUnix)) | ||||
| } | ||||
|  | ||||
| func TestFetchCodeComments(t *testing.T) { | ||||
| 	assert.NoError(t, unittest.PrepareTestDatabase()) | ||||
|  | ||||
| 	issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 2}).(*issues_model.Issue) | ||||
| 	user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1}).(*user_model.User) | ||||
| 	issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 2}) | ||||
| 	user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1}) | ||||
| 	res, err := issues_model.FetchCodeComments(db.DefaultContext, issue, user) | ||||
| 	assert.NoError(t, err) | ||||
| 	assert.Contains(t, res, "README.md") | ||||
| @@ -58,7 +58,7 @@ func TestFetchCodeComments(t *testing.T) { | ||||
| 	assert.Len(t, res["README.md"][4], 1) | ||||
| 	assert.Equal(t, int64(4), res["README.md"][4][0].ID) | ||||
|  | ||||
| 	user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2}).(*user_model.User) | ||||
| 	user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2}) | ||||
| 	res, err = issues_model.FetchCodeComments(db.DefaultContext, issue, user2) | ||||
| 	assert.NoError(t, err) | ||||
| 	assert.Len(t, res, 1) | ||||
|   | ||||
		Reference in New Issue
	
	Block a user