test: consolidate Go tests (#39962)

Consolidate all Go tests. Coverage is identical to before. Go tests are
around 5% faster while being 7% smaller. No non-test code is touched.

modelmigration/base/db_test.go

@@ -45,38 +45,15 @@ func Test_DropTableColumns(t *testing.T) {
 	x.SetMapper(names.GonicMapper{})
 
 	for i := range columns {
-		if err := x.Sync(new(DropTest)); err != nil {
-			t.Errorf("unable to create DropTest table: %v", err)
-			return
-		}
-
-		sess := x.NewSession()
-		if err := sess.Begin(); err != nil {
-			sess.Close()
-			t.Errorf("unable to begin transaction: %v", err)
-			return
-		}
-		if err := base.DropTableColumns(sess, "drop_test", columns[i:]...); err != nil {
-			sess.Close()
-			t.Errorf("Unable to drop columns[%d:]: %s from drop_test: %v", i, columns[i:], err)
-			return
-		}
-		if err := sess.Commit(); err != nil {
-			sess.Close()
-			t.Errorf("unable to commit transaction: %v", err)
-			return
-		}
-		sess.Close()
-		if err := x.DropTables(new(DropTest)); err != nil {
-			t.Errorf("unable to drop table: %v", err)
-			return
-		}
-		for j := range columns[i+1:] {
+		for j := i; j < len(columns); j++ {
 			if err := x.Sync(new(DropTest)); err != nil {
 				t.Errorf("unable to create DropTest table: %v", err)
 				return
 			}
-			dropcols := append([]string{columns[i]}, columns[j+i+1:]...)
+			dropcols := columns[i:]
+			if j > i {
+				dropcols = append([]string{columns[i]}, columns[j:]...)
+			}
 			sess := x.NewSession()
 			if err := sess.Begin(); err != nil {
 				sess.Close()
@@ -85,7 +62,11 @@ func Test_DropTableColumns(t *testing.T) {
 			}
 			if err := base.DropTableColumns(sess, "drop_test", dropcols...); err != nil {
 				sess.Close()
-				t.Errorf("Unable to drop columns: %s from drop_test: %v", dropcols, err)
+				if j == i {
+					t.Errorf("Unable to drop columns[%d:]: %s from drop_test: %v", i, columns[i:], err)
+				} else {
+					t.Errorf("Unable to drop columns: %s from drop_test: %v", dropcols, err)
+				}
 				return
 			}
 			if err := sess.Commit(); err != nil {

modelmigration/v1_20/v259_test.go

@@ -78,12 +78,17 @@ func Test_ConvertScopedAccessTokens(t *testing.T) {
 	assert.NoError(t, err)
 	assert.Equal(t, int64(0), count)
 
+	session := x.NewSession()
+	defer session.Close()
+	assert.NoError(t, session.Begin())
+
 	for _, tc := range tests {
-		_, err = x.Insert(&AccessToken{
+		_, err = session.Insert(&AccessToken{
 			Scope: string(tc.Old),
 		})
 		assert.NoError(t, err)
 	}
+	assert.NoError(t, session.Commit())
 
 	// migrate the scopes
 	err = ConvertScopedAccessTokens(t.Context(), x)

modelmigration/v1_26/v329_test.go

@@ -43,13 +43,11 @@ func Test_AddUniqueIndexForUserBadge(t *testing.T) {
 	}
 
 	// check that we have duplicates
-	count, err := x.Where("user_id = ? AND badge_id = ?", 1, 1).Count(&UserBadgeBefore{})
-	assert.NoError(t, err)
-	assert.Equal(t, int64(2), count)
-
-	count, err = x.Where("user_id = ? AND badge_id = ?", 3, 3).Count(&UserBadgeBefore{})
-	assert.NoError(t, err)
-	assert.Equal(t, int64(2), count)
+	for _, userID := range []int{1, 3} {
+		count, err := x.Where("user_id = ? AND badge_id = ?", userID, userID).Count(&UserBadgeBefore{})
+		assert.NoError(t, err)
+		assert.Equal(t, int64(2), count)
+	}
 
 	totalCount, err := x.Count(&UserBadgeBefore{})
 	assert.NoError(t, err)
@@ -62,13 +60,11 @@ func Test_AddUniqueIndexForUserBadge(t *testing.T) {
 	}
 
 	// verify the duplicates were removed
-	count, err = x.Where("user_id = ? AND badge_id = ?", 1, 1).Count(&UserBadgeBefore{})
-	assert.NoError(t, err)
-	assert.Equal(t, int64(1), count)
-
-	count, err = x.Where("user_id = ? AND badge_id = ?", 3, 3).Count(&UserBadgeBefore{})
-	assert.NoError(t, err)
-	assert.Equal(t, int64(1), count)
+	for _, userID := range []int{1, 3} {
+		count, err := x.Where("user_id = ? AND badge_id = ?", userID, userID).Count(&UserBadgeBefore{})
+		assert.NoError(t, err)
+		assert.Equal(t, int64(1), count)
+	}
 
 	// check total count
 	totalCount, err = x.Count(&UserBadgeBefore{})