test: consolidate Go tests (#39962)

Consolidate all Go tests. Coverage is identical to before. Go tests are
around 5% faster while being 7% smaller. No non-test code is touched.

models/repo/pull_request_default_test.go

@@ -33,46 +33,37 @@ func TestDefaultTargetBranchSelection(t *testing.T) {
 }
 
 func TestPullRequestConfigFromDB(t *testing.T) {
-	cases := []struct {
+	for _, tc := range []struct {
 		// name describes the row shape under test; the comments capture why each row matters.
-		name              string
-		json              string
-		wantMergeUpdate   bool
-		wantRebaseUpdate  bool
-		wantDefaultStyle  UpdateStyle
-		wantValidatesPass bool
+		name             string
+		json             string
+		wantRebaseUpdate bool
 	}{
 		{
 			// Empty object exercises the all-defaults path (e.g. fresh repos created via low-level paths).
 			name: "defaults", json: "{}",
-			wantMergeUpdate: true, wantRebaseUpdate: true,
-			wantDefaultStyle: UpdateStyleMerge, wantValidatesPass: true,
+			wantRebaseUpdate: true,
 		},
 		{
 			// Realistic upgrade case: pre-PR JSON lacks the new fields and has AllowRebaseUpdate=false.
 			// Historical setting must be preserved while new fields take safe defaults.
-			name:            "legacy without new fields",
-			json:            `{"AllowMerge":true,"AllowRebase":true,"AllowRebaseMerge":true,"AllowSquash":true,"AllowRebaseUpdate":false}`,
-			wantMergeUpdate: true, wantRebaseUpdate: false,
-			wantDefaultStyle: UpdateStyleMerge, wantValidatesPass: true,
+			name:             "legacy without new fields",
+			json:             `{"AllowMerge":true,"AllowRebase":true,"AllowRebaseMerge":true,"AllowSquash":true,"AllowRebaseUpdate":false}`,
+			wantRebaseUpdate: false,
 		},
 		{
 			// Partially-migrated row with explicit empty string must normalize so ValidateUpdateSettings passes.
 			name: "empty default style", json: `{"DefaultUpdateStyle":""}`,
-			wantMergeUpdate: true, wantRebaseUpdate: true,
-			wantDefaultStyle: UpdateStyleMerge, wantValidatesPass: true,
+			wantRebaseUpdate: true,
 		},
-	}
-	for _, tc := range cases {
+	} {
 		t.Run(tc.name, func(t *testing.T) {
 			cfg := new(PullRequestsConfig)
 			assert.NoError(t, cfg.FromDB([]byte(tc.json)))
-			assert.Equal(t, tc.wantMergeUpdate, cfg.AllowMergeUpdate)
+			assert.True(t, cfg.AllowMergeUpdate)
 			assert.Equal(t, tc.wantRebaseUpdate, cfg.AllowRebaseUpdate)
-			assert.Equal(t, tc.wantDefaultStyle, cfg.DefaultUpdateStyle)
-			if tc.wantValidatesPass {
-				assert.NoError(t, cfg.ValidateUpdateSettings())
-			}
+			assert.Equal(t, UpdateStyleMerge, cfg.DefaultUpdateStyle)
+			assert.NoError(t, cfg.ValidateUpdateSettings())
 		})
 	}
 }