test: consolidate Go tests (#39962)

Consolidate all Go tests. Coverage is identical to before. Go tests are
around 5% faster while being 7% smaller. No non-test code is touched.

modules/git/attribute/batch_test.go

@@ -23,50 +23,31 @@ func Test_nulSeparatedAttributeWriter_ReadAttribute(t *testing.T) {
 
 	testStr := ".gitignore\"\n\x00linguist-vendored\x00unspecified\x00"
 
-	n, err := wr.Write([]byte(testStr))
-
-	assert.Len(t, testStr, n)
-	assert.NoError(t, err)
-	select {
-	case attr := <-wr.ReadAttribute():
-		assert.Equal(t, ".gitignore\"\n", attr.Filename)
-		assert.Equal(t, LinguistVendored, attr.Attribute)
-		assert.Equal(t, "unspecified", attr.Value)
-	case <-time.After(100 * time.Millisecond):
-		assert.FailNow(t, "took too long to read an attribute from the list")
-	}
-	// Write a second attribute again
-	n, err = wr.Write([]byte(testStr))
-
-	assert.Len(t, testStr, n)
-	assert.NoError(t, err)
-
-	select {
-	case attr := <-wr.ReadAttribute():
-		assert.Equal(t, ".gitignore\"\n", attr.Filename)
-		assert.Equal(t, LinguistVendored, attr.Attribute)
-		assert.Equal(t, "unspecified", attr.Value)
-	case <-time.After(100 * time.Millisecond):
-		assert.FailNow(t, "took too long to read an attribute from the list")
+	for range 2 {
+		n, err := wr.Write([]byte(testStr))
+		assert.Len(t, testStr, n)
+		assert.NoError(t, err)
+		select {
+		case attr := <-wr.ReadAttribute():
+			assert.Equal(t, ".gitignore\"\n", attr.Filename)
+			assert.Equal(t, LinguistVendored, attr.Attribute)
+			assert.Equal(t, "unspecified", attr.Value)
+		case <-time.After(100 * time.Millisecond):
+			assert.FailNow(t, "took too long to read an attribute from the list")
+		}
 	}
 
 	// Write a partial attribute
-	_, err = wr.Write([]byte("incomplete-file"))
+	_, err := wr.Write([]byte("incomplete-file"))
 	assert.NoError(t, err)
-	_, err = wr.Write([]byte("name\x00"))
-	assert.NoError(t, err)
-
-	select {
-	case <-wr.ReadAttribute():
-		assert.FailNow(t, "There should not be an attribute ready to read")
-	case <-time.After(100 * time.Millisecond):
-	}
-	_, err = wr.Write([]byte("attribute\x00"))
-	assert.NoError(t, err)
-	select {
-	case <-wr.ReadAttribute():
-		assert.FailNow(t, "There should not be an attribute ready to read")
-	case <-time.After(100 * time.Millisecond):
+	for _, part := range []string{"name\x00", "attribute\x00"} {
+		_, err = wr.Write([]byte(part))
+		assert.NoError(t, err)
+		select {
+		case <-wr.ReadAttribute():
+			assert.FailNow(t, "There should not be an attribute ready to read")
+		case <-time.After(100 * time.Millisecond):
+		}
 	}
 
 	_, err = wr.Write([]byte("value\x00"))
@@ -79,27 +60,15 @@ func Test_nulSeparatedAttributeWriter_ReadAttribute(t *testing.T) {
 
 	_, err = wr.Write([]byte("shouldbe.vendor\x00linguist-vendored\x00set\x00shouldbe.vendor\x00linguist-generated\x00unspecified\x00shouldbe.vendor\x00linguist-language\x00unspecified\x00"))
 	assert.NoError(t, err)
-	attr = <-wr.ReadAttribute()
-	assert.NoError(t, err)
-	assert.Equal(t, attributeTriple{
-		Filename:  "shouldbe.vendor",
-		Attribute: LinguistVendored,
-		Value:     "set",
-	}, attr)
-	attr = <-wr.ReadAttribute()
-	assert.NoError(t, err)
-	assert.Equal(t, attributeTriple{
-		Filename:  "shouldbe.vendor",
-		Attribute: LinguistGenerated,
-		Value:     "unspecified",
-	}, attr)
-	attr = <-wr.ReadAttribute()
-	assert.NoError(t, err)
-	assert.Equal(t, attributeTriple{
-		Filename:  "shouldbe.vendor",
-		Attribute: LinguistLanguage,
-		Value:     "unspecified",
-	}, attr)
+	for _, expected := range []attributeTriple{
+		{"shouldbe.vendor", LinguistVendored, "set"},
+		{"shouldbe.vendor", LinguistGenerated, "unspecified"},
+		{"shouldbe.vendor", LinguistLanguage, "unspecified"},
+	} {
+		attr = <-wr.ReadAttribute()
+		assert.NoError(t, err)
+		assert.Equal(t, expected, attr)
+	}
 }
 
 func expectedAttrs() *Attributes {