test: consolidate Go tests (#39962)

Consolidate all Go tests. Coverage is identical to before. Go tests are
around 5% faster while being 7% smaller. No non-test code is touched.

modules/validation/refname_test.go

@@ -8,249 +8,33 @@ import (
 )
 
 func Test_GitRefNameValidation(t *testing.T) {
-	gitRefNameValidationTestCases := []validationTestCase{
-		{
-			description: "Reference name contains only characters",
-			data: &TestForm{
-				BranchName: "test",
-			},
-		},
-		{
-			description: "Reference name contains single slash",
-			data: &TestForm{
-				BranchName: "feature/test",
-			},
-		},
-		{
-			description: "Reference name has allowed special characters",
-			data: &TestForm{
-				BranchName: "debian/1%1.6.0-2",
-			},
-		},
-		{
-			description: "Reference name contains backslash",
-			data: &TestForm{
-				BranchName: "feature\\test",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"BranchName"},
-					Classification: ErrGitRefName,
-					Message:        "GitRefName",
-				},
-			},
-		},
-		{
-			description: "Reference name starts with dot",
-			data: &TestForm{
-				BranchName: ".test",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"BranchName"},
-					Classification: ErrGitRefName,
-					Message:        "GitRefName",
-				},
-			},
-		},
-		{
-			description: "Reference name ends with dot",
-			data: &TestForm{
-				BranchName: "test.",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"BranchName"},
-					Classification: ErrGitRefName,
-					Message:        "GitRefName",
-				},
-			},
-		},
-		{
-			description: "Reference name starts with slash",
-			data: &TestForm{
-				BranchName: "/test",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"BranchName"},
-					Classification: ErrGitRefName,
-					Message:        "GitRefName",
-				},
-			},
-		},
-		{
-			description: "Reference name ends with slash",
-			data: &TestForm{
-				BranchName: "test/",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"BranchName"},
-					Classification: ErrGitRefName,
-					Message:        "GitRefName",
-				},
-			},
-		},
-		{
-			description: "Reference name ends with .lock",
-			data: &TestForm{
-				BranchName: "test.lock",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"BranchName"},
-					Classification: ErrGitRefName,
-					Message:        "GitRefName",
-				},
-			},
-		},
-		{
-			description: "Reference name contains multiple consecutive dots",
-			data: &TestForm{
-				BranchName: "te..st",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"BranchName"},
-					Classification: ErrGitRefName,
-					Message:        "GitRefName",
-				},
-			},
-		},
-		{
-			description: "Reference name contains multiple consecutive slashes",
-			data: &TestForm{
-				BranchName: "te//st",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"BranchName"},
-					Classification: ErrGitRefName,
-					Message:        "GitRefName",
-				},
-			},
-		},
-		{
-			description: "Reference name is single @",
-			data: &TestForm{
-				BranchName: "@",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"BranchName"},
-					Classification: ErrGitRefName,
-					Message:        "GitRefName",
-				},
-			},
-		},
-		{
-			description: "Reference name has @{",
-			data: &TestForm{
-				BranchName: "branch@{",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"BranchName"},
-					Classification: ErrGitRefName,
-					Message:        "GitRefName",
-				},
-			},
-		},
-		{
-			description: "Reference name has unallowed special character ~",
-			data: &TestForm{
-				BranchName: "~debian/1%1.6.0-2",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"BranchName"},
-					Classification: ErrGitRefName,
-					Message:        "GitRefName",
-				},
-			},
-		},
-		{
-			description: "Reference name has unallowed special character *",
-			data: &TestForm{
-				BranchName: "*debian/1%1.6.0-2",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"BranchName"},
-					Classification: ErrGitRefName,
-					Message:        "GitRefName",
-				},
-			},
-		},
-		{
-			description: "Reference name has unallowed special character ?",
-			data: &TestForm{
-				BranchName: "?debian/1%1.6.0-2",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"BranchName"},
-					Classification: ErrGitRefName,
-					Message:        "GitRefName",
-				},
-			},
-		},
-		{
-			description: "Reference name has unallowed special character ^",
-			data: &TestForm{
-				BranchName: "^debian/1%1.6.0-2",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"BranchName"},
-					Classification: ErrGitRefName,
-					Message:        "GitRefName",
-				},
-			},
-		},
-		{
-			description: "Reference name has unallowed special character :",
-			data: &TestForm{
-				BranchName: "debian:jessie",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"BranchName"},
-					Classification: ErrGitRefName,
-					Message:        "GitRefName",
-				},
-			},
-		},
-		{
-			description: "Reference name has unallowed special character (whitespace)",
-			data: &TestForm{
-				BranchName: "debian jessie",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"BranchName"},
-					Classification: ErrGitRefName,
-					Message:        "GitRefName",
-				},
-			},
-		},
-		{
-			description: "Reference name has unallowed special character [",
-			data: &TestForm{
-				BranchName: "debian[jessie",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"BranchName"},
-					Classification: ErrGitRefName,
-					Message:        "GitRefName",
-				},
-			},
-		},
-	}
-
-	for _, testCase := range gitRefNameValidationTestCases {
+	expectedErrors := BindingErrors{{
+		FieldNames:     []string{"BranchName"},
+		Classification: ErrGitRefName,
+		Message:        "GitRefName",
+	}}
+	for _, testCase := range []validationTestCase{
+		{"Reference name contains only characters", &TestForm{BranchName: "test"}, nil},
+		{"Reference name contains single slash", &TestForm{BranchName: "feature/test"}, nil},
+		{"Reference name has allowed special characters", &TestForm{BranchName: "debian/1%1.6.0-2"}, nil},
+		{"Reference name contains backslash", &TestForm{BranchName: "feature\\test"}, expectedErrors},
+		{"Reference name starts with dot", &TestForm{BranchName: ".test"}, expectedErrors},
+		{"Reference name ends with dot", &TestForm{BranchName: "test."}, expectedErrors},
+		{"Reference name starts with slash", &TestForm{BranchName: "/test"}, expectedErrors},
+		{"Reference name ends with slash", &TestForm{BranchName: "test/"}, expectedErrors},
+		{"Reference name ends with .lock", &TestForm{BranchName: "test.lock"}, expectedErrors},
+		{"Reference name contains multiple consecutive dots", &TestForm{BranchName: "te..st"}, expectedErrors},
+		{"Reference name contains multiple consecutive slashes", &TestForm{BranchName: "te//st"}, expectedErrors},
+		{"Reference name is single @", &TestForm{BranchName: "@"}, expectedErrors},
+		{"Reference name has @{", &TestForm{BranchName: "branch@{"}, expectedErrors},
+		{"Reference name has unallowed special character ~", &TestForm{BranchName: "~debian/1%1.6.0-2"}, expectedErrors},
+		{"Reference name has unallowed special character *", &TestForm{BranchName: "*debian/1%1.6.0-2"}, expectedErrors},
+		{"Reference name has unallowed special character ?", &TestForm{BranchName: "?debian/1%1.6.0-2"}, expectedErrors},
+		{"Reference name has unallowed special character ^", &TestForm{BranchName: "^debian/1%1.6.0-2"}, expectedErrors},
+		{"Reference name has unallowed special character :", &TestForm{BranchName: "debian:jessie"}, expectedErrors},
+		{"Reference name has unallowed special character (whitespace)", &TestForm{BranchName: "debian jessie"}, expectedErrors},
+		{"Reference name has unallowed special character [", &TestForm{BranchName: "debian[jessie"}, expectedErrors},
+	} {
 		t.Run(testCase.description, func(t *testing.T) {
 			performValidationTest(t, testCase)
 		})

modules/validation/validurl_test.go

@@ -8,92 +8,22 @@ import (
 )
 
 func Test_ValidURLValidation(t *testing.T) {
-	urlValidationTestCases := []validationTestCase{
-		{
-			description: "Empty URL",
-			data: &TestForm{
-				URL: "",
-			},
-		},
-		{
-			description: "URL without port",
-			data: &TestForm{
-				URL: "http://test.lan/",
-			},
-		},
-		{
-			description: "URL with port",
-			data: &TestForm{
-				URL: "http://test.lan:3000/",
-			},
-		},
-		{
-			description: "URL with IPv6 address without port",
-			data: &TestForm{
-				URL: "http://[::1]/",
-			},
-		},
-		{
-			description: "URL with IPv6 address with port",
-			data: &TestForm{
-				URL: "http://[::1]:3000/",
-			},
-		},
-		{
-			description: "Invalid URL",
-			data: &TestForm{
-				URL: "http//test.lan/",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"URL"},
-					Classification: "UrlError",
-					Message:        "Url",
-				},
-			},
-		},
-		{
-			description: "Invalid schema",
-			data: &TestForm{
-				URL: "ftp://test.lan/",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"URL"},
-					Classification: "UrlError",
-					Message:        "Url",
-				},
-			},
-		},
-		{
-			description: "Invalid port",
-			data: &TestForm{
-				URL: "http://test.lan:3x4/",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"URL"},
-					Classification: "UrlError",
-					Message:        "Url",
-				},
-			},
-		},
-		{
-			description: "Invalid port with IPv6 address",
-			data: &TestForm{
-				URL: "http://[::1]:3x4/",
-			},
-			expectedErrors: BindingErrors{
-				BindingError{
-					FieldNames:     []string{"URL"},
-					Classification: "UrlError",
-					Message:        "Url",
-				},
-			},
-		},
-	}
-
-	for _, testCase := range urlValidationTestCases {
+	expectedErrors := BindingErrors{{
+		FieldNames:     []string{"URL"},
+		Classification: "UrlError",
+		Message:        "Url",
+	}}
+	for _, testCase := range []validationTestCase{
+		{"Empty URL", &TestForm{URL: ""}, nil},
+		{"URL without port", &TestForm{URL: "http://test.lan/"}, nil},
+		{"URL with port", &TestForm{URL: "http://test.lan:3000/"}, nil},
+		{"URL with IPv6 address without port", &TestForm{URL: "http://[::1]/"}, nil},
+		{"URL with IPv6 address with port", &TestForm{URL: "http://[::1]:3000/"}, nil},
+		{"Invalid URL", &TestForm{URL: "http//test.lan/"}, expectedErrors},
+		{"Invalid schema", &TestForm{URL: "ftp://test.lan/"}, expectedErrors},
+		{"Invalid port", &TestForm{URL: "http://test.lan:3x4/"}, expectedErrors},
+		{"Invalid port with IPv6 address", &TestForm{URL: "http://[::1]:3x4/"}, expectedErrors},
+	} {
 		t.Run(testCase.description, func(t *testing.T) {
 			performValidationTest(t, testCase)
 		})