test: consolidate Go tests (#39962)

Consolidate all Go tests. Coverage is identical to before. Go tests are
around 5% faster while being 7% smaller. No non-test code is touched.

tests/integration/api_admin_org_test.go

@@ -22,64 +22,48 @@ func TestAPIAdminOrgCreate(t *testing.T) {
 	session := loginUser(t, "user1")
 	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteAdmin)
 
-	t.Run("CreateOrg", func(t *testing.T) {
-		defer tests.PrintCurrentTest(t)()
-		org := api.CreateOrgOption{
-			UserName:    "user2_org",
-			FullName:    "User2's organization",
-			Description: "This organization created by admin for user2",
-			Website:     "https://try.gitea.io",
-			Location:    "Shanghai",
-			Visibility:  "private",
-		}
-		req := NewRequestWithJSON(t, "POST", "/api/v1/admin/users/user2/orgs", &org).
-			AddTokenAuth(token)
-		resp := MakeRequest(t, req, http.StatusCreated)
+	for _, testCase := range []struct {
+		name       string
+		visibility api.VisibilityString
+		status     int
+	}{
+		{"CreateOrg", "private", http.StatusCreated},
+		{"CreateBadVisibility", "notvalid", http.StatusUnprocessableEntity},
+		{"CreateNotAdmin", "public", http.StatusForbidden},
+	} {
+		t.Run(testCase.name, func(t *testing.T) {
+			defer tests.PrintCurrentTest(t)()
+			testToken := token
+			if testCase.status == http.StatusForbidden {
+				session := loginUser(t, "user2")
+				testToken = getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeAll)
+			}
+			org := api.CreateOrgOption{
+				UserName:    "user2_org",
+				FullName:    "User2's organization",
+				Description: "This organization created by admin for user2",
+				Website:     "https://try.gitea.io",
+				Location:    "Shanghai",
+				Visibility:  testCase.visibility,
+			}
+			req := NewRequestWithJSON(t, "POST", "/api/v1/admin/users/user2/orgs", &org).
+				AddTokenAuth(testToken)
+			resp := MakeRequest(t, req, testCase.status)
+			if testCase.status == http.StatusCreated {
+				apiOrg := DecodeJSON(t, resp, &api.Organization{})
+				assert.Equal(t, org.UserName, apiOrg.Name)
+				assert.Equal(t, org.FullName, apiOrg.FullName)
+				assert.Equal(t, org.Description, apiOrg.Description)
+				assert.Equal(t, org.Website, apiOrg.Website)
+				assert.Equal(t, org.Location, apiOrg.Location)
+				assert.Equal(t, org.Visibility, apiOrg.Visibility)
 
-		apiOrg := DecodeJSON(t, resp, &api.Organization{})
-
-		assert.Equal(t, org.UserName, apiOrg.Name)
-		assert.Equal(t, org.FullName, apiOrg.FullName)
-		assert.Equal(t, org.Description, apiOrg.Description)
-		assert.Equal(t, org.Website, apiOrg.Website)
-		assert.Equal(t, org.Location, apiOrg.Location)
-		assert.Equal(t, org.Visibility, apiOrg.Visibility)
-
-		unittest.AssertExistsAndLoadBean(t, &user_model.User{
-			Name:      org.UserName,
-			LowerName: strings.ToLower(org.UserName),
-			FullName:  org.FullName,
+				unittest.AssertExistsAndLoadBean(t, &user_model.User{
+					Name:      org.UserName,
+					LowerName: strings.ToLower(org.UserName),
+					FullName:  org.FullName,
+				})
+			}
 		})
-	})
-	t.Run("CreateBadVisibility", func(t *testing.T) {
-		defer tests.PrintCurrentTest(t)()
-		org := api.CreateOrgOption{
-			UserName:    "user2_org",
-			FullName:    "User2's organization",
-			Description: "This organization created by admin for user2",
-			Website:     "https://try.gitea.io",
-			Location:    "Shanghai",
-			Visibility:  "notvalid",
-		}
-		req := NewRequestWithJSON(t, "POST", "/api/v1/admin/users/user2/orgs", &org).
-			AddTokenAuth(token)
-		MakeRequest(t, req, http.StatusUnprocessableEntity)
-	})
-	t.Run("CreateNotAdmin", func(t *testing.T) {
-		defer tests.PrintCurrentTest(t)()
-		nonAdminUsername := "user2"
-		session := loginUser(t, nonAdminUsername)
-		token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeAll)
-		org := api.CreateOrgOption{
-			UserName:    "user2_org",
-			FullName:    "User2's organization",
-			Description: "This organization created by admin for user2",
-			Website:     "https://try.gitea.io",
-			Location:    "Shanghai",
-			Visibility:  "public",
-		}
-		req := NewRequestWithJSON(t, "POST", "/api/v1/admin/users/user2/orgs", &org).
-			AddTokenAuth(token)
-		MakeRequest(t, req, http.StatusForbidden)
-	})
+	}
 }