public/gitea
1
0 Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-11-02 13:44:16 +09:00
Code Issues Packages Projects Releases Wiki Activity

test: consolidate Go tests (#39962)

Browse Source 
Consolidate all Go tests. Coverage is identical to before. Go tests are
around 5% faster while being 7% smaller. No non-test code is touched.
This commit is contained in:
silverwind authored and GitHub committed 2026-10-24 13:48:19 +00:00
1 parent ce7364e215
commit 8abda62312
388 files changed
+18410 -29561
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/integration/api_private_serv_test.go
+50 -62
View File
@@ -44,44 +44,38 @@ func TestAPIPrivateServ(t *testing.T) {
ctx, cancel := context.WithCancel(t.Context())
defer cancel()
// Can push to a repo we own
results, extra := private.ServCommand(ctx, 1, "user2", "repo1", perm.AccessModeWrite, "git-upload-pack", "")
assert.NoError(t, extra.Error)
assert.False(t, results.IsWiki)
assert.Empty(t, results.UserExtDoerData)
assert.Equal(t, int64(1), results.PublicKeyID)
assert.Equal(t, "user2", results.UserName)
assert.Equal(t, int64(2), results.UserID)
assert.Equal(t, "user2", results.OwnerName)
assert.Equal(t, "repo1", results.RepoName)
assert.Equal(t, int64(1), results.RepoID)
// Cannot push to a private repo we're not associated with
results, extra = private.ServCommand(ctx, 1, "user15", "big_test_private_1", perm.AccessModeWrite, "git-upload-pack", "")
assert.Error(t, extra.Error)
assert.Empty(t, results)
// Cannot pull from a private repo we're not associated with
results, extra = private.ServCommand(ctx, 1, "user15", "big_test_private_1", perm.AccessModeRead, "git-upload-pack", "")
assert.Error(t, extra.Error)
assert.Empty(t, results)
// Can pull from a public repo we're not associated with
results, extra = private.ServCommand(ctx, 1, "user15", "big_test_public_1", perm.AccessModeRead, "git-upload-pack", "")
assert.NoError(t, extra.Error)
assert.False(t, results.IsWiki)
assert.Empty(t, results.UserExtDoerData)
assert.Equal(t, int64(1), results.PublicKeyID)
assert.Equal(t, "user2", results.UserName)
assert.Equal(t, int64(2), results.UserID)
assert.Equal(t, "user15", results.OwnerName)
assert.Equal(t, "big_test_public_1", results.RepoName)
assert.Equal(t, int64(17), results.RepoID)
// Cannot push to a public repo we're not associated with
results, extra = private.ServCommand(ctx, 1, "user15", "big_test_public_1", perm.AccessModeWrite, "git-upload-pack", "")
assert.Error(t, extra.Error)
assert.Empty(t, results)
for _, testCase := range []struct {
ownerName, repoName string
mode perm.AccessMode
repoID int64
}{
// Can push to a repo we own
{"user2", "repo1", perm.AccessModeWrite, 1},
// Cannot push to a private repo we're not associated with
{"user15", "big_test_private_1", perm.AccessModeWrite, 0},
// Cannot pull from a private repo we're not associated with
{"user15", "big_test_private_1", perm.AccessModeRead, 0},
// Can pull from a public repo we're not associated with
{"user15", "big_test_public_1", perm.AccessModeRead, 17},
// Cannot push to a public repo we're not associated with
{"user15", "big_test_public_1", perm.AccessModeWrite, 0},
} {
results, extra := private.ServCommand(ctx, 1, testCase.ownerName, testCase.repoName, testCase.mode, "git-upload-pack", "")
if testCase.repoID == 0 {
assert.Error(t, extra.Error)
assert.Empty(t, results)
} else {
assert.NoError(t, extra.Error)
assert.False(t, results.IsWiki)
assert.Empty(t, results.UserExtDoerData)
assert.Equal(t, int64(1), results.PublicKeyID)
assert.Equal(t, "user2", results.UserName)
assert.Equal(t, int64(2), results.UserID)
assert.Equal(t, testCase.ownerName, results.OwnerName)
assert.Equal(t, testCase.repoName, results.RepoName)
assert.Equal(t, testCase.repoID, results.RepoID)
}
}
// Add reading deploy key
testContent := "sk-ecdsa-sha2-nistp256@openssh.com AAAAInNrLWVjZHNhLXNoYTItbmlzdHAyNTZAb3BlbnNzaC5jb20AAAAIbmlzdHAyNTYAAABBBGXEEzWmm1dxb+57RoK5KVCL0w2eNv9cqJX2AGGVlkFsVDhOXHzsadS3LTK4VlEbbrDMJdoti9yM8vclA8IeRacAAAAEc3NoOg== nocomment"
@@ -90,7 +84,7 @@ func TestAPIPrivateServ(t *testing.T) {
// Can pull from repo we're a deploy-key for
deployKeyUser := user.NewDeployKeyUser()
results, extra = private.ServCommand(ctx, deployKey.KeyID, "user15", "big_test_private_1", perm.AccessModeRead, "git-upload-pack", "")
results, extra := private.ServCommand(ctx, deployKey.KeyID, "user15", "big_test_private_1", perm.AccessModeRead, "git-upload-pack", "")
assert.NoError(t, extra.Error)
assert.False(t, results.IsWiki)
assert.NotEmpty(t, results.UserExtDoerData)
@@ -126,28 +120,22 @@ func TestAPIPrivateServ(t *testing.T) {
assert.Error(t, extra.Error)
assert.Empty(t, results)
// Can pull from repo we're a writing deploy key for
results, extra = private.ServCommand(ctx, deployKey.KeyID, "user15", "big_test_private_2", perm.AccessModeRead, "git-upload-pack", "")
assert.NoError(t, extra.Error)
assert.False(t, results.IsWiki)
assert.NotEmpty(t, results.UserExtDoerData)
assert.Equal(t, deployKey.KeyID, results.PublicKeyID)
assert.Equal(t, deployKeyUser.Name, results.UserName)
assert.Equal(t, deployKeyUser.ID, results.UserID)
assert.Equal(t, "user15", results.OwnerName)
assert.Equal(t, "big_test_private_2", results.RepoName)
assert.Equal(t, int64(20), results.RepoID)
// Can push to repo we're a writing deploy key for
results, extra = private.ServCommand(ctx, deployKey.KeyID, "user15", "big_test_private_2", perm.AccessModeWrite, "git-upload-pack", "")
assert.NoError(t, extra.Error)
assert.False(t, results.IsWiki)
assert.NotEmpty(t, results.UserExtDoerData)
assert.Equal(t, deployKey.KeyID, results.PublicKeyID)
assert.Equal(t, deployKeyUser.Name, results.UserName)
assert.Equal(t, deployKeyUser.ID, results.UserID)
assert.Equal(t, "user15", results.OwnerName)
assert.Equal(t, "big_test_private_2", results.RepoName)
assert.Equal(t, int64(20), results.RepoID)
for _, mode := range []perm.AccessMode{
// Can pull from repo we're a writing deploy key for
perm.AccessModeRead,
// Can push to repo we're a writing deploy key for
perm.AccessModeWrite,
} {
results, extra = private.ServCommand(ctx, deployKey.KeyID, "user15", "big_test_private_2", mode, "git-upload-pack", "")
assert.NoError(t, extra.Error)
assert.False(t, results.IsWiki)
assert.NotEmpty(t, results.UserExtDoerData)
assert.Equal(t, deployKey.KeyID, results.PublicKeyID)
assert.Equal(t, deployKeyUser.Name, results.UserName)
assert.Equal(t, deployKeyUser.ID, results.UserID)
assert.Equal(t, "user15", results.OwnerName)
assert.Equal(t, "big_test_private_2", results.RepoName)
assert.Equal(t, int64(20), results.RepoID)
}
})
}