public/gitea
1
0 Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-10-18 22:36:43 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix get reviewers' bug (#32415) (#32616)

Browse Source 
This PR rewrites `GetReviewer` function and move it to service layer.

Reviewers should not be watchers, so that this PR removed all watchers
from reviewers. When the repository is under an organization, the pull
request unit read permission will be checked to resolve the bug of

Fix #32394
Backport #32415
This commit is contained in:
Lunny Xiao authored and GitHub committed 2024-11-23 12:42:58 +08:00
1 parent 073ba977fc
commit cf1a38b03d
12 files changed
+227 -158
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/integration/api_repo_test.go
+2 -2
View File
@@ -718,8 +718,8 @@ func TestAPIRepoGetReviewers(t *testing.T) {
resp := MakeRequest(t, req, http.StatusOK)
var reviewers []*api.User
DecodeJSON(t, resp, &reviewers)
if assert.Len(t, reviewers, 3) {
assert.ElementsMatch(t, []int64{1, 4, 11}, []int64{reviewers[0].ID, reviewers[1].ID, reviewers[2].ID})
if assert.Len(t, reviewers, 1) {
assert.ElementsMatch(t, []int64{2}, []int64{reviewers[0].ID})
}
}