refactor!: move go-chi/session into Gitea (#39504)

The `gitea.com/go-chi/session` package only exists for Gitea, so it
moves into `modules/session` to fix its bugs directly. Fixes the flake
in
https://github.com/go-gitea/gitea/actions/runs/36726154500/job/109923538400.

- Sessions are only written back when changed, so a read-only request
can't revert a concurrent change or restore a logged-out session, like
https://github.com/go-macaron/session/commit/ae808a4a4660c802965c834299ab08f167effd12
- The session cookie is only set once a session holds data
- Every backend refreshes the expiry on load and file sessions are
written atomically
- Also fix  https://github.com/go-gitea/gitea/issues/36176

## ⚠️ BREAKING ⚠️

* the `mysql`, `postgres`, `couchbase` and `memcache` session providers
are removed, use `file`, `db` or `redis` instead
* login-related cookies are renamed to `gitea_session` and
`gitea_remember`, if you'd like to use the old names, set `COOKIE_NAME`
and `COOKIE_REMEMBER_NAME` in app.ini

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
silverwindandwxiaoguang authored and GitHub committed 2026-10-02 21:08:14 +02:00
1 parent bea6fcaa84
commit cf89ecd887
34 files changed
+913 -981

No files matched your search

+18 -19
View File
@@ -5,32 +5,31 @@ package integration
import (
"testing"
"time"
"gitea.dev/models/auth"
"gitea.dev/models/unittest"
"gitea.dev/modules/timeutil"
"gitea.dev/tests"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func Test_RegenerateSession(t *testing.T) {
defer tests.PrepareTestEnv(t)()
func TestUpdateSession(t *testing.T) {
defer tests.PrintCurrentTest(t)()
defer timeutil.MockSet(time.Now())()
key := "0123456789abcdef"
for _, create := range []bool{true, true, false} {
require.NoError(t, auth.UpdateSession(t.Context(), key, []byte("data"), create))
}
sess, exist, err := auth.GetSession(t.Context(), key)
require.NoError(t, err)
require.True(t, exist)
assert.Equal(t, []byte("data"), sess.Data)
assert.NoError(t, unittest.PrepareTestDatabase())
key := "new_key890123456" // it must be 16 characters long
key2 := "new_key890123457" // it must be 16 characters
exist, err := auth.ExistSession(t.Context(), key)
assert.NoError(t, err)
require.NoError(t, auth.DestroySession(t.Context(), key))
require.NoError(t, auth.UpdateSession(t.Context(), key, []byte("data"), false))
_, exist, err = auth.GetSession(t.Context(), key)
require.NoError(t, err)
assert.False(t, exist)
sess, err := auth.RegenerateSession(t.Context(), "", key)
assert.NoError(t, err)
assert.Equal(t, key, sess.Key)
assert.Empty(t, sess.Data)
sess, err = auth.ReadSession(t.Context(), key2)
assert.NoError(t, err)
assert.Equal(t, key2, sess.Key)
assert.Empty(t, sess.Data)
}