mirror of
https://github.com/go-gitea/gitea.git
synced 2026-10-26 06:16:56 +09:00
feat: add release reactions and a GitHub-like reaction bar (#38415)
Adds emoji reactions to releases and moves the reaction picker of issues, comments and releases into a GitHub-like reaction bar. - Releases omit 👎 or 😕 - Drafts and tags can't be reacted to - Moved menu to tippy - Added keyboard navigation Fixes: https://github.com/go-gitea/gitea/issues/34268 Fixes: https://github.com/go-gitea/gitea/issues/16676 Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
42 files changed
+508
-313
No files matched your search
@@ -12,15 +12,20 @@ test('toggle issue reactions', async ({page, request}) => {
|
||||
]);
|
||||
await page.goto(`/${owner}/${repoName}/issues/1`);
|
||||
|
||||
const issueComment = page.locator('.timeline-item.comment.issue-content-comment');
|
||||
const reactions = page.locator('.timeline-item.comment.issue-content-comment').getByRole('group', {name: 'Reactions'});
|
||||
const reactionPicker = reactions.getByRole('button', {name: 'Reactions', exact: true});
|
||||
|
||||
const reactionPicker = issueComment.locator('.select-reaction');
|
||||
await reactionPicker.click();
|
||||
await reactionPicker.getByLabel('+1').click();
|
||||
|
||||
const reactions = issueComment.getByRole('group', {name: 'Reactions'});
|
||||
await page.getByRole('menuitem', {name: '+1', exact: true}).click();
|
||||
await expect(reactions.getByRole('button', {name: /^\+1:/})).toContainText('1');
|
||||
|
||||
await reactions.getByRole('button', {name: /^\+1:/}).click();
|
||||
await expect(reactions.getByRole('button', {name: /^\+1:/})).toHaveCount(0);
|
||||
|
||||
await reactionPicker.press('Enter');
|
||||
await page.keyboard.press('ArrowRight');
|
||||
await page.keyboard.press('ArrowRight');
|
||||
await page.keyboard.press('Enter');
|
||||
await expect(reactions.getByRole('button', {name: /^-1:/})).toContainText('1');
|
||||
await expect(reactionPicker).toBeFocused();
|
||||
});
|
||||
@@ -8,6 +8,7 @@ import (
|
||||
"net/http"
|
||||
"testing"
|
||||
|
||||
issues_model "gitea.dev/models/issues"
|
||||
repo_model "gitea.dev/models/repo"
|
||||
"gitea.dev/models/unittest"
|
||||
user_model "gitea.dev/models/user"
|
||||
@@ -280,3 +281,29 @@ func TestEditReleaseAttachmentRejectsForbiddenRename(t *testing.T) {
|
||||
attachment = unittest.AssertExistsAndLoadBean(t, &repo_model.Attachment{ID: attachment.ID})
|
||||
assert.NotEqual(t, "evil.exe", attachment.Name)
|
||||
}
|
||||
|
||||
func TestReleaseReaction(t *testing.T) {
|
||||
defer tests.PrepareTestEnv(t)()
|
||||
session := loginUser(t, "user2")
|
||||
reactReq := func(releaseID int64, action, content string) *RequestWrapper {
|
||||
return NewRequestWithValues(t, "POST", fmt.Sprintf("/user2/repo1/releases/%d/reactions/%s", releaseID, action), map[string]string{"content": content})
|
||||
}
|
||||
|
||||
session.MakeRequest(t, reactReq(1, "react", "-1"), http.StatusForbidden)
|
||||
|
||||
session.MakeRequest(t, reactReq(1, "react", "heart"), http.StatusOK)
|
||||
session.MakeRequest(t, reactReq(1, "react", "heart"), http.StatusOK)
|
||||
unittest.AssertCount(t, &issues_model.Reaction{ReleaseID: 1}, 1)
|
||||
|
||||
resp := session.MakeRequest(t, NewRequest(t, "GET", "/user2/repo1/releases"), http.StatusOK)
|
||||
htmlDoc := NewHTMLParser(t, resp.Body)
|
||||
AssertHTMLElement(t, htmlDoc, `.bottom-reactions a.ui.label[data-reaction-content="heart"]`, 1)
|
||||
AssertHTMLElement(t, htmlDoc, `.reaction-picker [data-reaction-content="-1"]`, 0)
|
||||
|
||||
session.MakeRequest(t, reactReq(1, "unreact", "heart"), http.StatusOK)
|
||||
unittest.AssertCount(t, &issues_model.Reaction{ReleaseID: 1}, 0)
|
||||
|
||||
for _, releaseID := range []int64{2, 3, 4} {
|
||||
session.MakeRequest(t, reactReq(releaseID, "react", "heart"), http.StatusNotFound)
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user