95b69a4a2d
fix(queue): bump levelqueue to v0.5.1 and remove workarounds ( #40219 ) ( #40350 )
...
Backport https://github.com/go-gitea/gitea/pull/40219
levelqueue v0.5.1 fixes this upstream
(https://gitea.com/lunny/levelqueue/pulls/8 ), so this now only bumps the
dependency.
A push wrote "high" before the payload, so an interrupted push left an
id counted with no key. `LPop` then returned `ErrNotFound` without
advancing "low" and the wrapper retried forever: nothing popped, no
worker started, later items unreachable. All were only fixable by
clearing the queue, losing the backlog:
- https://github.com/go-gitea/gitea/issues/32006 — mail, 0 workers
- https://github.com/go-gitea/gitea/issues/28919 — mirror, "already in
queue"
- https://github.com/go-gitea/gitea/issues/33862 — archives hanging
- https://github.com/go-gitea/gitea/issues/33882 — self-healing request
v0.5.1 writes counter and payload in one batch, moves the counters past
missing keys, and repairs leftover unique-queue set entries, so affected
instances recover on their next pop.
No test: the behaviour lives in the dependency, which covers it in its
own `recover_test.go`.
Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: William Desportes <williamdes@wdes.fr >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-11-13 17:12:25 +00:00
wxiaoguang
84c8ab9fd1
Help to recover from corrupted levelqueue ( #24912 )
...
gitea.com experienced the corrupted LevelQueue bug again.
I think the problem is clear now: if the keys in LevelDB went
out-of-sync, the LevelQueue itself doesn't have the ability to recover,
eg:
* LevelQueue.Len() reports 100
* LevelQueue.LPop() reports ErrNotFound = errors.New("no key found")
So it needs to dive into the LevelDB to remove all keys to recover the
corrupted LevelQueue.
More comments are in TestCorruptedLevelQueue.
2023-05-29 10:52:32 +08:00