0ab612f5ab
Refactor storage content-type handling of ServeDirectURL ( #36804 )
...
* replace raw url.Values by *storage.ServeDirectOptions
* implement content-type in azblob
* implement content-disposition in azblob
* add tests for content types in response
* http.MethodPut for azure now allows implementing servedirect uploads
---------
Signed-off-by: ChristopherHX <christopher.homberger@web.de >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2026-03-21 21:26:13 -07:00
1c8c56503f
Allow to display embed images/pdfs when SERVE_DIRECT was enabled on MinIO storage ( #35882 )
...
Releated issue: https://github.com/go-gitea/gitea/issues/30487
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-11-09 21:31:25 -08:00
e1e4815a1c
Redirect to a presigned URL of HEAD for HEAD requests ( #35088 )
...
Resolves https://github.com/go-gitea/gitea/issues/35086 .
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-07-16 11:22:45 +00:00
abaeae0b9c
Fix Azure blob object Seek ( #32974 )
...
This bug was found in a
[test](https://github.com/go-gitea/gitea/actions/runs/12464294025/job/34788152194?pr=32883#step:9:105 )
of #32883
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-12-25 04:54:52 +00:00
0690cb076b
Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled ( #32365 )
...
Fix #28121
I did some tests and found that the `missing signature key` error is
caused by an incorrect `Content-Type` header. Gitea correctly sets the
`Content-Type` header when serving files.
https://github.com/go-gitea/gitea/blob/348d1d0f322ca57c459acd902f54821d687ca804/routers/api/packages/container/container.go#L712-L717
However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may
be set to an incorrect value by the storage service. To fix this issue,
we can use query parameters to override response header values.
https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html
<img width="600px"
src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555 "
/>
In this PR, I introduced a new parameter to the `URL` method to support
additional parameters.
```
URL(path, name string, reqParams url.Values) (*url.URL, error)
```
---
Most S3-like services support specifying the content type when storing
objects. However, Gitea always use `application/octet-stream`.
Therefore, I believe we also need to improve the `Save` method to
support storing objects with the correct content type.
https://github.com/go-gitea/gitea/blob/b7fb20e73e63b8edc9b90c52073e248bef428fcc/modules/storage/minio.go#L214-L221
2024-10-31 15:28:25 +00:00
d9a7748cdc
bump to go 1.23 ( #31855 )
2024-09-10 02:23:07 +00:00
fc2d75f86d
Enable unparam linter ( #31277 )
...
Enable [unparam](https://github.com/mvdan/unparam ) linter.
Often I could not tell the intention why param is unused, so I put
`//nolint` for those cases like webhook request creation functions never
using `ctx`.
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: delvh <dev.lh@web.de >
2024-06-11 18:47:45 +00:00
fb7b743bd0
Azure blob storage support ( #30995 )
...
This PR implemented object storages(LFS/Packages/Attachments and etc.)
for Azure Blob Storage. It depends on azure official golang SDK and can
support both the azure blob storage cloud service and azurite mock
server.
Replace #25458
Fix #22527
- [x] CI Tests
- [x] integration test, MSSQL integration tests will now based on
azureblob
- [x] unit test
- [x] CLI Migrate Storage
- [x] Documentation for configuration added
------
TODO (other PRs):
- [ ] Improve performance of `blob download`.
---------
Co-authored-by: yp05327 <576951401@qq.com >
2024-05-30 07:33:50 +00:00
ChristopherHX
lifegpc
Risu
Zettat123
techknowlogick
silverwind
Lunny Xiao