public/gitea
1
0 Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-10-16 12:05:30 +09:00
Code Issues Packages Projects Releases Wiki Activity
21,752 Commits 24 Branches 262 Tags
8a9e8c4e8ce3d535e98ea775fdf994b66ce5dd40
Commit Graph
16 Commits
Author SHA1 Message Date
bircniwxiaoguangZettat123
 		321d3ec104 refactor(actions): pass secret and variable scope as a struct (#39719) 
Secret and variable functions took an adjacent `ownerID, repoID int64`
pair, so swapping the two compiled and only failed at runtime. They now
take a `BelongingScope` value instead.

`BelongingScope` also replaces the "drop OwnerID when RepoID is set"
step that `InsertEncryptedSecret` and `InsertVariable` each implemented
separately

No behaviour change. It also makes adding another scope dimension, such
as the environment ID in https://github.com/go-gitea/gitea/pull/38149, a
one-field change.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Zettat123 <zettat123@gmail.com>
 2026-10-10 18:21:28 +00:00
bircnibircniwxiaoguang
 		da37b7916b feat: Add audit logging (#38189) 
Co-authored-by: bircni <bircni@users.noreply.github.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 2026-09-12 08:15:23 +00:00
Ross Golderandwxiaoguang 2d3ad4a530 enhance: Improve validation errors for secrets/variables (#39221) 
Signed-off-by: Ross Golder <ross@golder.org>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 2026-09-04 00:28:58 +00:00
silverwindandwxiaoguang 76a81b24f9 chore: enable forcetypeassert linter, fix issues (#38804) 
Enable [`forcetypeassert`](https://github.com/gostaticanalysis/forcetypeassert)
linter to prevent unchecked type assertions. ~650 issues fixed, most
fixes were clean, some use `setting.PanicInDevOrTesting`.

The only behaviour changes are where code would previously send a 500 error
or panic, a 4xx error is now emitted.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 2026-08-09 10:25:06 +00:00
Lunny Xiao 61b1a39efe chore: Move import path from code.gitea.io/gitea to gitea.dev (#37873) 2026-05-26 15:49:31 -07:00
wxiaoguang 1af16679c3 Fix repo init README EOL (#37388) 
Fix #27120

By the way, refactor ReserveLineBreakForTextarea to NormalizeStringEOL
 2026-04-23 18:33:16 +00:00
NorthRealmandwxiaoguang 4c611bf280 Add a button editing action secret (#34348) 
Add a button editing action secret
Closes #34190

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 2025-05-08 17:11:43 +00:00
John Smithandwxiaoguang 8f051d598c Added Description Field for Secrets and Variables (#33526) 
Fixes #33484

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 2025-03-17 19:24:54 +00:00
sillyguodongandsilverwind 62b073e6f3 Add API for Variables (#29520) 
close #27801

---------

Co-authored-by: silverwind <me@silverwind.io>
 2024-03-28 20:40:35 +00:00
Lunny Xiao 29f149bd9f Move context from modules to services (#29440) 
Since `modules/context` has to depend on `models` and many other
packages, it should be moved from `modules/context` to
`services/context` according to design principles. There is no logic
code change on this PR, only move packages.

- Move `code.gitea.io/gitea/modules/context` to
`code.gitea.io/gitea/services/context`
- Move `code.gitea.io/gitea/modules/contexttest` to
`code.gitea.io/gitea/services/contexttest` because of depending on
context
- Move `code.gitea.io/gitea/modules/upload` to
`code.gitea.io/gitea/services/context/upload` because of depending on
context
 2024-02-27 08:12:22 +01:00
Lunny Xiao df1e7d0067 Use db.Find instead of writing methods for every object (#28084) 
For those simple objects, it's unnecessary to write the find and count
methods again and again.
 2023-11-24 03:49:41 +00:00
KN4CK3R a99b96cbcd Refactor secrets modification logic (#26873) 
- Share code between web and api
- Add some tests
 2023-09-05 15:21:02 +00:00
sillyguodongsilverwindwxiaoguangGiteabot
 		35a653d7ed Support configuration variables on Gitea Actions (#24724) 
Co-Author: @silverwind @wxiaoguang 
Replace: #24404

See:
- [defining configuration variables for multiple
workflows](https://docs.github.com/en/actions/learn-github-actions/variables#defining-configuration-variables-for-multiple-workflows)
- [vars
context](https://docs.github.com/en/actions/learn-github-actions/contexts#vars-context)

Related to:
- [x] protocol: https://gitea.com/gitea/actions-proto-def/pulls/7
- [x] act_runner: https://gitea.com/gitea/act_runner/pulls/157
- [x] act: https://gitea.com/gitea/act/pulls/43

#### Screenshoot
Create Variable:

![image](https://user-images.githubusercontent.com/33891828/236758288-032b7f64-44e7-48ea-b07d-de8b8b0e3729.png)


![image](https://user-images.githubusercontent.com/33891828/236758174-5203f64c-1d0e-4737-a5b0-62061dee86f8.png)

Workflow:
```yaml
  test_vars:
    runs-on: ubuntu-latest
    steps:
      - name: Print Custom Variables
        run: echo "${{ vars.test_key }}"
      - name: Try to print a non-exist var
        run: echo "${{ vars.NON_EXIST_VAR }}"
```

Actions Log:

![image](https://user-images.githubusercontent.com/33891828/236759075-af0c5950-368d-4758-a8ac-47a96e43b6e2.png)

---
This PR just implement the org / user (depends on the owner of the
current repository) and repo level variables, The Environment level
variables have not been implemented.
Because
[Environment](https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment#about-environments)
is a module separate from `Actions`. Maybe it would be better to create
a new PR to do it.

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>
 2023-06-20 22:54:15 +00:00
Jason Song d81659d039 Respect original content when creating secrets (#24745) 
Fix #24721.

Follow what GitHub does:
- Don't trim spaces for secrets.
- Newline should be `\n` instead of `\r\n`.

Did some tests with:

```yaml
name: secrets
on: push
jobs:
  show_secrets:
    runs-on: ubuntu-latest
    steps:
      - name: Dump secrets context
        run: echo '${{ toJSON(secrets) }}' | base64
```

`AAAAAA`:
```text
   AAAAAA
AAAAAA


```
`BBBBBB`:
```text



BBBBBB
BBBBBB   
```


On GitHub:

<img width="675" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/0ec60652-c2a3-47bb-9f9d-7e81665355a8">


On Gitea (before):

<img width="673" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/cce818bf-5edc-4656-86e1-2c81c304cdb2">

On Gitea (after):

<img width="673" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/0b3b15af-4d48-4bab-a334-4738a1b0eb4a">
 2023-05-16 14:49:40 +08:00
KN4CK3R b3e849d1d6 Only delete secrets belonging to its owner (#24284) 2023-04-23 21:35:14 +08:00
KN4CK3RandLunny Xiao 5882e179a9 Add user secrets (#22191) 
Fixes #22183
Replaces #22187

This PR adds secrets for users. I refactored the files for organizations
and repos to use the same logic and templates. I splitted the secrets
from deploy keys again and reverted the fix from #22187.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2023-02-01 20:53:04 +08:00