public/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2025-10-31 21:28:11 +09:00
Code Issues Packages Projects Releases Wiki Activity
9,707 Commits 19 Branches 241 Tags
9196c72b874078f05c457b51bf7511229bc32c83
Commit Graph

63 Commits

Author SHA1 Message Date
James Lakin
b05e178138 Fix repository create/delete event webhooks (#13008) (#13027) 2020-10-04 17:42:03 -04:00
mrsdizzie
23aae3274a Fix panic when adding long comment (#12892) (#12894) 
Previous PR #12881 causes out of bounds panic by working on wrong string.
 2020-09-18 16:45:00 -04:00
赵智超
65aef7b35f Add size limit for content of comment on action ui (#12881) (#12890) 
Signed-off-by: a1012112796 <1012112796@qq.com>
Co-authored-by: mrsdizzie <info@mrsdizzie.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

Co-authored-by: mrsdizzie <info@mrsdizzie.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2020-09-18 19:58:49 +08:00
zeripath
6f6edb8fab Add NotifySyncPushCommits to indexer notifier (#11309) 
Thanks to @simon-on-gh for tracking down the issue.

Fix #11200

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2020-05-08 15:58:40 +01:00
zeripath
4974b7c120 Fix spelling mistake with Rewiew (#11262) 
Signed-off-by: Andrew Thornton <art27@cantab.net>
 2020-04-30 21:24:08 +01:00
赵智超
ef89e75d0e add request review from specific reviewers feature in pull request (#10756) 
* add request review feature in pull request

add a way to notify specific reviewers to review like github , by add  or delet a  special type
review . The acton is  is similar to Assign ,  so many code reuse the function and items of
Assignee, but the meaning and result is different.

The Permission style is is similar to github, that only writer can add a review request from Reviewers,
but the poster can recall and remove a review request after a reviwer has revied even if he don't have
Write Premission. only manager , the poster and reviewer of a request review can remove it.

The reviewers can be requested to review contain all readers for private repo , for public, contain
all writers and watchers.

The offical Review Request will block merge if Reject can block it.

an other change: add ui otify for Assignees.

Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: Lauris BH <lauris@nix.lv>

Signed-off-by: a1012112796 <1012112796@qq.com>

* new change

* add placeholder string

* do some changes follow #10238 to add review requests num on lists also
change icon for review requests to eye

Co-authored-by: Lauris BH <lauris@nix.lv>
 2020-04-06 19:33:34 +03:00
John Olheiser
3f1c0841cb Granular webhook events (#9626) 
* Initial work

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Add PR reviews and API coverage

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Split up events

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Add migration and locale

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Format

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Revert IsPull

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Fix comments

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Fix tests

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Fix PR reviews

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Fix issue_comment

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Make fmt

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Migrations

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Backwards compatible API

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Fix feishu

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Move session commit

Signed-off-by: jolheiser <john.olheiser@gmail.com>

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
 2020-03-06 07:10:48 +02:00
6543
7e8cdba181 [Refactor] move APIFormat() of Issue and Label to convert package (#10423) 
* Label: delete .APIFormat() and use convert.ToLabel()

* move issue APIFormat too

* add missing one

* move TEST too

* handle error -> return empty APIIssue

* Apply suggestions from code review

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
 2020-02-28 23:49:50 -03:00
Lunny Xiao
542bd59239 Fix webhook bug (#10427) 
Co-authored-by: techknowlogick <matti@mdranta.net>
 2020-02-23 13:49:40 -05:00
Lunny Xiao
21e771c41b Fix notification (#10331) 2020-02-18 10:52:57 +02:00
zeripath
791b109d6f Notification: queue ui.go notification-service (#10281) 
Co-authored-by: Lauris BH <lauris@nix.lv>
 2020-02-15 19:29:43 -05:00
Lauris BH
ad2642a8aa Language statistics bar for repositories (#8037) 
* Implementation for calculating language statistics

Impement saving code language statistics to database

Implement rendering langauge stats

Add primary laguage to show in repository list

Implement repository stats indexer queue

Add indexer test

Refactor to use queue module

* Do not timeout for queues
 2020-02-11 11:34:17 +02:00
guillep2k
dbd1fae618 Fix repo indexer not updating upon push (#9957) 
* Fix check for push on default branch

* restart CI

Co-authored-by: zeripath <art27@cantab.net>
 2020-01-24 20:00:49 +02:00
6543
06cd3e03a2 [refactor] notify remove unused praram (#9804) 2020-01-16 17:24:20 +01:00
Lunny Xiao
99d869fa63 Move push commits from models to modules/repository (#9370) 
* Move push commits from models to modules/repository

* fix test

* fix test

* fix test

* fix test

* fix test

Co-authored-by: zeripath <art27@cantab.net>
 2020-01-10 17:34:21 +08:00
Lunny Xiao
384c2b342e Move pull request api convert to convert package (#9664) 
* Move pull request api convert to convert package

* Rename ToPullRequest to ToAPIPullRequest
 2020-01-10 15:53:53 +08:00
mrsdizzie
b39fab41c8 Some more e-mail notification fixes (#9596) 
* Some more e-mail notification fixes

A few more small e-mail notification fixes/changes

* Style footer of notification email to be smaller
* Include text for when pull request is merged
* Don't include original body of issue or PR when merging/closing by
setting issue.Content to "" in these cases

* Set Re: prefix and meessage-ID headers based on actName instead of checking for a
comment. This fixes a bug where certain actions that didn't have a
comment were setting Message-ID instead of In-Reply-To which caused some
mail programs not to show those messages as they would have had the same
Message-ID as a previous message. Also fixes the case where a final
comment and closing message would have been displayed out of order if
you didn't have a copy of the original issue/pr cretion message.

* Update other template footers for consistency
 2020-01-03 19:13:22 +02:00
mrsdizzie
1df701fd1a Add ActionCommentPull action (#9456) 
* Add ActionCommentPull action

Adds ActionCommentPull action to distinguish between a comment on an
issue and on a pull request

* Update modules/notification/action/action.go

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2019-12-22 08:29:26 +00:00
guillep2k
4f42e03a35 Fix wrong notification on merge (#9450) 2019-12-20 22:31:05 +00:00
Mario Lubenka
61db834904 Change target branch for pull request (#6488) 
* Adds functionality to change target branch of created pull requests

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Use const instead of var in JavaScript additions

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Check if branches are equal and if PR already exists before changing target branch

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Make sure to check all commits

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Print error messages for user as error flash message

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Disallow changing target branch of closed or merged pull requests

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Resolve conflicts after merge of upstream/master

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Change order of branch select fields

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Removes duplicate check

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Use ctx.Tr for translations

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Recompile JS

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Use correct translation namespace

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Remove redundant if condition

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Moves most change branch logic into pull service

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Completes comment

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Add Ref to ChangesPayload for logging changed target branches
instead of creating a new struct

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Revert changes to go.mod

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Directly use createComment method

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Return 404 if pull request is not found. Move written check up

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Remove variable declaration

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Return client errors on change pull request target errors

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Return error in commit.HasPreviousCommit

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Adds blank line

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Test patch before persisting new target branch

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Update patch before testing (not working)

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Removes patch calls when changeing pull request target

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Removes unneeded check for base name

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Moves ChangeTargetBranch completely to pull service. Update patch status.

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Set webhook mode after errors were validated

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Update PR in one transaction

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Move logic for check if head is equal with branch to pull model

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Adds missing comment and simplify return

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Adjust CreateComment method call

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
 2019-12-16 14:20:25 +08:00
Lunny Xiao
67b316a954 Refactor comment (#9330) 
* Refactor comment

* fix test

* improve code
 2019-12-15 16:57:34 -05:00
Lunny Xiao
ba1acf5b50 fix issue indexer not triggered when migrating a repository (#9332) 2019-12-12 23:46:43 +02:00
Lunny Xiao
be06dee04c Move code indexer related code to a new package (#9191) 
* move code indexer related code to a new package

* fix lint

* fix tests

* fix fmt

* GetMaxID support interface parameter
 2019-12-08 14:15:35 -05:00
Lunny Xiao
8ab35eefc4 Move mirror sync actions to notification (#9022) 
* Move mirror sync actions to notification

* fix lint
 2019-11-24 00:16:59 -05:00
Lunny Xiao
d7ac9727bb Move merge actions to notification (#9024) 
* Move merge actions to notification

* Add missing mail notification
 2019-11-21 12:08:42 -05:00
guillep2k
9930d47be2 Add review comments to mail notifications (#8996) 2019-11-15 12:59:21 +00:00
Lunny Xiao
21ae9838e0 Move transfer repository and rename repository on a service package and start action notification (#8573) 
* move transfer repository and rename repository on a service package and start action notification

* remove unused codes

* fix lint

* fix bugs

* fix test

* fix test

* fix test

* fix lint

* update go mod and sum
 2019-11-15 16:06:11 +08:00
John Olheiser
06a8504c78 Update dashboard context for PR reviews (#8995) 
* Update dashboard context for PR reviews

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Update options/locale/locale_en-US.ini

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>

* Only append head action if it has content or is approval/rejection

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Update options/locale/locale_en-US.ini

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
 2019-11-15 00:52:18 +01:00
Lunny Xiao
dad67cae54 Refactor pull request review (#8954) 
* refactor submit review

* remove unnecessary code

* remove unused comment

* fix lint

* remove duplicated actions

* remove duplicated actions

* fix typo

* fix comment content
 2019-11-14 10:57:36 +08:00
zeripath
722a7c902d Add Close() method to gogitRepository (#8901) 
In investigating #7947 it has become clear that the storage component of go-git repositories needs closing.

This PR adds this Close function and adds the Close functions as necessary.

In TransferOwnership the ctx.Repo.GitRepo is closed if it is open to help prevent the risk of multiple open files.

Fixes #7947
 2019-11-13 07:01:19 +00:00
zeripath
253fdfb7fa Fix Notify Create Ref Error on tag creation (#8936) 
* Fix Notify Create Ref Error on tag creation

* Just use the provided full ref instead of BranchCommit
 2019-11-13 00:49:40 +01:00
Lunny Xiao
bb6879d339 Improve notification (#8835) 
* Improve notifications

* batch load user

* Update notification only when read

* Fix reorder

* fix lint

* fix test

* fix lint

* make function meaningful

* fix comment
 2019-11-12 16:33:34 +08:00
Lunny Xiao
273a24f226 Move notifywatchers from models to notification (#8907) 2019-11-11 11:39:41 +08:00
Lunny Xiao
016a5d0438 Move some actions to notification/action (#8779) 
* Move some actions to notification/action

* Fix test

* fix test
 2019-11-08 15:54:50 -05:00
Lunny Xiao
0109229928 Move release webhook to notification (#8817) 
* Move release webhook to notification

* Extract release webhook method

* fix bug

* fix import
 2019-11-06 16:25:50 +08:00
Lunny Xiao
8a84d82d53 Move repofiles webhooks to notification (#8807) 2019-11-06 14:43:03 +08:00
Lunny Xiao
aaeef295bb Move pull webhook to notification (#8805) 
* Move pull webhook to notification

* fix fmt
 2019-11-05 19:04:08 +08:00
Lunny Xiao
491887d441 Move actions to notification (#8785) 2019-11-03 20:59:09 +00:00
Lunny Xiao
022d2d8beb Move push commits events to notification (#8783) 
* Move push commits events to notification

* Update modules/notification/base/null.go

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
 2019-11-03 14:59:26 +08:00
Lunny Xiao
8f26397928 Move issue milestone assign to issue service and move webhook to notification (#8780) 2019-11-02 11:33:20 +08:00
Lunny Xiao
f518fe6662 Rename HookQueue to hookQueue (#8778) 
* Rename HookQueue to hookQueue

* fix lint
 2019-11-02 10:35:12 +08:00
Lunny Xiao
4b8d9e58c5 Move labels webhooks to notification (#8749) 
* Move webhooks to notification

* fix notification
 2019-11-02 09:49:57 +08:00
Lunny Xiao
0e7f7df3cf Move webhook to a standalone package under modules (#8747) 
* Move webhook to a standalone package under modules

* fix test

* fix comments
 2019-11-01 22:51:22 +00:00
Lunny Xiao
ac6accef09 Move webhook codes from service to webhook notification (#8712) 
* Move webhook codes from service to webhook notification

* move deletecomment webhook to notifications

* fix notification
 2019-10-30 12:02:46 +02:00
Lunny Xiao
f694bb45d7 Move issue change content from models to service (#8711) 
* Move issue change content from models to service

* fix lint
 2019-10-30 10:36:25 +02:00
Lunny Xiao
af8957bc4c Move issue notifications (#8713) 2019-10-29 00:45:43 +08:00
Lunny Xiao
c66c9dabc7 Move issue change status from models to service (#8691) 2019-10-28 13:26:46 +08:00
Lunny Xiao
495d5e4329 Move more issue assignee code from models to issue service (#8690) 
* Move more issue assignee code from models to issue service

* fix test
 2019-10-28 10:11:50 +08:00
Lunny Xiao
9e85358777 Move some repositories' operations to a standalone service package (#8557) 
* Move some repositories' operations to a standalone service package

* improve code

* remove unused codes

* add rollback when fork failed

* add repo when return
 2019-10-26 14:54:11 +08:00
David Svantesson
6aa3f8bc29 Mail assignee when issue/pull request is assigned (#8546) 
* Send email to assigned user

* Only send mail if enabled

* Mail also when assigned through API

* Need to refactor functions from models to issue service

* Refer to issue index rather than ID

* Disable email notifications completly at initalization if global disable

* Check of user enbled mail shall be in mail notification function only

* Initialize notifications from routers init function.

* Use the assigned comment when sending assigned mail

* Refactor so that assignees always added as separate step when new issue/pr.

* Check error from AddAssignees

* Check if user can be assiged to issue or pull request

* Missing return

* Refactor of CanBeAssigned check.

CanBeAssigned shall have same check as UI.

* Clarify function names (toggle rather than update/change), and clean up.

* Fix review comments.

* Flash error if assignees was not added when creating issue/pr

* Generate error if assignee users doesn't exist
 2019-10-25 22:46:37 +08:00