// Copyright 2019 The Gitea Authors. All rights reserved. // SPDX-License-Identifier: MIT package integration import ( "net/http" "testing" auth_model "gitea.dev/models/auth" "gitea.dev/models/unittest" user_model "gitea.dev/models/user" api "gitea.dev/modules/structs" "gitea.dev/tests" "github.com/stretchr/testify/assert" ) func compareCommitFiles(t *testing.T, expect []string, files []*api.CommitAffectedFiles) { var actual []string for i := range files { actual = append(actual, files[i].Filename) } assert.ElementsMatch(t, expect, actual) } func TestAPIReposGitCommits(t *testing.T) { defer tests.PrepareTestEnv(t)() user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2}) session := loginUser(t, user2.Name) token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadRepository) // check invalid requests req := NewRequestf(t, "GET", "/api/v1/repos/%s/repo1/git/commits/..", user2.Name).AddTokenAuth(token) MakeRequest(t, req, http.StatusUnprocessableEntity) req = NewRequestf(t, "GET", "/api/v1/repos/%s/repo1/git/commits/ref-not-exist", user2.Name).AddTokenAuth(token) MakeRequest(t, req, http.StatusNotFound) for _, ref := range [...]string{ "master", // Branch "v1.1", // Tag "65f1", // short sha "65f1bf27bc3bf70f64657658635e66094edbcb4d", // full sha } { req = NewRequestf(t, "GET", "/api/v1/repos/%s/repo1/git/commits/%s", user2.Name, ref).AddTokenAuth(token) MakeRequest(t, req, http.StatusOK) // GitHub-compatible req = NewRequestf(t, "GET", "/api/v1/repos/%s/repo1/commits/%s", user2.Name, ref).AddTokenAuth(token) MakeRequest(t, req, http.StatusOK) } } func TestAPIReposGitCommitsHEAD(t *testing.T) { defer tests.PrepareTestEnv(t)() user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2}) session := loginUser(t, user.Name) token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadRepository) // HEAD on a valid ref must return 200 (RFC 9110 ยง9.3.2) req := NewRequestf(t, "HEAD", "/api/v1/repos/%s/repo1/git/commits/master", user.Name). AddTokenAuth(token) MakeRequest(t, req, http.StatusOK) // HEAD on a missing sha must return 404, not 405 req = NewRequestf(t, "HEAD", "/api/v1/repos/%s/repo1/git/commits/12345", user.Name). AddTokenAuth(token) MakeRequest(t, req, http.StatusNotFound) } func TestAPIReposGitCommitList(t *testing.T) { defer tests.PrepareTestEnv(t)() user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2}) // Login as User2. session := loginUser(t, user.Name) token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadRepository) for _, testCase := range []struct { name, path, total string commits []string files [][]string }{ // Test getting commits (Page 1) { "Page1", "repo20/commits?not=master&sha=remove-files-a", "2", []string{"cfe3b3c1fd36fba04f9183287b106497e1afe986", "c8e31bc7688741a5287fcde4fbb8fc129ca07027"}, [][]string{{"link_hi", "test.csv"}, {"test.csv"}}, }, // Test getting commits (Page 1) { "NotMaster", "repo16/commits", "3", []string{"69554a64c1e6030f051e5c3f94bfbd773cd6a324", "27566bd5738fc8b4e3fef3c5e72cce608537bd95", "5099b81332712fe655e34e8dd63574f503f61811"}, [][]string{{"readme.md"}, {"readme.md"}, {"readme.md"}}, }, // Test getting commits (Page=1, Branch=good-sign) { "DifferentBranch", "repo16/commits?sha=good-sign", "", []string{"f27c2b2b03dcab38beaf89b0ab4ff61f6de63441"}, [][]string{{"readme.md"}}, }, { "FileHistory", "repo16/commits?path=readme.md&sha=good-sign", "1", []string{"f27c2b2b03dcab38beaf89b0ab4ff61f6de63441"}, [][]string{{"readme.md"}}, }, { "FileHistoryNotOnMaster", "repo20/commits?path=test.csv&sha=add-csv¬=master", "1", []string{"c8e31bc7688741a5287fcde4fbb8fc129ca07027"}, [][]string{{"test.csv"}}, }, } { t.Run(testCase.name, func(t *testing.T) { req := NewRequestf(t, "GET", "/api/v1/repos/%s/%s", user.Name, testCase.path). AddTokenAuth(token) resp := MakeRequest(t, req, http.StatusOK) apiData := DecodeJSON(t, resp, []api.Commit{}) assert.Len(t, apiData, len(testCase.commits)) for i, sha := range testCase.commits { assert.Equal(t, sha, apiData[i].CommitMeta.SHA) compareCommitFiles(t, testCase.files[i], apiData[i].Files) } if testCase.total != "" { assert.Equal(t, testCase.total, resp.Header().Get("X-Total")) } }) } } func TestAPIReposGitCommitListPage2Empty(t *testing.T) { defer tests.PrepareTestEnv(t)() user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2}) // Login as User2. session := loginUser(t, user.Name) token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadRepository) // Test getting commits (Page=2) req := NewRequestf(t, "GET", "/api/v1/repos/%s/repo16/commits?page=2", user.Name). AddTokenAuth(token) resp := MakeRequest(t, req, http.StatusOK) apiData := DecodeJSON(t, resp, []api.Commit{}) assert.Empty(t, apiData) } func TestAPIReposGitCommitListWithoutSelectFields(t *testing.T) { defer tests.PrepareTestEnv(t)() user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2}) // Login as User2. session := loginUser(t, user.Name) token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadRepository) // Test getting commits without files, verification, and stats req := NewRequestf(t, "GET", "/api/v1/repos/%s/repo16/commits?sha=good-sign&stat=false&files=false&verification=false", user.Name). AddTokenAuth(token) resp := MakeRequest(t, req, http.StatusOK) apiData := DecodeJSON(t, resp, []api.Commit{}) assert.Len(t, apiData, 1) assert.Equal(t, "f27c2b2b03dcab38beaf89b0ab4ff61f6de63441", apiData[0].CommitMeta.SHA) assert.Equal(t, (*api.CommitStats)(nil), apiData[0].Stats) assert.Equal(t, (*api.PayloadCommitVerification)(nil), apiData[0].RepoCommit.Verification) assert.Equal(t, ([]*api.CommitAffectedFiles)(nil), apiData[0].Files) } func TestDownloadCommitDiffOrPatch(t *testing.T) { defer tests.PrepareTestEnv(t)() user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2}) // Login as User2. session := loginUser(t, user.Name) token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadRepository) // Test getting diff reqDiff := NewRequestf(t, "GET", "/api/v1/repos/%s/repo16/git/commits/f27c2b2b03dcab38beaf89b0ab4ff61f6de63441.diff", user.Name). AddTokenAuth(token) resp := MakeRequest(t, reqDiff, http.StatusOK) assert.Equal(t, "commit f27c2b2b03dcab38beaf89b0ab4ff61f6de63441\nAuthor: User2 \nDate: Sun Aug 6 19:55:01 2017 +0200\n\n good signed commit\n\ndiff --git a/readme.md b/readme.md\nnew file mode 100644\nindex 0000000..458121c\n--- /dev/null\n+++ b/readme.md\n@@ -0,0 +1 @@\n+good sign\n", resp.Body.String()) // Test getting patch reqPatch := NewRequestf(t, "GET", "/api/v1/repos/%s/repo16/git/commits/f27c2b2b03dcab38beaf89b0ab4ff61f6de63441.patch", user.Name). AddTokenAuth(token) resp = MakeRequest(t, reqPatch, http.StatusOK) assert.Equal(t, "From f27c2b2b03dcab38beaf89b0ab4ff61f6de63441 Mon Sep 17 00:00:00 2001\nFrom: User2 \nDate: Sun, 6 Aug 2017 19:55:01 +0200\nSubject: [PATCH] good signed commit\n\n---\n readme.md | 1 +\n 1 file changed, 1 insertion(+)\n create mode 100644 readme.md\n\ndiff --git a/readme.md b/readme.md\nnew file mode 100644\nindex 0000000..458121c\n--- /dev/null\n+++ b/readme.md\n@@ -0,0 +1 @@\n+good sign\n", resp.Body.String()) } func TestGetFileHistoryEmptyDateRange(t *testing.T) { defer tests.PrepareTestEnv(t)() user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2}) // Login as User2. session := loginUser(t, user.Name) token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadRepository) // readme.md exists in repo16 but no commits fall before 1970, so the date // filter yields an empty range: this must return 200 with an empty list, // not 404 (regression: a valid path with an empty date range was a 404). req := NewRequestf(t, "GET", "/api/v1/repos/%s/repo16/commits?path=readme.md&sha=good-sign&until=1970-01-01T00:00:00Z", user.Name). AddTokenAuth(token) resp := MakeRequest(t, req, http.StatusOK) apiData := DecodeJSON(t, resp, []api.Commit{}) assert.Empty(t, apiData) assert.Equal(t, "0", resp.Header().Get("X-Total")) // a path that does not exist must still return 404 even with a date filter req = NewRequestf(t, "GET", "/api/v1/repos/%s/repo16/commits?path=does-not-exist.md&sha=good-sign&until=1970-01-01T00:00:00Z", user.Name). AddTokenAuth(token) MakeRequest(t, req, http.StatusNotFound) }