mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-31 21:28:11 +09:00 
			
		
		
		
	## Changes
- Adds the following high level access scopes, each with `read` and
`write` levels:
    - `activitypub`
    - `admin` (hidden if user is not a site admin)
    - `misc`
    - `notification`
    - `organization`
    - `package`
    - `issue`
    - `repository`
    - `user`
- Adds new middleware function `tokenRequiresScopes()` in addition to
`reqToken()`
  -  `tokenRequiresScopes()` is used for each high-level api section
- _if_ a scoped token is present, checks that the required scope is
included based on the section and HTTP method
  - `reqToken()` is used for individual routes
- checks that required authentication is present (but does not check
scope levels as this will already have been handled by
`tokenRequiresScopes()`
- Adds migration to convert old scoped access tokens to the new set of
scopes
- Updates the user interface for scope selection
### User interface example
<img width="903" alt="Screen Shot 2023-05-31 at 1 56 55 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/654766ec-2143-4f59-9037-3b51600e32f3">
<img width="917" alt="Screen Shot 2023-05-31 at 1 56 43 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/1ad64081-012c-4a73-b393-66b30352654c">
## tokenRequiresScopes  Design Decision
- `tokenRequiresScopes()` was added to more reliably cover api routes.
For an incoming request, this function uses the given scope category
(say `AccessTokenScopeCategoryOrganization`) and the HTTP method (say
`DELETE`) and verifies that any scoped tokens in use include
`delete:organization`.
- `reqToken()` is used to enforce auth for individual routes that
require it. If a scoped token is not present for a request,
`tokenRequiresScopes()` will not return an error
## TODO
- [x] Alphabetize scope categories
- [x] Change 'public repos only' to a radio button (private vs public).
Also expand this to organizations
- [X] Disable token creation if no scopes selected. Alternatively, show
warning
- [x] `reqToken()` is missing from many `POST/DELETE` routes in the api.
`tokenRequiresScopes()` only checks that a given token has the correct
scope, `reqToken()` must be used to check that a token (or some other
auth) is present.
   -  _This should be addressed in this PR_
- [x] The migration should be reviewed very carefully in order to
minimize access changes to existing user tokens.
   - _This should be addressed in this PR_
- [x] Link to api to swagger documentation, clarify what
read/write/delete levels correspond to
- [x] Review cases where more than one scope is needed as this directly
deviates from the api definition.
   - _This should be addressed in this PR_
   - For example: 
   ```go
	m.Group("/users/{username}/orgs", func() {
		m.Get("", reqToken(), org.ListUserOrgs)
		m.Get("/{org}/permissions", reqToken(), org.GetUserOrgsPermissions)
}, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryUser,
auth_model.AccessTokenScopeCategoryOrganization),
context_service.UserAssignmentAPI())
   ```
## Future improvements
- [ ] Add required scopes to swagger documentation
- [ ] Redesign `reqToken()` to be opt-out rather than opt-in
- [ ] Subdivide scopes like `repository`
- [ ] Once a token is created, if it has no scopes, we should display
text instead of an empty bullet point
- [ ] If the 'public repos only' option is selected, should read
categories be selected by default
Closes #24501
Closes #24799
Co-authored-by: Jonathan Tran <jon@allspice.io>
Co-authored-by: Kyle D <kdumontnu@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
		
	
		
			
				
	
	
		
			251 lines
		
	
	
		
			8.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			251 lines
		
	
	
		
			8.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2018 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package integration
 | |
| 
 | |
| import (
 | |
| 	"fmt"
 | |
| 	"net/http"
 | |
| 	"net/url"
 | |
| 	"testing"
 | |
| 
 | |
| 	auth_model "code.gitea.io/gitea/models/auth"
 | |
| 	repo_model "code.gitea.io/gitea/models/repo"
 | |
| 	"code.gitea.io/gitea/models/unittest"
 | |
| 	user_model "code.gitea.io/gitea/models/user"
 | |
| 	"code.gitea.io/gitea/modules/git"
 | |
| 	api "code.gitea.io/gitea/modules/structs"
 | |
| 	"code.gitea.io/gitea/tests"
 | |
| 
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| )
 | |
| 
 | |
| func TestAPIListReleases(t *testing.T) {
 | |
| 	defer tests.PrepareTestEnv(t)()
 | |
| 
 | |
| 	repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
 | |
| 	user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
 | |
| 	token := getUserToken(t, user2.LowerName, auth_model.AccessTokenScopeReadRepository)
 | |
| 
 | |
| 	link, _ := url.Parse(fmt.Sprintf("/api/v1/repos/%s/%s/releases", user2.Name, repo.Name))
 | |
| 	link.RawQuery = url.Values{"token": {token}}.Encode()
 | |
| 	resp := MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)
 | |
| 	var apiReleases []*api.Release
 | |
| 	DecodeJSON(t, resp, &apiReleases)
 | |
| 	if assert.Len(t, apiReleases, 3) {
 | |
| 		for _, release := range apiReleases {
 | |
| 			switch release.ID {
 | |
| 			case 1:
 | |
| 				assert.False(t, release.IsDraft)
 | |
| 				assert.False(t, release.IsPrerelease)
 | |
| 			case 4:
 | |
| 				assert.True(t, release.IsDraft)
 | |
| 				assert.False(t, release.IsPrerelease)
 | |
| 			case 5:
 | |
| 				assert.False(t, release.IsDraft)
 | |
| 				assert.True(t, release.IsPrerelease)
 | |
| 			default:
 | |
| 				assert.NoError(t, fmt.Errorf("unexpected release: %v", release))
 | |
| 			}
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	// test filter
 | |
| 	testFilterByLen := func(auth bool, query url.Values, expectedLength int, msgAndArgs ...string) {
 | |
| 		if auth {
 | |
| 			query.Set("token", token)
 | |
| 		}
 | |
| 		link.RawQuery = query.Encode()
 | |
| 		resp = MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)
 | |
| 		DecodeJSON(t, resp, &apiReleases)
 | |
| 		assert.Len(t, apiReleases, expectedLength, msgAndArgs)
 | |
| 	}
 | |
| 
 | |
| 	testFilterByLen(false, url.Values{"draft": {"true"}}, 0, "anon should not see drafts")
 | |
| 	testFilterByLen(true, url.Values{"draft": {"true"}}, 1, "repo owner should see drafts")
 | |
| 	testFilterByLen(true, url.Values{"draft": {"false"}}, 2, "exclude drafts")
 | |
| 	testFilterByLen(true, url.Values{"draft": {"false"}, "pre-release": {"false"}}, 1, "exclude drafts and pre-releases")
 | |
| 	testFilterByLen(true, url.Values{"pre-release": {"true"}}, 1, "only get pre-release")
 | |
| 	testFilterByLen(true, url.Values{"draft": {"true"}, "pre-release": {"true"}}, 0, "there is no pre-release draft")
 | |
| }
 | |
| 
 | |
| func createNewReleaseUsingAPI(t *testing.T, session *TestSession, token string, owner *user_model.User, repo *repo_model.Repository, name, target, title, desc string) *api.Release {
 | |
| 	urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/releases?token=%s",
 | |
| 		owner.Name, repo.Name, token)
 | |
| 	req := NewRequestWithJSON(t, "POST", urlStr, &api.CreateReleaseOption{
 | |
| 		TagName:      name,
 | |
| 		Title:        title,
 | |
| 		Note:         desc,
 | |
| 		IsDraft:      false,
 | |
| 		IsPrerelease: false,
 | |
| 		Target:       target,
 | |
| 	})
 | |
| 	resp := MakeRequest(t, req, http.StatusCreated)
 | |
| 
 | |
| 	var newRelease api.Release
 | |
| 	DecodeJSON(t, resp, &newRelease)
 | |
| 	rel := &repo_model.Release{
 | |
| 		ID:      newRelease.ID,
 | |
| 		TagName: newRelease.TagName,
 | |
| 		Title:   newRelease.Title,
 | |
| 	}
 | |
| 	unittest.AssertExistsAndLoadBean(t, rel)
 | |
| 	assert.EqualValues(t, newRelease.Note, rel.Note)
 | |
| 
 | |
| 	return &newRelease
 | |
| }
 | |
| 
 | |
| func TestAPICreateAndUpdateRelease(t *testing.T) {
 | |
| 	defer tests.PrepareTestEnv(t)()
 | |
| 
 | |
| 	repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
 | |
| 	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID})
 | |
| 	session := loginUser(t, owner.LowerName)
 | |
| 	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteRepository)
 | |
| 
 | |
| 	gitRepo, err := git.OpenRepository(git.DefaultContext, repo.RepoPath())
 | |
| 	assert.NoError(t, err)
 | |
| 	defer gitRepo.Close()
 | |
| 
 | |
| 	err = gitRepo.CreateTag("v0.0.1", "master")
 | |
| 	assert.NoError(t, err)
 | |
| 
 | |
| 	target, err := gitRepo.GetTagCommitID("v0.0.1")
 | |
| 	assert.NoError(t, err)
 | |
| 
 | |
| 	newRelease := createNewReleaseUsingAPI(t, session, token, owner, repo, "v0.0.1", target, "v0.0.1", "test")
 | |
| 
 | |
| 	urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/releases/%d?token=%s",
 | |
| 		owner.Name, repo.Name, newRelease.ID, token)
 | |
| 	req := NewRequest(t, "GET", urlStr)
 | |
| 	resp := MakeRequest(t, req, http.StatusOK)
 | |
| 
 | |
| 	var release api.Release
 | |
| 	DecodeJSON(t, resp, &release)
 | |
| 
 | |
| 	assert.Equal(t, newRelease.TagName, release.TagName)
 | |
| 	assert.Equal(t, newRelease.Title, release.Title)
 | |
| 	assert.Equal(t, newRelease.Note, release.Note)
 | |
| 
 | |
| 	req = NewRequestWithJSON(t, "PATCH", urlStr, &api.EditReleaseOption{
 | |
| 		TagName:      release.TagName,
 | |
| 		Title:        release.Title,
 | |
| 		Note:         "updated",
 | |
| 		IsDraft:      &release.IsDraft,
 | |
| 		IsPrerelease: &release.IsPrerelease,
 | |
| 		Target:       release.Target,
 | |
| 	})
 | |
| 	resp = MakeRequest(t, req, http.StatusOK)
 | |
| 
 | |
| 	DecodeJSON(t, resp, &newRelease)
 | |
| 	rel := &repo_model.Release{
 | |
| 		ID:      newRelease.ID,
 | |
| 		TagName: newRelease.TagName,
 | |
| 		Title:   newRelease.Title,
 | |
| 	}
 | |
| 	unittest.AssertExistsAndLoadBean(t, rel)
 | |
| 	assert.EqualValues(t, rel.Note, newRelease.Note)
 | |
| }
 | |
| 
 | |
| func TestAPICreateReleaseToDefaultBranch(t *testing.T) {
 | |
| 	defer tests.PrepareTestEnv(t)()
 | |
| 
 | |
| 	repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
 | |
| 	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID})
 | |
| 	session := loginUser(t, owner.LowerName)
 | |
| 	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteRepository)
 | |
| 
 | |
| 	createNewReleaseUsingAPI(t, session, token, owner, repo, "v0.0.1", "", "v0.0.1", "test")
 | |
| }
 | |
| 
 | |
| func TestAPICreateReleaseToDefaultBranchOnExistingTag(t *testing.T) {
 | |
| 	defer tests.PrepareTestEnv(t)()
 | |
| 
 | |
| 	repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
 | |
| 	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID})
 | |
| 	session := loginUser(t, owner.LowerName)
 | |
| 	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteRepository)
 | |
| 
 | |
| 	gitRepo, err := git.OpenRepository(git.DefaultContext, repo.RepoPath())
 | |
| 	assert.NoError(t, err)
 | |
| 	defer gitRepo.Close()
 | |
| 
 | |
| 	err = gitRepo.CreateTag("v0.0.1", "master")
 | |
| 	assert.NoError(t, err)
 | |
| 
 | |
| 	createNewReleaseUsingAPI(t, session, token, owner, repo, "v0.0.1", "", "v0.0.1", "test")
 | |
| }
 | |
| 
 | |
| func TestAPIGetLatestRelease(t *testing.T) {
 | |
| 	defer tests.PrepareTestEnv(t)()
 | |
| 
 | |
| 	repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
 | |
| 	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID})
 | |
| 
 | |
| 	urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/releases/latest",
 | |
| 		owner.Name, repo.Name)
 | |
| 
 | |
| 	req := NewRequestf(t, "GET", urlStr)
 | |
| 	resp := MakeRequest(t, req, http.StatusOK)
 | |
| 
 | |
| 	var release *api.Release
 | |
| 	DecodeJSON(t, resp, &release)
 | |
| 
 | |
| 	assert.Equal(t, "testing-release", release.Title)
 | |
| }
 | |
| 
 | |
| func TestAPIGetReleaseByTag(t *testing.T) {
 | |
| 	defer tests.PrepareTestEnv(t)()
 | |
| 
 | |
| 	repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
 | |
| 	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID})
 | |
| 
 | |
| 	tag := "v1.1"
 | |
| 
 | |
| 	urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/releases/tags/%s",
 | |
| 		owner.Name, repo.Name, tag)
 | |
| 
 | |
| 	req := NewRequestf(t, "GET", urlStr)
 | |
| 	resp := MakeRequest(t, req, http.StatusOK)
 | |
| 
 | |
| 	var release *api.Release
 | |
| 	DecodeJSON(t, resp, &release)
 | |
| 
 | |
| 	assert.Equal(t, "testing-release", release.Title)
 | |
| 
 | |
| 	nonexistingtag := "nonexistingtag"
 | |
| 
 | |
| 	urlStr = fmt.Sprintf("/api/v1/repos/%s/%s/releases/tags/%s",
 | |
| 		owner.Name, repo.Name, nonexistingtag)
 | |
| 
 | |
| 	req = NewRequestf(t, "GET", urlStr)
 | |
| 	resp = MakeRequest(t, req, http.StatusNotFound)
 | |
| 
 | |
| 	var err *api.APIError
 | |
| 	DecodeJSON(t, resp, &err)
 | |
| 	assert.NotEmpty(t, err.Message)
 | |
| }
 | |
| 
 | |
| func TestAPIDeleteReleaseByTagName(t *testing.T) {
 | |
| 	defer tests.PrepareTestEnv(t)()
 | |
| 
 | |
| 	repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
 | |
| 	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID})
 | |
| 	session := loginUser(t, owner.LowerName)
 | |
| 	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteRepository)
 | |
| 
 | |
| 	createNewReleaseUsingAPI(t, session, token, owner, repo, "release-tag", "", "Release Tag", "test")
 | |
| 
 | |
| 	// delete release
 | |
| 	req := NewRequestf(t, http.MethodDelete, fmt.Sprintf("/api/v1/repos/%s/%s/releases/tags/release-tag?token=%s", owner.Name, repo.Name, token))
 | |
| 	_ = MakeRequest(t, req, http.StatusNoContent)
 | |
| 
 | |
| 	// make sure release is deleted
 | |
| 	req = NewRequestf(t, http.MethodDelete, fmt.Sprintf("/api/v1/repos/%s/%s/releases/tags/release-tag?token=%s", owner.Name, repo.Name, token))
 | |
| 	_ = MakeRequest(t, req, http.StatusNotFound)
 | |
| 
 | |
| 	// delete release tag too
 | |
| 	req = NewRequestf(t, http.MethodDelete, fmt.Sprintf("/api/v1/repos/%s/%s/tags/release-tag?token=%s", owner.Name, repo.Name, token))
 | |
| 	_ = MakeRequest(t, req, http.StatusNoContent)
 | |
| }
 |