mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-29 10:57:44 +09:00 
			
		
		
		
	* Add ETag header. * Comply with RFC 7232. * Moved logic into httpcache.go * Changed name. * Lint * Implemented If-None-Match list. * Fixed missing header on * * Removed weak etag support. * Removed * support. * Added unit test. * Lint Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
		
			
				
	
	
		
			145 lines
		
	
	
		
			4.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			145 lines
		
	
	
		
			4.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2021 The Gitea Authors. All rights reserved.
 | |
| // Use of this source code is governed by a MIT-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package httpcache
 | |
| 
 | |
| import (
 | |
| 	"net/http"
 | |
| 	"net/http/httptest"
 | |
| 	"os"
 | |
| 	"testing"
 | |
| 	"time"
 | |
| 
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| )
 | |
| 
 | |
| type mockFileInfo struct {
 | |
| }
 | |
| 
 | |
| func (m mockFileInfo) Name() string       { return "gitea.test" }
 | |
| func (m mockFileInfo) Size() int64        { return int64(10) }
 | |
| func (m mockFileInfo) Mode() os.FileMode  { return os.ModePerm }
 | |
| func (m mockFileInfo) ModTime() time.Time { return time.Time{} }
 | |
| func (m mockFileInfo) IsDir() bool        { return false }
 | |
| func (m mockFileInfo) Sys() interface{}   { return nil }
 | |
| 
 | |
| func TestHandleFileETagCache(t *testing.T) {
 | |
| 	fi := mockFileInfo{}
 | |
| 	etag := `"MTBnaXRlYS50ZXN0TW9uLCAwMSBKYW4gMDAwMSAwMDowMDowMCBHTVQ="`
 | |
| 
 | |
| 	t.Run("No_If-None-Match", func(t *testing.T) {
 | |
| 		req := &http.Request{Header: make(http.Header)}
 | |
| 		w := httptest.NewRecorder()
 | |
| 
 | |
| 		handled := HandleFileETagCache(req, w, fi)
 | |
| 
 | |
| 		assert.False(t, handled)
 | |
| 		assert.Len(t, w.Header(), 2)
 | |
| 		assert.Contains(t, w.Header(), "Cache-Control")
 | |
| 		assert.Contains(t, w.Header(), "Etag")
 | |
| 		assert.Equal(t, etag, w.Header().Get("Etag"))
 | |
| 	})
 | |
| 	t.Run("Wrong_If-None-Match", func(t *testing.T) {
 | |
| 		req := &http.Request{Header: make(http.Header)}
 | |
| 		w := httptest.NewRecorder()
 | |
| 
 | |
| 		req.Header.Set("If-None-Match", `"wrong etag"`)
 | |
| 
 | |
| 		handled := HandleFileETagCache(req, w, fi)
 | |
| 
 | |
| 		assert.False(t, handled)
 | |
| 		assert.Len(t, w.Header(), 2)
 | |
| 		assert.Contains(t, w.Header(), "Cache-Control")
 | |
| 		assert.Contains(t, w.Header(), "Etag")
 | |
| 		assert.Equal(t, etag, w.Header().Get("Etag"))
 | |
| 	})
 | |
| 	t.Run("Correct_If-None-Match", func(t *testing.T) {
 | |
| 		req := &http.Request{Header: make(http.Header)}
 | |
| 		w := httptest.NewRecorder()
 | |
| 
 | |
| 		req.Header.Set("If-None-Match", etag)
 | |
| 
 | |
| 		handled := HandleFileETagCache(req, w, fi)
 | |
| 
 | |
| 		assert.True(t, handled)
 | |
| 		assert.Len(t, w.Header(), 1)
 | |
| 		assert.Contains(t, w.Header(), "Etag")
 | |
| 		assert.Equal(t, etag, w.Header().Get("Etag"))
 | |
| 		assert.Equal(t, http.StatusNotModified, w.Code)
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func TestHandleGenericETagCache(t *testing.T) {
 | |
| 	etag := `"test"`
 | |
| 
 | |
| 	t.Run("No_If-None-Match", func(t *testing.T) {
 | |
| 		req := &http.Request{Header: make(http.Header)}
 | |
| 		w := httptest.NewRecorder()
 | |
| 
 | |
| 		handled := HandleGenericETagCache(req, w, etag)
 | |
| 
 | |
| 		assert.False(t, handled)
 | |
| 		assert.Len(t, w.Header(), 2)
 | |
| 		assert.Contains(t, w.Header(), "Cache-Control")
 | |
| 		assert.Contains(t, w.Header(), "Etag")
 | |
| 		assert.Equal(t, etag, w.Header().Get("Etag"))
 | |
| 	})
 | |
| 	t.Run("Wrong_If-None-Match", func(t *testing.T) {
 | |
| 		req := &http.Request{Header: make(http.Header)}
 | |
| 		w := httptest.NewRecorder()
 | |
| 
 | |
| 		req.Header.Set("If-None-Match", `"wrong etag"`)
 | |
| 
 | |
| 		handled := HandleGenericETagCache(req, w, etag)
 | |
| 
 | |
| 		assert.False(t, handled)
 | |
| 		assert.Len(t, w.Header(), 2)
 | |
| 		assert.Contains(t, w.Header(), "Cache-Control")
 | |
| 		assert.Contains(t, w.Header(), "Etag")
 | |
| 		assert.Equal(t, etag, w.Header().Get("Etag"))
 | |
| 	})
 | |
| 	t.Run("Correct_If-None-Match", func(t *testing.T) {
 | |
| 		req := &http.Request{Header: make(http.Header)}
 | |
| 		w := httptest.NewRecorder()
 | |
| 
 | |
| 		req.Header.Set("If-None-Match", etag)
 | |
| 
 | |
| 		handled := HandleGenericETagCache(req, w, etag)
 | |
| 
 | |
| 		assert.True(t, handled)
 | |
| 		assert.Len(t, w.Header(), 1)
 | |
| 		assert.Contains(t, w.Header(), "Etag")
 | |
| 		assert.Equal(t, etag, w.Header().Get("Etag"))
 | |
| 		assert.Equal(t, http.StatusNotModified, w.Code)
 | |
| 	})
 | |
| 	t.Run("Multiple_Wrong_If-None-Match", func(t *testing.T) {
 | |
| 		req := &http.Request{Header: make(http.Header)}
 | |
| 		w := httptest.NewRecorder()
 | |
| 
 | |
| 		req.Header.Set("If-None-Match", `"wrong etag", "wrong etag "`)
 | |
| 
 | |
| 		handled := HandleGenericETagCache(req, w, etag)
 | |
| 
 | |
| 		assert.False(t, handled)
 | |
| 		assert.Len(t, w.Header(), 2)
 | |
| 		assert.Contains(t, w.Header(), "Cache-Control")
 | |
| 		assert.Contains(t, w.Header(), "Etag")
 | |
| 		assert.Equal(t, etag, w.Header().Get("Etag"))
 | |
| 	})
 | |
| 	t.Run("Multiple_Correct_If-None-Match", func(t *testing.T) {
 | |
| 		req := &http.Request{Header: make(http.Header)}
 | |
| 		w := httptest.NewRecorder()
 | |
| 
 | |
| 		req.Header.Set("If-None-Match", `"wrong etag", `+etag)
 | |
| 
 | |
| 		handled := HandleGenericETagCache(req, w, etag)
 | |
| 
 | |
| 		assert.True(t, handled)
 | |
| 		assert.Len(t, w.Header(), 1)
 | |
| 		assert.Contains(t, w.Header(), "Etag")
 | |
| 		assert.Equal(t, etag, w.Header().Get("Etag"))
 | |
| 		assert.Equal(t, http.StatusNotModified, w.Code)
 | |
| 	})
 | |
| }
 |