Files
gitea/services/migrations/onedev_test.go
T
178d33ed4d fix: add missing access checks and size limits (#39942)
Several handlers and parsers skipped checks that their siblings already
perform.

- Reject issue, comment, label, milestone and release mutations in
archived repositories via the API with one guard per route group,
matching the web UI
- Hide timeline references and dependencies pointing at issues the doer
cannot read, in the web UI and the API, including pull requests of the
same repository without pull request access
- Reject workflow runs with more than `MaxJobNumPerRun` jobs, including
inline reusable workflow jobs, and show rejected pushes as invalid
workflow runs
- Bound how much of a Helm chart archive is inflated while looking for
`Chart.yaml`

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2026-10-27 21:40:42 +01:00

203 lines
5.6 KiB
Go

// Copyright 2021 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package migrations
import (
"io"
"net/http"
"net/http/httptest"
"net/url"
"os"
"path/filepath"
"runtime"
"sync/atomic"
"testing"
"time"
"gitea.dev/models/unittest"
base "gitea.dev/modules/migration"
"gitea.dev/modules/util"
"github.com/stretchr/testify/assert"
)
func TestOneDevServerVersion(t *testing.T) {
type respMapType map[string]struct {
code int
body string
}
var respMap atomic.Pointer[respMapType]
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
resp, ok := (*respMap.Load())[r.URL.Path]
w.WriteHeader(util.Iif(ok, resp.code, http.StatusNotFound))
_, _ = io.WriteString(w, resp.body)
}))
defer server.Close()
baseURL, err := url.Parse(server.URL)
assert.NoError(t, err)
downloader := func() *OneDevDownloader { return &OneDevDownloader{baseURL: baseURL, client: server.Client()} }
t.Run("LegacyEndpoint", func(t *testing.T) {
respMap.Store(&respMapType{"/~api/version/server": {code: http.StatusOK, body: "12.0.1"}})
d := downloader()
v, err := d.getServerVersion(t.Context())
assert.NoError(t, err)
assert.Equal(t, "12.0.1", v.String())
respMap.Store(&respMapType{}) // remove the legacy endpoint, next call should still succeed by using cached version
v, err = d.getServerVersion(t.Context())
assert.NoError(t, err)
assert.Equal(t, "12.0.1", v.String())
})
t.Run("NewEndpoint", func(t *testing.T) {
respMap.Store(&respMapType{"/~api/server/version": {code: http.StatusOK, body: "16.9.7"}})
v, err := downloader().getServerVersion(t.Context())
assert.NoError(t, err)
assert.Equal(t, "16.9.7", v.String())
})
t.Run("NoEndpoint", func(t *testing.T) {
respMap.Store(&respMapType{})
_, err := downloader().getServerVersion(t.Context())
assert.ErrorContains(t, err, "server version request failed")
})
}
func TestOneDevDownloadRepo(t *testing.T) {
liveMode := os.Getenv("ONEDEV_LIVE") != ""
_, callerFile, _, _ := runtime.Caller(0)
fixtureDir := filepath.Join(filepath.Dir(callerFile), "_mock_data/TestOneDevDownloadRepo")
mockServer := unittest.NewMockWebServer(t, "https://code.onedev.io", fixtureDir, liveMode)
u, _ := url.Parse(mockServer.URL)
ctx := t.Context()
downloader := NewOneDevDownloader(ctx, u, "", "", "go-gitea-test_repo")
repo, err := downloader.GetRepoInfo(ctx)
assert.NoError(t, err)
assertRepositoryEqual(t, &base.Repository{
Name: "go-gitea-test_repo",
Owner: "",
Description: "Test repository for testing migration from OneDev to gitea",
CloneURL: mockServer.URL + "/go-gitea-test_repo",
OriginalURL: mockServer.URL + "/go-gitea-test_repo",
}, repo)
milestones, err := downloader.GetMilestones(ctx)
assert.NoError(t, err)
deadline := time.Unix(1620086400, 0)
assertMilestonesEqual(t, []*base.Milestone{
{
Title: "1.0.0",
Deadline: &deadline,
Closed: &deadline,
State: "closed",
},
{
Title: "1.1.0",
Description: "next things?",
State: "open",
},
}, milestones)
labels, err := downloader.GetLabels(ctx)
assert.NoError(t, err)
assert.Len(t, labels, 6)
issues, isEnd, err := downloader.GetIssues(ctx, 1, 2)
assert.NoError(t, err)
assert.False(t, isEnd)
assertIssuesEqual(t, []*base.Issue{
{
Number: 4,
Title: "Hi there",
Content: "an issue not assigned to a milestone",
PosterName: "User 336",
State: "open",
Created: time.Unix(1628549776, 734000000),
Updated: time.Unix(1628549776, 734000000),
Labels: []*base.Label{
{
Name: "Improvement",
},
},
ForeignIndex: 398,
Context: onedevIssueContext{IsPullRequest: false},
},
{
Number: 3,
Title: "Add an awesome feature",
Content: "just another issue to test against",
PosterName: "User 336",
State: "open",
Milestone: "1.1.0",
Created: time.Unix(1628549749, 878000000),
Updated: time.Unix(1628549749, 878000000),
Labels: []*base.Label{
{
Name: "New Feature",
},
},
ForeignIndex: 397,
Context: onedevIssueContext{IsPullRequest: false},
},
}, issues)
comments, _, err := downloader.GetComments(ctx, &base.Issue{
Number: 4,
ForeignIndex: 398,
Context: onedevIssueContext{IsPullRequest: false},
})
assert.NoError(t, err)
assertCommentsEqual(t, []*base.Comment{
{
IssueIndex: 4,
PosterID: 336,
PosterName: "User 336",
Created: time.Unix(1628549791, 128000000),
Updated: time.Unix(1628549791, 128000000),
Content: "it has a comment\n\nEDIT: that got edited",
},
}, comments)
prs, _, err := downloader.GetPullRequests(ctx, 1, 1)
assert.NoError(t, err)
assertPullRequestsEqual(t, []*base.PullRequest{
{
Number: 5,
Title: "Pull to add a new file",
Content: "just do some git stuff",
PosterID: 336,
PosterName: "User 336",
State: "open",
Created: time.Unix(1628550076, 25000000),
Updated: time.Unix(1628550076, 25000000),
Head: base.PullRequestBranch{
Ref: "branch-for-a-pull",
SHA: "343deffe3526b9bc84e873743ff7f6e6d8b827c0",
RepoName: "go-gitea-test_repo",
},
Base: base.PullRequestBranch{
Ref: "master",
SHA: "f32b0a9dfd09a60f616f29158f772cedd89942d2",
RepoName: "go-gitea-test_repo",
},
ForeignIndex: 186,
Context: onedevIssueContext{IsPullRequest: true},
},
}, prs)
rvs, err := downloader.GetReviews(ctx, &base.PullRequest{Number: 5, ForeignIndex: 186})
assert.NoError(t, err)
assertReviewsEqual(t, []*base.Review{
{
IssueIndex: 5,
ReviewerID: 317,
ReviewerName: "User 317",
State: "PENDING",
},
}, rvs)
}