mirror of
https://github.com/go-gitea/gitea.git
synced 2026-05-23 05:42:33 +09:00
f2a1271f16
This PR closes remaining `public-only` token gaps in the API by making the restriction apply consistently across repository, organization, activity, notification, and authenticated `/api/v1/user/...` routes. Previously, `public-only` tokens were still able to: - receive private results from some list/search/self endpoints, - access repository data through ID-based lookups, - and reach several authenticated self routes that should remain unavailable for public-only access. This change treats `public-only` as a cross-cutting visibility boundary: - list/search endpoints now filter private resources consistently, - repository lookups enforce the same restriction even when addressed indirectly, - and self routes that inherently expose or mutate private account state now reject `public-only` tokens. --- Generated by a coding agent with Codex 5.2 --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Claude (Opus 4.7) <noreply@anthropic.com>
131 lines
5.5 KiB
Go
131 lines
5.5 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"net/url"
|
|
"strings"
|
|
"testing"
|
|
|
|
auth_model "code.gitea.io/gitea/models/auth"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/json"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
api "code.gitea.io/gitea/modules/structs"
|
|
"code.gitea.io/gitea/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestAPIRepoBranchesPlain(t *testing.T) {
|
|
onGiteaRun(t, func(*testing.T, *url.URL) {
|
|
repo3 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 3})
|
|
user1 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
|
|
session := loginUser(t, user1.LowerName)
|
|
|
|
// public-only token cannot see a private repo
|
|
publicOnlyToken := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopePublicOnly, auth_model.AccessTokenScopeWriteRepository)
|
|
link, _ := url.Parse(fmt.Sprintf("/api/v1/repos/org3/%s/branches", repo3.Name)) // a plain repo
|
|
MakeRequest(t, NewRequest(t, "GET", link.String()).AddTokenAuth(publicOnlyToken), http.StatusNotFound)
|
|
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteRepository)
|
|
resp := MakeRequest(t, NewRequest(t, "GET", link.String()).AddTokenAuth(token), http.StatusOK)
|
|
bs, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
|
|
var branches []*api.Branch
|
|
assert.NoError(t, json.Unmarshal(bs, &branches))
|
|
assert.Len(t, branches, 2)
|
|
assert.Equal(t, "test_branch", branches[0].Name)
|
|
assert.Equal(t, "master", branches[1].Name)
|
|
|
|
link2, _ := url.Parse(fmt.Sprintf("/api/v1/repos/org3/%s/branches/test_branch", repo3.Name))
|
|
MakeRequest(t, NewRequest(t, "GET", link2.String()).AddTokenAuth(publicOnlyToken), http.StatusNotFound)
|
|
|
|
resp = MakeRequest(t, NewRequest(t, "GET", link2.String()).AddTokenAuth(token), http.StatusOK)
|
|
bs, err = io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
var branch api.Branch
|
|
assert.NoError(t, json.Unmarshal(bs, &branch))
|
|
assert.Equal(t, "test_branch", branch.Name)
|
|
|
|
MakeRequest(t, NewRequest(t, "POST", link.String()).AddTokenAuth(publicOnlyToken), http.StatusNotFound)
|
|
|
|
req := NewRequest(t, "POST", link.String()).AddTokenAuth(token)
|
|
req.Header.Add("Content-Type", "application/json")
|
|
req.Body = io.NopCloser(strings.NewReader(`{"new_branch_name":"test_branch2", "old_branch_name": "test_branch", "old_ref_name":"refs/heads/test_branch"}`))
|
|
resp = MakeRequest(t, req, http.StatusCreated)
|
|
bs, err = io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
var branch2 api.Branch
|
|
assert.NoError(t, json.Unmarshal(bs, &branch2))
|
|
assert.Equal(t, "test_branch2", branch2.Name)
|
|
assert.Equal(t, branch.Commit.ID, branch2.Commit.ID)
|
|
|
|
resp = MakeRequest(t, NewRequest(t, "GET", link.String()).AddTokenAuth(token), http.StatusOK)
|
|
bs, err = io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
|
|
branches = []*api.Branch{}
|
|
assert.NoError(t, json.Unmarshal(bs, &branches))
|
|
assert.Len(t, branches, 3)
|
|
assert.Equal(t, "test_branch", branches[0].Name)
|
|
assert.Equal(t, "test_branch2", branches[1].Name)
|
|
assert.Equal(t, "master", branches[2].Name)
|
|
|
|
link3, _ := url.Parse(fmt.Sprintf("/api/v1/repos/org3/%s/branches/test_branch2", repo3.Name))
|
|
MakeRequest(t, NewRequest(t, "DELETE", link3.String()), http.StatusNotFound)
|
|
MakeRequest(t, NewRequest(t, "DELETE", link3.String()).AddTokenAuth(publicOnlyToken), http.StatusNotFound)
|
|
|
|
MakeRequest(t, NewRequest(t, "DELETE", link3.String()).AddTokenAuth(token), http.StatusNoContent)
|
|
assert.NoError(t, err)
|
|
})
|
|
}
|
|
|
|
func TestAPIRepoBranchesMirror(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
repo5 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 5})
|
|
user1 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
|
|
session := loginUser(t, user1.LowerName)
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteRepository)
|
|
|
|
link, _ := url.Parse(fmt.Sprintf("/api/v1/repos/org3/%s/branches", repo5.Name)) // a mirror repo
|
|
resp := MakeRequest(t, NewRequest(t, "GET", link.String()).AddTokenAuth(token), http.StatusOK)
|
|
bs, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
|
|
var branches []*api.Branch
|
|
assert.NoError(t, json.Unmarshal(bs, &branches))
|
|
assert.Len(t, branches, 2)
|
|
assert.Equal(t, "test_branch", branches[0].Name)
|
|
assert.Equal(t, "master", branches[1].Name)
|
|
|
|
link2, _ := url.Parse(fmt.Sprintf("/api/v1/repos/org3/%s/branches/test_branch", repo5.Name))
|
|
resp = MakeRequest(t, NewRequest(t, "GET", link2.String()).AddTokenAuth(token), http.StatusOK)
|
|
bs, err = io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
var branch api.Branch
|
|
assert.NoError(t, json.Unmarshal(bs, &branch))
|
|
assert.Equal(t, "test_branch", branch.Name)
|
|
|
|
req := NewRequest(t, "POST", link.String()).AddTokenAuth(token)
|
|
req.Header.Add("Content-Type", "application/json")
|
|
req.Body = io.NopCloser(strings.NewReader(`{"new_branch_name":"test_branch2", "old_branch_name": "test_branch", "old_ref_name":"refs/heads/test_branch"}`))
|
|
resp = MakeRequest(t, req, http.StatusForbidden)
|
|
bs, err = io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.JSONEq(t, "{\"message\":\"Git Repository is a mirror.\",\"url\":\""+setting.AppURL+"api/swagger\"}", string(bs))
|
|
|
|
resp = MakeRequest(t, NewRequest(t, "DELETE", link2.String()).AddTokenAuth(token), http.StatusForbidden)
|
|
bs, err = io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.JSONEq(t, "{\"message\":\"Git Repository is a mirror.\",\"url\":\""+setting.AppURL+"api/swagger\"}", string(bs))
|
|
}
|