mirror of
https://github.com/go-gitea/gitea.git
synced 2026-11-19 15:14:40 +09:00
Adds audit actions for security-relevant changes that were not logged at all, and records a few remaining events on paths that skipped them: - Account login prohibition (`user:status:prohibitlogin`) and the organization setting that lets repository admins change team access - Actions runner registration tokens issued, runners removed or enabled/disabled, and Actions variables, for every scope - Instance config changes, including maintenance mode (`system:config:update`) - Deploy token regeneration and pull mirror address changes - Review deletion and dismissal, package removal, and release and tag removal - Repository restores via `gitea admin restore-repo`, OAuth2 secret rotation on API update, and SSH keys added or removed by authentication source sync The authentication source SSH key sync moved from the asymkey model to the asymkey service so it can record events. Follow-up to https://github.com/go-gitea/gitea/pull/40317 and https://github.com/go-gitea/gitea/pull/40322. --------- Co-authored-by: silverwind <me@silverwind.io>
187 lines
8.9 KiB
Go
187 lines
8.9 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package user
|
|
|
|
import (
|
|
"testing"
|
|
|
|
audit_model "gitea.dev/models/audit"
|
|
auth_model "gitea.dev/models/auth"
|
|
"gitea.dev/models/unittest"
|
|
user_model "gitea.dev/models/user"
|
|
password_module "gitea.dev/modules/auth/password"
|
|
"gitea.dev/modules/optional"
|
|
"gitea.dev/modules/setting"
|
|
"gitea.dev/modules/structs"
|
|
"gitea.dev/modules/test"
|
|
"gitea.dev/modules/util"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestUpdateUser(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
admin := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
|
|
|
|
assert.Error(t, UpdateUser(t.Context(), admin, &UpdateOptions{
|
|
IsAdmin: UpdateOptionFieldFromValue(false),
|
|
}))
|
|
|
|
assert.NoError(t, UpdateUser(t.Context(), admin, &UpdateOptions{
|
|
IsAdmin: UpdateOptionFieldFromSync(false),
|
|
}))
|
|
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 28})
|
|
|
|
opts := &UpdateOptions{
|
|
KeepEmailPrivate: optional.Some(false),
|
|
FullName: optional.Some("Changed Name"),
|
|
Website: optional.Some("https://gitea.com/"),
|
|
Location: optional.Some("location"),
|
|
Description: optional.Some("description"),
|
|
AllowGitHook: optional.Some(true),
|
|
AllowImportLocal: optional.Some(true),
|
|
MaxRepoCreation: optional.Some(10),
|
|
IsRestricted: optional.Some(true),
|
|
IsActive: optional.Some(false),
|
|
IsAdmin: UpdateOptionFieldFromValue(true),
|
|
Visibility: optional.Some(structs.VisibleTypePrivate),
|
|
KeepActivityPrivate: optional.Some(true),
|
|
Language: optional.Some("lang"),
|
|
Theme: optional.Some("theme"),
|
|
DiffViewStyle: optional.Some("split"),
|
|
AllowCreateOrganization: optional.Some(false),
|
|
EmailNotificationsPreference: optional.Some("disabled"),
|
|
SetLastLogin: true,
|
|
}
|
|
assert.NoError(t, UpdateUser(t.Context(), user, opts))
|
|
|
|
assertUpdatedUser := func(user *user_model.User) {
|
|
assert.Equal(t, opts.KeepEmailPrivate.Value(), user.KeepEmailPrivate)
|
|
assert.Equal(t, opts.FullName.Value(), user.FullName)
|
|
assert.Equal(t, opts.Website.Value(), user.Website)
|
|
assert.Equal(t, opts.Location.Value(), user.Location)
|
|
assert.Equal(t, opts.Description.Value(), user.Description)
|
|
assert.Equal(t, opts.AllowGitHook.Value(), user.AllowGitHook)
|
|
assert.Equal(t, opts.AllowImportLocal.Value(), user.AllowImportLocal)
|
|
assert.Equal(t, opts.MaxRepoCreation.Value(), user.MaxRepoCreation)
|
|
assert.Equal(t, opts.IsRestricted.Value(), user.IsRestricted)
|
|
assert.Equal(t, opts.IsActive.Value(), user.IsActive)
|
|
assert.Equal(t, opts.IsAdmin.Value().FieldValue, user.IsAdmin)
|
|
assert.Equal(t, opts.Visibility.Value(), user.Visibility)
|
|
assert.Equal(t, opts.KeepActivityPrivate.Value(), user.KeepActivityPrivate)
|
|
assert.Equal(t, opts.Language.Value(), user.Language)
|
|
assert.Equal(t, opts.Theme.Value(), user.Theme)
|
|
assert.Equal(t, opts.DiffViewStyle.Value(), user.DiffViewStyle)
|
|
assert.Equal(t, opts.AllowCreateOrganization.Value(), user.AllowCreateOrganization)
|
|
assert.Equal(t, opts.EmailNotificationsPreference.Value(), user.EmailNotificationsPreference)
|
|
}
|
|
assertUpdatedUser(user)
|
|
assertUpdatedUser(unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 28}))
|
|
|
|
defer test.MockVariableValue(&setting.Audit.RecordOutput, setting.AuditRecordOutputDatabase)()
|
|
org := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 3})
|
|
assert.NoError(t, UpdateUser(t.Context(), org, &UpdateOptions{RepoAdminChangeTeamAccess: optional.Some(!org.RepoAdminChangeTeamAccess)}))
|
|
unittest.AssertExistsAndLoadBean(t, &audit_model.Event{Action: audit_model.OrganizationTeamAccess, ScopeType: audit_model.ScopeOrganization, ScopeID: org.ID})
|
|
}
|
|
|
|
func TestUpdateAuth(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 28})
|
|
userCopy := *user
|
|
|
|
assert.NoError(t, UpdateAuth(t.Context(), user, &UpdateAuthOptions{
|
|
LoginName: optional.Some("new-login"),
|
|
}))
|
|
assert.Equal(t, "new-login", user.LoginName)
|
|
|
|
assert.NoError(t, UpdateAuth(t.Context(), user, &UpdateAuthOptions{
|
|
Password: optional.Some("%$DRZUVB576tfzgu"),
|
|
MustChangePassword: optional.Some(true),
|
|
}))
|
|
assert.True(t, user.MustChangePassword)
|
|
assert.NotEqual(t, userCopy.Passwd, user.Passwd)
|
|
assert.NotEqual(t, userCopy.Salt, user.Salt)
|
|
|
|
defer test.MockVariableValue(&setting.Audit.RecordOutput, setting.AuditRecordOutputDatabase)()
|
|
assert.NoError(t, UpdateAuth(t.Context(), user, &UpdateAuthOptions{
|
|
ProhibitLogin: optional.Some(true),
|
|
}))
|
|
assert.True(t, user.ProhibitLogin)
|
|
unittest.AssertExistsAndLoadBean(t, &audit_model.Event{Action: audit_model.UserProhibitLogin, ScopeType: audit_model.ScopeUser, ScopeID: user.ID})
|
|
|
|
assert.ErrorIs(t, UpdateAuth(t.Context(), user, &UpdateAuthOptions{
|
|
Password: optional.Some("aaaa"),
|
|
}), password_module.ErrMinLength)
|
|
}
|
|
|
|
func TestUpdateUserVisibility(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
// user28's current visibility is public, e.g. an account created before public was disallowed
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 28})
|
|
assert.Equal(t, structs.VisibleTypePublic, user.Visibility)
|
|
|
|
// public is no longer an allowed visibility mode, e.g. ALLOWED_USER_VISIBILITY_MODES = limited, private
|
|
defer test.MockVariableValue(&setting.Service.AllowedUserVisibilityModesSlice, setting.AllowedVisibility{false, true, true})()
|
|
|
|
// re-submitting the unchanged (now-disallowed) visibility must not fail the whole update
|
|
assert.NoError(t, UpdateUser(t.Context(), user, &UpdateOptions{
|
|
FullName: optional.Some("Changed Name"),
|
|
Visibility: optional.Some(structs.VisibleTypePublic),
|
|
}))
|
|
assert.Equal(t, "Changed Name", user.FullName)
|
|
assert.Equal(t, structs.VisibleTypePublic, user.Visibility)
|
|
|
|
// changing to an allowed visibility still works
|
|
assert.NoError(t, UpdateUser(t.Context(), user, &UpdateOptions{
|
|
Visibility: optional.Some(structs.VisibleTypePrivate),
|
|
}))
|
|
assert.Equal(t, structs.VisibleTypePrivate, user.Visibility)
|
|
|
|
// genuinely changing to a disallowed visibility is still rejected
|
|
assert.Error(t, UpdateUser(t.Context(), user, &UpdateOptions{
|
|
Visibility: optional.Some(structs.VisibleTypePublic),
|
|
}))
|
|
}
|
|
|
|
func TestConvertUserType(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
before := *user
|
|
tokensBefore := unittest.GetCount(t, &auth_model.AccessToken{UID: user.ID})
|
|
assert.NotEmpty(t, before.Passwd)
|
|
assert.Positive(t, tokensBefore)
|
|
|
|
defer test.MockVariableValue(&setting.Audit.RecordOutput, setting.AuditRecordOutputDatabase)()
|
|
assert.NoError(t, UpdateUser(t.Context(), user, &UpdateOptions{UserType: optional.Some(user_model.UserTypeBot)}))
|
|
assert.True(t, user.IsTypeBot())
|
|
unittest.AssertExistsAndLoadBean(t, &audit_model.Event{Action: audit_model.UserType, ScopeType: audit_model.ScopeUser, ScopeID: user.ID})
|
|
|
|
user = unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
before.Type, before.UpdatedUnix = user_model.UserTypeBot, user.UpdatedUnix
|
|
assert.Equal(t, before, *user)
|
|
assert.Equal(t, tokensBefore, unittest.GetCount(t, &auth_model.AccessToken{UID: user.ID}))
|
|
|
|
assert.ErrorIs(t, UpdateAuth(t.Context(), user, &UpdateAuthOptions{Password: optional.Some("%$DRZUVB576tfzgu")}), util.ErrInvalidArgument)
|
|
assert.ErrorIs(t, UpdateAuth(t.Context(), user, &UpdateAuthOptions{LoginSource: optional.Some(int64(1))}), util.ErrInvalidArgument)
|
|
assert.ErrorIs(t, UpdateAuth(t.Context(), user, &UpdateAuthOptions{LoginName: optional.Some("cn=bot")}), util.ErrInvalidArgument)
|
|
assert.ErrorIs(t, UpdateUser(t.Context(), user, &UpdateOptions{IsAdmin: UpdateOptionFieldFromValue(true)}), user_model.ErrBotCanNotBeAdmin)
|
|
assert.False(t, unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2}).IsAdmin)
|
|
|
|
user = unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
assert.NoError(t, UpdateUser(t.Context(), user, &UpdateOptions{UserType: optional.Some(user_model.UserTypeIndividual)}))
|
|
assert.True(t, unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2}).IsIndividual())
|
|
|
|
toBot := &UpdateOptions{UserType: optional.Some(user_model.UserTypeBot)}
|
|
assert.ErrorIs(t, UpdateUser(t.Context(), unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 3}), toBot), user_model.ErrUserTypeCanNotConvert)
|
|
assert.ErrorIs(t, UpdateUser(t.Context(), unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1}), toBot), user_model.ErrBotCanNotBeAdmin)
|
|
assert.True(t, unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1}).IsIndividual())
|
|
assert.NoError(t, user_model.UpdateUserCols(t.Context(), &user_model.User{ID: 4, LoginType: auth_model.LDAP}, "login_type"))
|
|
assert.ErrorIs(t, UpdateUser(t.Context(), unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 4}), toBot), user_model.ErrBotMustBeLocal)
|
|
}
|