mirror of
https://github.com/go-gitea/gitea.git
synced 2026-10-26 06:16:56 +09:00
ae17c14cff
Several handlers and model helpers skipped checks that their siblings already perform. - Only match principal keys when looking up SSH certificate principals - Return no attachments for an unsaved issue instead of every issue-less one - Reject issue and comment attachments when adding release attachments - Share one permission check for editing, deleting and reacting to issue content and for comment attachments between the web UI and the API, refusing them on locked issues for users who can't write - Reject issue edits, deletion and label changes in archived repositories via the API - Apply cross-origin protection to the repository topics endpoint - Return 404 for the repositories tab of individual users and respect profile visibility for the heatmap Fixes: https://github.com/go-gitea/gitea/issues/39226 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: bircni <bircni@icloud.com>
90 lines
2.8 KiB
Go
90 lines
2.8 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"net/http"
|
|
"net/url"
|
|
"testing"
|
|
|
|
api "gitea.dev/modules/structs"
|
|
"gitea.dev/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestRepoTopicsPostRejectsCrossOrigin(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
session := loginUser(t, "user2")
|
|
|
|
req := NewRequestWithValues(t, "POST", "/user2/repo1/topics", map[string]string{"topics": "cross"}).
|
|
SetHeader("Sec-Fetch-Site", "cross-site")
|
|
session.MakeRequest(t, req, http.StatusForbidden)
|
|
|
|
req = NewRequestWithValues(t, "POST", "/user2/repo1/topics", map[string]string{"topics": "same"}).
|
|
SetHeader("Sec-Fetch-Site", "same-origin")
|
|
session.MakeRequest(t, req, http.StatusOK)
|
|
}
|
|
|
|
func TestTopicSearch(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
searchURL, _ := url.Parse("/explore/topics/search")
|
|
|
|
// search all topics
|
|
res := MakeRequest(t, NewRequest(t, "GET", searchURL.String()), http.StatusOK)
|
|
topics := DecodeJSON(t, res, &struct {
|
|
TopicNames []*api.TopicResponse `json:"topics"`
|
|
}{})
|
|
assert.Len(t, topics.TopicNames, 6)
|
|
assert.Equal(t, "6", res.Header().Get("x-total-count"))
|
|
|
|
// pagination search topics
|
|
topics.TopicNames = nil
|
|
query := url.Values{"page": []string{"1"}, "limit": []string{"4"}}
|
|
|
|
searchURL.RawQuery = query.Encode()
|
|
res = MakeRequest(t, NewRequest(t, "GET", searchURL.String()), http.StatusOK)
|
|
topics = DecodeJSON(t, res, &struct {
|
|
TopicNames []*api.TopicResponse `json:"topics"`
|
|
}{})
|
|
assert.Len(t, topics.TopicNames, 4)
|
|
assert.Equal(t, "6", res.Header().Get("x-total-count"))
|
|
|
|
// second page
|
|
topics.TopicNames = nil
|
|
query = url.Values{"page": []string{"2"}, "limit": []string{"4"}}
|
|
|
|
searchURL.RawQuery = query.Encode()
|
|
res = MakeRequest(t, NewRequest(t, "GET", searchURL.String()), http.StatusOK)
|
|
topics = DecodeJSON(t, res, &struct {
|
|
TopicNames []*api.TopicResponse `json:"topics"`
|
|
}{})
|
|
assert.Len(t, topics.TopicNames, 2)
|
|
assert.Equal(t, "6", res.Header().Get("x-total-count"))
|
|
|
|
// add keyword search
|
|
topics.TopicNames = nil
|
|
query = url.Values{"page": []string{"1"}, "limit": []string{"4"}}
|
|
query.Add("q", "topic")
|
|
searchURL.RawQuery = query.Encode()
|
|
res = MakeRequest(t, NewRequest(t, "GET", searchURL.String()), http.StatusOK)
|
|
topics = DecodeJSON(t, res, &struct {
|
|
TopicNames []*api.TopicResponse `json:"topics"`
|
|
}{})
|
|
assert.Len(t, topics.TopicNames, 2)
|
|
|
|
topics.TopicNames = nil
|
|
query.Set("q", "database")
|
|
searchURL.RawQuery = query.Encode()
|
|
res = MakeRequest(t, NewRequest(t, "GET", searchURL.String()), http.StatusOK)
|
|
topics = DecodeJSON(t, res, &struct {
|
|
TopicNames []*api.TopicResponse `json:"topics"`
|
|
}{})
|
|
if assert.Len(t, topics.TopicNames, 1) {
|
|
assert.EqualValues(t, 2, topics.TopicNames[0].ID)
|
|
assert.Equal(t, "database", topics.TopicNames[0].Name)
|
|
assert.Equal(t, 1, topics.TopicNames[0].RepoCount)
|
|
}
|
|
}
|