mirror of
https://github.com/go-gitea/gitea.git
synced 2025-10-27 00:23:41 +09:00
6d0b24064a
Extract from #34531 ## Move Commit status state to a standalone package Move the state from `structs` to `commitstatus` package. It also introduce `CommitStatusStates` so that the combine function could be used from UI and API logic. ## Combined commit status Changed This PR will follow Github's combined commit status. Before this PR, every commit status could be a combined one. According to https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#get-the-combined-status-for-a-specific-reference > Additionally, a combined state is returned. The state is one of: > failure if any of the contexts report as error or failure > pending if there are no statuses or a context is pending > success if the latest status for all contexts is success This PR will follow that rule and remove the `NoBetterThan` logic. This also fixes the inconsistent between UI and API. In the API convert package, it has implemented this which is different from the UI. It also fixed the missing `URL` and `CommitURL` in the API. ## `CalcCommitStatus` return nil if there is no commit statuses The behavior of `CalcCommitStatus` is changed. If the parameter commit statuses is empty, it will return nil. The reference places should check the returned value themselves.
93 lines
2.9 KiB
Go
93 lines
2.9 KiB
Go
// Copyright 2024 Gitea. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package git
|
|
|
|
import (
|
|
"context"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
"code.gitea.io/gitea/modules/commitstatus"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
|
|
"xorm.io/builder"
|
|
)
|
|
|
|
// CommitStatusSummary holds the latest commit Status of a single Commit
|
|
type CommitStatusSummary struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
RepoID int64 `xorm:"INDEX UNIQUE(repo_id_sha)"`
|
|
SHA string `xorm:"VARCHAR(64) NOT NULL INDEX UNIQUE(repo_id_sha)"`
|
|
State commitstatus.CommitStatusState `xorm:"VARCHAR(7) NOT NULL"`
|
|
TargetURL string `xorm:"TEXT"`
|
|
}
|
|
|
|
func init() {
|
|
db.RegisterModel(new(CommitStatusSummary))
|
|
}
|
|
|
|
type RepoSHA struct {
|
|
RepoID int64
|
|
SHA string
|
|
}
|
|
|
|
func GetLatestCommitStatusForRepoAndSHAs(ctx context.Context, repoSHAs []RepoSHA) ([]*CommitStatus, error) {
|
|
cond := builder.NewCond()
|
|
for _, rs := range repoSHAs {
|
|
cond = cond.Or(builder.Eq{"repo_id": rs.RepoID, "sha": rs.SHA})
|
|
}
|
|
|
|
var summaries []CommitStatusSummary
|
|
if err := db.GetEngine(ctx).Where(cond).Find(&summaries); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
commitStatuses := make([]*CommitStatus, 0, len(repoSHAs))
|
|
for _, summary := range summaries {
|
|
commitStatuses = append(commitStatuses, &CommitStatus{
|
|
RepoID: summary.RepoID,
|
|
SHA: summary.SHA,
|
|
State: summary.State,
|
|
TargetURL: summary.TargetURL,
|
|
})
|
|
}
|
|
return commitStatuses, nil
|
|
}
|
|
|
|
func UpdateCommitStatusSummary(ctx context.Context, repoID int64, sha string) error {
|
|
commitStatuses, err := GetLatestCommitStatus(ctx, repoID, sha, db.ListOptionsAll)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
// it guarantees that commitStatuses is not empty because this function is always called after a commit status is created
|
|
if len(commitStatuses) == 0 {
|
|
setting.PanicInDevOrTesting("no commit statuses found for repo %d and sha %s", repoID, sha)
|
|
}
|
|
state := CalcCommitStatus(commitStatuses) // non-empty commitStatuses is guaranteed
|
|
// mysql will return 0 when update a record which state hasn't been changed which behaviour is different from other database,
|
|
// so we need to use insert in on duplicate
|
|
if setting.Database.Type.IsMySQL() {
|
|
_, err := db.GetEngine(ctx).Exec("INSERT INTO commit_status_summary (repo_id,sha,state,target_url) VALUES (?,?,?,?) ON DUPLICATE KEY UPDATE state=?",
|
|
repoID, sha, state.State, state.TargetURL, state.State)
|
|
return err
|
|
}
|
|
|
|
if cnt, err := db.GetEngine(ctx).Where("repo_id=? AND sha=?", repoID, sha).
|
|
Cols("state, target_url").
|
|
Update(&CommitStatusSummary{
|
|
State: state.State,
|
|
TargetURL: state.TargetURL,
|
|
}); err != nil {
|
|
return err
|
|
} else if cnt == 0 {
|
|
_, err = db.GetEngine(ctx).Insert(&CommitStatusSummary{
|
|
RepoID: repoID,
|
|
SHA: sha,
|
|
State: state.State,
|
|
TargetURL: state.TargetURL,
|
|
})
|
|
return err
|
|
}
|
|
return nil
|
|
}
|