mirror of
https://github.com/go-gitea/gitea.git
synced 2026-11-02 13:44:16 +09:00
5a3f06430d
Backport https://github.com/go-gitea/gitea/pull/39945 API tokens and Actions task tokens could see data beyond their scope through user-scoped API routes and web profile pages. - Actions task tokens authenticate as a shared system user with a negative ID, which org, project and SSH/GPG key filters treated as "no owner filter". These filters now check `!= 0`, so system users own nothing. The `/api/v1/user` routes except `GET /api/v1/user` only accept individual and bot accounts, and repo search no longer skips access checks for the owner. - `/{username}` only accepts tokens for RSS/Atom feeds. HTML profile and org pages render as anonymous for token requests. - User and org feeds require `read:user` or `read:organization` from tokens, the same way repo feeds require `read:repository`. `release/v28` lacks https://github.com/go-gitea/gitea/pull/39967, so `/{username}` enables basic auth only for feed requests through a middleware. The profile page token tests from https://github.com/go-gitea/gitea/pull/39853 are folded into `TestFeedUser`, because profile pages no longer accept tokens. Co-authored-by: bircni <bircni@icloud.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>
66 lines
2.4 KiB
Go
66 lines
2.4 KiB
Go
// Copyright 2025 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"gitea.dev/modules/setting"
|
|
api "gitea.dev/modules/structs"
|
|
"gitea.dev/modules/test"
|
|
"gitea.dev/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func testActionUserSignIn(t *testing.T) {
|
|
req := NewRequest(t, "GET", "/api/v1/user").
|
|
AddTokenAuth("8061e833a55f6fc0157c98b883e91fcfeeb1a71a")
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
u := DecodeJSON(t, resp, &api.User{})
|
|
assert.Equal(t, "gitea-actions", u.UserName)
|
|
}
|
|
|
|
func testActionUserOwnsNothing(t *testing.T) {
|
|
const token = "8061e833a55f6fc0157c98b883e91fcfeeb1a71a"
|
|
for _, link := range []string{"/api/v1/user/repos", "/api/v1/user/orgs", "/api/v1/user/actions/runs"} {
|
|
MakeRequest(t, NewRequest(t, "GET", link).AddTokenAuth(token), http.StatusForbidden)
|
|
}
|
|
for _, link := range []string{"/api/v1/users/gitea-actions/orgs", "/api/v1/users/gitea-actions/keys"} {
|
|
assert.JSONEq(t, "[]", MakeRequest(t, NewRequest(t, "GET", link).AddTokenAuth(token), http.StatusOK).Body.String(), link)
|
|
}
|
|
assert.NotContains(t, MakeRequest(t, NewRequest(t, "GET", "/api/v1/repos/search?uid=-2").AddTokenAuth(token), http.StatusOK).Body.String(), `"private":true`)
|
|
}
|
|
|
|
func testActionUserAccessPublicRepo(t *testing.T) {
|
|
req := NewRequestf(t, "GET", "/api/v1/repos/user2/repo1/raw/README.md").
|
|
AddTokenAuth("8061e833a55f6fc0157c98b883e91fcfeeb1a71a")
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
assert.Equal(t, "file", resp.Header().Get("x-gitea-object-type"))
|
|
|
|
defer test.MockVariableValue(&setting.Service.RequireSignInViewStrict, true)()
|
|
|
|
req = NewRequestf(t, "GET", "/api/v1/repos/user2/repo1/raw/README.md").
|
|
AddTokenAuth("8061e833a55f6fc0157c98b883e91fcfeeb1a71a")
|
|
resp = MakeRequest(t, req, http.StatusOK)
|
|
assert.Equal(t, "file", resp.Header().Get("x-gitea-object-type"))
|
|
}
|
|
|
|
func testActionUserNoAccessOtherPrivateRepo(t *testing.T) {
|
|
req := NewRequestf(t, "GET", "/api/v1/repos/user2/repo2/raw/README.md").
|
|
AddTokenAuth("8061e833a55f6fc0157c98b883e91fcfeeb1a71a")
|
|
MakeRequest(t, req, http.StatusNotFound)
|
|
}
|
|
|
|
func TestActionUserAccessPermission(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
t.Run("ActionUserSignIn", testActionUserSignIn)
|
|
t.Run("ActionUserOwnsNothing", testActionUserOwnsNothing)
|
|
t.Run("ActionUserAccessPublicRepo", testActionUserAccessPublicRepo)
|
|
t.Run("ActionUserNoAccessOtherPrivateRepo", testActionUserNoAccessOtherPrivateRepo)
|
|
}
|