mirror of
https://github.com/go-gitea/gitea.git
synced 2026-10-26 06:16:56 +09:00
Shivansh Gargandwxiaoguang
f270534e83
1. Fixes: https://github.com/go-gitea/gitea/issues/39641 * The OAuth2 authorize/grant endpoint accepted and persisted arbitrary scope strings without validation, unlike personal access token creation which rejects unknown scopes. Normalize and validate form.Scope before creating or updating a grant, ignore invalid scopes * `// TODO: at the moment invalid tokens are treated as "all" to avoid breaking 1.22 behavior` is fixed. 2. To avoid CSRF attack for OpenID endpoint, add a state check --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
44 lines
1.4 KiB
Go
44 lines
1.4 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package oauth2_provider
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestGrantAdditionalScopes(t *testing.T) {
|
|
tests := []struct {
|
|
grantScopes string
|
|
expectedScopes string
|
|
}{
|
|
{"", "all"}, // for old tokens without scope, treat it as "all"
|
|
{"openid profile email", "all"},
|
|
{"openid profile email groups", "all"},
|
|
{"openid profile email all", "all"},
|
|
{"openid profile email read:user all", "all"},
|
|
{"openid profile email groups read:user", "read:user"},
|
|
{"read:user read:repository", "read:repository,read:user"},
|
|
{"read:user write:issue public-only", "public-only,write:issue,read:user"},
|
|
{"openid profile email read:user", "read:user"},
|
|
{"no-token-scope", "no-token-scope"},
|
|
{"openid no-token-scope", "no-token-scope"},
|
|
{"no-token-scope read:user", "read:user"},
|
|
{"read:invalid_scope", "no-token-scope"},
|
|
{"read:invalid_scope,write:scope_invalid,just-plain-wrong", "no-token-scope"},
|
|
{"openid invalid:scope", "no-token-scope"},
|
|
{"openid ,,", "no-token-scope"},
|
|
{"read:user invalid:scope", "read:user"},
|
|
{"read:user,invalid:scope public-only", "public-only,read:user"},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run("scope:"+test.grantScopes, func(t *testing.T) {
|
|
result := GrantAdditionalScopes(test.grantScopes)
|
|
assert.Equal(t, test.expectedScopes, string(result))
|
|
})
|
|
}
|
|
}
|