mirror of
https://github.com/go-gitea/gitea.git
synced 2026-10-26 06:16:56 +09:00
Alisa Lafoksandwxiaoguang
c501255d47
* Fixes #39746 * Fixes #35505 The click handlers were bound only to the first `.reference-list-menu` (branches), so clicking a tag did nothing. Bind them to the items of both lists. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
67 lines
3.7 KiB
Handlebars
67 lines
3.7 KiB
Handlebars
{{/* TODO: ISSUE-SIDEBAR-REF-SELECTOR: Although we proposed to remove the Issue.Ref,
|
|
> The Issue.Ref was added by Add possibility to record branch or tag information in an issue (#780)
|
|
> After 8 years, this "branch selector" does nothing more than saving the branch/tag name into database and displays it,
|
|
> or sometimes auto-close a ref-matched issue by a commit message when CloseIssuesViaCommitInAnyBranch=false.
|
|
|
|
Actually, there are still enough real users who are interested in it:
|
|
* @didim99: it is a really useful feature to specify a branch in which issue found (also: https://github.com/go-gitea/gitea/pull/32744)
|
|
* @AliceLafox: https://github.com/go-gitea/gitea/issues/39746
|
|
* @mscott-smartuq, @r10r, @@chklemenz, @Smithor, @@JanJurik: https://github.com/go-gitea/gitea/issues/35505
|
|
* Forum: https://forum.gitea.com/t/alternative-to-github-for-reporting-bugs/11684
|
|
So we still keep it and mainain it.
|
|
|
|
Still needs to figure out:
|
|
* Could the "recording branch/tag name" be replaced by other approaches?
|
|
* Write the branch name in the issue title/body then it will still be displayed, eg: `[bug] (fix/ui-broken-bug) there is a bug ....`
|
|
* Is "GitHub-like development sidebar (`#31899`)" good enough (or better) for your usage?
|
|
*/}}
|
|
{{if and (not .Issue.IsPull) (not .PageIsComparePull)}}
|
|
{{$canChangeRef := or .IsIssuePoster .HasIssuesOrPullsWritePermission}}
|
|
<input id="ref_selector" name="ref" type="hidden" value="{{.Reference}}">
|
|
<div class="ui dropdown select-branch branch-selector-dropdown ellipsis-text-items {{if not $canChangeRef}}disabled{{end}}"
|
|
data-no-results="{{ctx.Locale.Tr "no_results_found"}}"
|
|
{{if and .Issue $canChangeRef}}data-url-update-issueref="{{$.RepoLink}}/issues/{{.Issue.Index}}/ref"{{end}}
|
|
>
|
|
<div class="ui button branch-dropdown-button">
|
|
<span class="text-branch-name gt-ellipsis">{{if .Reference}}{{$.RefEndName}}{{else}}{{ctx.Locale.Tr "repo.issues.no_ref"}}{{end}}</span>
|
|
{{if $canChangeRef}}{{svg "octicon-triangle-down" 14 "dropdown icon"}}{{end}}
|
|
</div>
|
|
<div class="menu">
|
|
<div class="ui icon search input">
|
|
<i class="icon">{{svg "octicon-filter" 16}}</i>
|
|
<input name="search" placeholder="{{ctx.Locale.Tr "repo.filter_branch_and_tag"}}...">
|
|
</div>
|
|
<div class="branch-tag-tab">
|
|
<button type="button" class="btn branch-tag-item reference column active" data-target="#branch-list">
|
|
{{svg "octicon-git-branch" 16 "tw-mr-1"}} {{ctx.Locale.Tr "repo.branches"}}
|
|
</button>
|
|
<button type="button" class="btn branch-tag-item reference column" data-target="#tag-list">
|
|
{{svg "octicon-tag" 16 "tw-mr-1"}} {{ctx.Locale.Tr "repo.tags"}}
|
|
</button>
|
|
</div>
|
|
<div class="branch-tag-divider"></div>
|
|
<div id="branch-list" class="scrolling menu reference-list-menu">
|
|
{{if or .Reference (not .Issue)}}
|
|
<div class="item tw-text-xs" data-id="" data-name="{{ctx.Locale.Tr "repo.issues.no_ref"}}" data-id-selector="#ref_selector"><strong>{{ctx.Locale.Tr "repo.clear_ref"}}</strong></div>
|
|
{{end}}
|
|
{{range .Branches}}
|
|
<div class="item" data-id="refs/heads/{{.}}" data-name="{{.}}" data-id-selector="#ref_selector" title="{{.}}">{{.}}</div>
|
|
{{else}}
|
|
<div class="item disabled">{{ctx.Locale.Tr "no_results_found"}}</div>
|
|
{{end}}
|
|
</div>
|
|
<div id="tag-list" class="scrolling menu reference-list-menu tw-hidden">
|
|
{{if or .Reference (not .Issue)}}
|
|
<div class="item tw-text-xs" data-id="" data-name="{{ctx.Locale.Tr "repo.issues.no_ref"}}" data-id-selector="#ref_selector"><strong>{{ctx.Locale.Tr "repo.clear_ref"}}</strong></div>
|
|
{{end}}
|
|
{{range .Tags}}
|
|
<div class="item" data-id="refs/tags/{{.}}" data-name="tags/{{.}}" data-id-selector="#ref_selector">{{.}}</div>
|
|
{{else}}
|
|
<div class="item disabled">{{ctx.Locale.Tr "no_results_found"}}</div>
|
|
{{end}}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<div class="divider"></div>
|
|
{{end}}
|