mirror of
https://github.com/go-gitea/gitea.git
synced 2026-10-26 06:16:56 +09:00
silverwind
8abda62312
Consolidate all Go tests. Coverage is identical to before. Go tests are around 5% faster while being 7% smaller. No non-test code is touched.
257 lines
11 KiB
Go
257 lines
11 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package access
|
|
|
|
import (
|
|
"testing"
|
|
|
|
actions_model "gitea.dev/models/actions"
|
|
"gitea.dev/models/db"
|
|
"gitea.dev/models/organization"
|
|
perm_model "gitea.dev/models/perm"
|
|
repo_model "gitea.dev/models/repo"
|
|
"gitea.dev/models/unit"
|
|
"gitea.dev/models/unittest"
|
|
user_model "gitea.dev/models/user"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestHasAnyUnitAccess(t *testing.T) {
|
|
perm := Permission{}
|
|
assert.False(t, perm.HasAnyUnitAccess())
|
|
|
|
perm = Permission{
|
|
units: []*repo_model.RepoUnit{{Type: unit.TypeWiki}},
|
|
}
|
|
assert.False(t, perm.HasAnyUnitAccess())
|
|
assert.False(t, perm.HasAnyUnitAccessOrPublicAccess())
|
|
|
|
perm = Permission{
|
|
units: []*repo_model.RepoUnit{{Type: unit.TypeWiki}},
|
|
everyoneAccessMode: map[unit.Type]perm_model.AccessMode{unit.TypeIssues: perm_model.AccessModeRead},
|
|
}
|
|
assert.False(t, perm.HasAnyUnitAccess())
|
|
assert.True(t, perm.HasAnyUnitAccessOrPublicAccess())
|
|
|
|
perm = Permission{
|
|
units: []*repo_model.RepoUnit{{Type: unit.TypeWiki}},
|
|
anonymousAccessMode: map[unit.Type]perm_model.AccessMode{unit.TypeIssues: perm_model.AccessModeRead},
|
|
}
|
|
assert.False(t, perm.HasAnyUnitAccess())
|
|
assert.True(t, perm.HasAnyUnitAccessOrPublicAccess())
|
|
|
|
perm = Permission{
|
|
AccessMode: perm_model.AccessModeRead,
|
|
units: []*repo_model.RepoUnit{{Type: unit.TypeWiki}},
|
|
}
|
|
assert.True(t, perm.HasAnyUnitAccess())
|
|
|
|
perm = Permission{
|
|
unitsMode: map[unit.Type]perm_model.AccessMode{unit.TypeWiki: perm_model.AccessModeRead},
|
|
}
|
|
assert.True(t, perm.HasAnyUnitAccess())
|
|
}
|
|
|
|
func TestApplyPublicAccessRepoPermission(t *testing.T) {
|
|
for _, test := range []struct {
|
|
user *user_model.User
|
|
repoUnit *repo_model.RepoUnit
|
|
assertRead assert.BoolAssertionFunc
|
|
}{
|
|
{nil, &repo_model.RepoUnit{Type: unit.TypeWiki, EveryoneAccessMode: perm_model.AccessModeRead}, assert.False},
|
|
{nil, &repo_model.RepoUnit{Type: unit.TypeWiki, AnonymousAccessMode: perm_model.AccessModeRead}, assert.True},
|
|
{&user_model.User{ID: 0}, &repo_model.RepoUnit{Type: unit.TypeWiki, EveryoneAccessMode: perm_model.AccessModeRead}, assert.False},
|
|
{&user_model.User{ID: 1}, &repo_model.RepoUnit{Type: unit.TypeWiki, EveryoneAccessMode: perm_model.AccessModeRead}, assert.True},
|
|
} {
|
|
perm := Permission{
|
|
AccessMode: perm_model.AccessModeNone,
|
|
units: []*repo_model.RepoUnit{test.repoUnit},
|
|
}
|
|
finalProcessRepoUnitPermission(test.user, &perm)
|
|
test.assertRead(t, perm.CanRead(unit.TypeWiki))
|
|
}
|
|
|
|
perm := Permission{
|
|
AccessMode: perm_model.AccessModeWrite,
|
|
units: []*repo_model.RepoUnit{
|
|
{Type: unit.TypeWiki, EveryoneAccessMode: perm_model.AccessModeRead},
|
|
},
|
|
}
|
|
finalProcessRepoUnitPermission(&user_model.User{ID: 1}, &perm)
|
|
// it should work the same as "EveryoneAccessMode: none" because the default AccessMode should be applied to units
|
|
assert.True(t, perm.CanWrite(unit.TypeWiki))
|
|
|
|
perm = Permission{
|
|
units: []*repo_model.RepoUnit{
|
|
{Type: unit.TypeCode}, // will be removed
|
|
{Type: unit.TypeWiki, EveryoneAccessMode: perm_model.AccessModeRead},
|
|
},
|
|
unitsMode: map[unit.Type]perm_model.AccessMode{
|
|
unit.TypeWiki: perm_model.AccessModeWrite,
|
|
},
|
|
}
|
|
finalProcessRepoUnitPermission(&user_model.User{ID: 1}, &perm)
|
|
assert.True(t, perm.CanWrite(unit.TypeWiki))
|
|
assert.Len(t, perm.units, 1)
|
|
}
|
|
|
|
func TestUnitAccessMode(t *testing.T) {
|
|
for _, test := range []struct {
|
|
accessMode perm_model.AccessMode
|
|
hasUnit, hasMap bool
|
|
expected perm_model.AccessMode
|
|
message string
|
|
}{
|
|
{perm_model.AccessModeNone, false, false, perm_model.AccessModeNone, "no unit, no map, use AccessMode"},
|
|
{perm_model.AccessModeRead, true, false, perm_model.AccessModeRead, "only unit, no map, use AccessMode"},
|
|
{perm_model.AccessModeAdmin, false, true, perm_model.AccessModeAdmin, "no unit, only map, admin overrides map"},
|
|
{perm_model.AccessModeNone, false, true, perm_model.AccessModeRead, "no unit, only map, use map"},
|
|
{perm_model.AccessModeNone, true, true, perm_model.AccessModeRead, "has unit, and map, use map"},
|
|
} {
|
|
perm := Permission{AccessMode: test.accessMode}
|
|
if test.hasUnit {
|
|
perm.units = []*repo_model.RepoUnit{{Type: unit.TypeWiki}}
|
|
}
|
|
if test.hasMap {
|
|
perm.unitsMode = map[unit.Type]perm_model.AccessMode{unit.TypeWiki: perm_model.AccessModeRead}
|
|
}
|
|
assert.Equal(t, test.expected, perm.UnitAccessMode(unit.TypeWiki), test.message)
|
|
}
|
|
}
|
|
|
|
func TestGetRepoPermission(t *testing.T) {
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
t.Run("GetIndividualUserRepoPermission", testGetIndividualUserRepoPermission)
|
|
t.Run("GetDoerRepoPermission", testGetDoerRepoPermission)
|
|
}
|
|
|
|
func testGetIndividualUserRepoPermission(t *testing.T) {
|
|
ctx := t.Context()
|
|
repo32 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 32}) // org public repo
|
|
require.NoError(t, repo32.LoadOwner(ctx))
|
|
require.True(t, repo32.Owner.IsOrganization())
|
|
|
|
require.NoError(t, db.TruncateBeans(ctx, &organization.Team{}, &organization.TeamUser{}, &organization.TeamRepo{}, &organization.TeamUnit{}))
|
|
org := repo32.Owner
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 4})
|
|
team := &organization.Team{OrgID: org.ID, LowerName: "test_team"}
|
|
require.NoError(t, db.Insert(ctx, team))
|
|
require.NoError(t, db.Insert(ctx, &organization.TeamUser{OrgID: org.ID, TeamID: team.ID, UID: user.ID}))
|
|
|
|
t.Run("DoerInTeamWithNoRepo", func(t *testing.T) {
|
|
perm, err := GetIndividualUserRepoPermission(ctx, repo32, user)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, perm_model.AccessModeRead, perm.AccessMode)
|
|
assert.Nil(t, perm.unitsMode) // doer in the team, but has no access to the repo
|
|
})
|
|
|
|
require.NoError(t, db.Insert(ctx, &organization.TeamRepo{OrgID: org.ID, TeamID: team.ID, RepoID: repo32.ID}))
|
|
require.NoError(t, db.Insert(ctx, &organization.TeamUnit{OrgID: org.ID, TeamID: team.ID, Type: unit.TypeCode, AccessMode: perm_model.AccessModeNone}))
|
|
t.Run("DoerWithTeamUnitAccessNone", func(t *testing.T) {
|
|
perm, err := GetIndividualUserRepoPermission(ctx, repo32, user)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, perm_model.AccessModeRead, perm.AccessMode)
|
|
assert.Equal(t, perm_model.AccessModeRead, perm.unitsMode[unit.TypeCode])
|
|
assert.Equal(t, perm_model.AccessModeRead, perm.unitsMode[unit.TypeIssues])
|
|
})
|
|
|
|
require.NoError(t, db.TruncateBeans(ctx, &organization.TeamUnit{}))
|
|
require.NoError(t, db.Insert(ctx, &organization.TeamUnit{OrgID: org.ID, TeamID: team.ID, Type: unit.TypeCode, AccessMode: perm_model.AccessModeWrite}))
|
|
t.Run("DoerWithTeamUnitAccessWrite", func(t *testing.T) {
|
|
perm, err := GetIndividualUserRepoPermission(ctx, repo32, user)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, perm_model.AccessModeRead, perm.AccessMode)
|
|
assert.Equal(t, perm_model.AccessModeWrite, perm.unitsMode[unit.TypeCode])
|
|
assert.Equal(t, perm_model.AccessModeRead, perm.unitsMode[unit.TypeIssues])
|
|
})
|
|
|
|
repo3 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 3}) // org private repo, same org as repo 32
|
|
require.NoError(t, repo3.LoadOwner(ctx))
|
|
require.True(t, repo3.Owner.IsOrganization())
|
|
require.NoError(t, db.TruncateBeans(ctx, &organization.TeamUnit{}, &Access{})) // The user has access set of that repo, remove it, it is useless for our test
|
|
require.NoError(t, db.Insert(ctx, &organization.TeamRepo{OrgID: org.ID, TeamID: team.ID, RepoID: repo3.ID}))
|
|
t.Run("DoerWithNoopTeamOnPrivateRepo", func(t *testing.T) {
|
|
perm, err := GetIndividualUserRepoPermission(ctx, repo3, user)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, perm_model.AccessModeNone, perm.AccessMode)
|
|
assert.Equal(t, perm_model.AccessModeNone, perm.unitsMode[unit.TypeCode])
|
|
assert.Equal(t, perm_model.AccessModeNone, perm.unitsMode[unit.TypeIssues])
|
|
})
|
|
|
|
require.NoError(t, db.Insert(ctx, &organization.TeamUnit{OrgID: org.ID, TeamID: team.ID, Type: unit.TypeCode, AccessMode: perm_model.AccessModeNone}))
|
|
require.NoError(t, db.Insert(ctx, &organization.TeamUnit{OrgID: org.ID, TeamID: team.ID, Type: unit.TypeIssues, AccessMode: perm_model.AccessModeRead}))
|
|
t.Run("DoerWithReadIssueTeamOnPrivateRepo", func(t *testing.T) {
|
|
perm, err := GetIndividualUserRepoPermission(ctx, repo3, user)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, perm_model.AccessModeNone, perm.AccessMode)
|
|
assert.Equal(t, perm_model.AccessModeNone, perm.unitsMode[unit.TypeCode])
|
|
assert.Equal(t, perm_model.AccessModeRead, perm.unitsMode[unit.TypeIssues])
|
|
|
|
users, err := GetUsersWithAnyUnitAccess(ctx, repo3, perm_model.AccessModeRead, unit.TypeIssues)
|
|
require.NoError(t, err)
|
|
require.Len(t, users, 1)
|
|
assert.Equal(t, user.ID, users[0].ID)
|
|
|
|
users, err = GetUsersWithAnyUnitAccess(ctx, repo3, perm_model.AccessModeWrite, unit.TypeIssues)
|
|
require.NoError(t, err)
|
|
require.Empty(t, users)
|
|
})
|
|
|
|
require.NoError(t, db.Insert(ctx, repo_model.Collaboration{RepoID: repo3.ID, UserID: user.ID, Mode: perm_model.AccessModeWrite}))
|
|
require.NoError(t, db.Insert(ctx, Access{RepoID: repo3.ID, UserID: user.ID, Mode: perm_model.AccessModeWrite}))
|
|
t.Run("DoerWithReadIssueTeamAndWriteCollaboratorOnPrivateRepo", func(t *testing.T) {
|
|
perm, err := GetIndividualUserRepoPermission(ctx, repo3, user)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, perm_model.AccessModeWrite, perm.AccessMode)
|
|
assert.Equal(t, perm_model.AccessModeWrite, perm.unitsMode[unit.TypeCode])
|
|
assert.Equal(t, perm_model.AccessModeWrite, perm.unitsMode[unit.TypeIssues])
|
|
|
|
users, err := GetUsersWithAnyUnitAccess(ctx, repo3, perm_model.AccessModeWrite, unit.TypeIssues)
|
|
require.NoError(t, err)
|
|
require.Len(t, users, 1)
|
|
assert.Equal(t, user.ID, users[0].ID)
|
|
})
|
|
}
|
|
|
|
func testGetDoerRepoPermission(t *testing.T) {
|
|
ctx := t.Context()
|
|
|
|
repo4 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 4})
|
|
repo1 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
task47 := unittest.AssertExistsAndLoadBean(t, &actions_model.ActionTask{ID: 47})
|
|
actionsDoer := user_model.NewActionsUserWithTaskID(task47.ID)
|
|
regularUser := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
|
|
actionsPerm, err := GetDoerRepoPermission(ctx, repo4, actionsDoer)
|
|
require.NoError(t, err)
|
|
directPerm, err := GetActionsUserRepoPermission(ctx, repo4, actionsDoer, task47.ID)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, directPerm, actionsPerm)
|
|
|
|
doerPerm, err := GetDoerRepoPermission(ctx, repo1, regularUser)
|
|
require.NoError(t, err)
|
|
individualPerm, err := GetIndividualUserRepoPermission(ctx, repo1, regularUser)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, individualPerm, doerPerm)
|
|
|
|
t.Run("PublicOnlyTokenReachesOnlyPublicReposOfPublicOwners", func(t *testing.T) {
|
|
publicOnlyUser := *regularUser
|
|
publicOnlyUser.ExtDoerData = user_model.NewTokenExtDoerData(user_model.CredentialAccessToken, 1, "public-only,write:repository")
|
|
publicOnlyAdmin := *unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
|
|
publicOnlyAdmin.ExtDoerData = publicOnlyUser.ExtDoerData
|
|
for _, repoID := range []int64{2, 38} {
|
|
perm, err := GetDoerRepoPermission(ctx, unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: repoID}), &publicOnlyAdmin)
|
|
require.NoError(t, err)
|
|
assert.False(t, perm.HasAnyUnitAccessOrPublicAccess(), "repo %d", repoID)
|
|
}
|
|
|
|
perm, err := GetDoerRepoPermission(ctx, repo1, &publicOnlyUser)
|
|
require.NoError(t, err)
|
|
assert.True(t, perm.CanWrite(unit.TypeCode))
|
|
assert.NotEqual(t, RepoUserPermissionCacheKey(repo1.ID, regularUser), RepoUserPermissionCacheKey(repo1.ID, &publicOnlyUser))
|
|
})
|
|
}
|