mirror of
https://github.com/go-gitea/gitea.git
synced 2026-11-19 15:14:40 +09:00
Adds audit actions for security-relevant changes that were not logged at all, and records a few remaining events on paths that skipped them: - Account login prohibition (`user:status:prohibitlogin`) and the organization setting that lets repository admins change team access - Actions runner registration tokens issued, runners removed or enabled/disabled, and Actions variables, for every scope - Instance config changes, including maintenance mode (`system:config:update`) - Deploy token regeneration and pull mirror address changes - Review deletion and dismissal, package removal, and release and tag removal - Repository restores via `gitea admin restore-repo`, OAuth2 secret rotation on API update, and SSH keys added or removed by authentication source sync The authentication source SSH key sync moved from the asymkey model to the asymkey service so it can record events. Follow-up to https://github.com/go-gitea/gitea/pull/40317 and https://github.com/go-gitea/gitea/pull/40322. --------- Co-authored-by: silverwind <me@silverwind.io>
129 lines
4.3 KiB
Go
129 lines
4.3 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package ldap
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
|
|
audit_model "gitea.dev/models/audit"
|
|
"gitea.dev/models/auth"
|
|
user_model "gitea.dev/models/user"
|
|
auth_module "gitea.dev/modules/auth"
|
|
"gitea.dev/modules/log"
|
|
"gitea.dev/modules/optional"
|
|
asymkey_service "gitea.dev/services/asymkey"
|
|
"gitea.dev/services/audit"
|
|
source_service "gitea.dev/services/auth/source"
|
|
user_service "gitea.dev/services/user"
|
|
)
|
|
|
|
// Authenticate queries if login/password is valid against the LDAP directory pool,
|
|
// and create a local user if success when enabled.
|
|
func (source *Source) Authenticate(ctx context.Context, user *user_model.User, userName, password string) (*user_model.User, error) {
|
|
ctx = audit.WithDoer(ctx, user_model.NewAuthSourceUser())
|
|
|
|
loginName := userName
|
|
if user != nil {
|
|
loginName = user.LoginName
|
|
}
|
|
sr := source.SearchEntry(loginName, password, source.AuthSource.Type == auth.DLDAP)
|
|
if sr == nil {
|
|
// User is not in LDAP database, or password is invalid (direct bind)
|
|
return nil, user_model.ErrUserNotExist{Name: loginName, ExtraMsg: "not in LDAP database or invalid password"}
|
|
}
|
|
// Fallback.
|
|
// FIXME: this fallback would cause problems when the "Username" attribute is not set and a user inputs their email.
|
|
// In this case, the email would be used as the username, and will cause the "CreateUser" failure for the first login.
|
|
if sr.Username == "" {
|
|
if strings.Contains(userName, "@") {
|
|
log.Error("No username in search result (Username Attribute is not set properly?), using email as username might cause problems")
|
|
}
|
|
sr.Username = userName
|
|
}
|
|
if sr.Mail == "" {
|
|
sr.Mail = sr.Username + "@localhost.local"
|
|
}
|
|
isAttributeSSHPublicKeySet := strings.TrimSpace(source.AttributeSSHPublicKey) != ""
|
|
|
|
// Update User admin flag if exist
|
|
if isExist, err := user_model.IsUserExist(ctx, 0, sr.Username); err != nil {
|
|
return nil, err
|
|
} else if isExist {
|
|
if user == nil {
|
|
user, err = user_model.GetUserByName(ctx, sr.Username)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
if user != nil && !user.ProhibitLogin {
|
|
opts := &user_service.UpdateOptions{}
|
|
if source.AdminFilter != "" && user.IsAdmin != sr.IsAdmin {
|
|
// Change existing admin flag only if AdminFilter option is set
|
|
opts.IsAdmin = user_service.UpdateOptionFieldFromSync(sr.IsAdmin)
|
|
}
|
|
if !sr.IsAdmin && source.RestrictedFilter != "" && user.IsRestricted != sr.IsRestricted {
|
|
// Change existing restricted flag only if RestrictedFilter option is set
|
|
opts.IsRestricted = optional.Some(sr.IsRestricted)
|
|
}
|
|
if opts.IsAdmin.Has() || opts.IsRestricted.Has() {
|
|
if err := user_service.UpdateUser(ctx, user, opts); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
if user != nil {
|
|
if isAttributeSSHPublicKeySet && asymkey_service.SynchronizePublicKeys(ctx, user, source.AuthSource, sr.SSHPublicKey, source.SSHKeysAreVerified) {
|
|
if err := asymkey_service.RewriteAllPublicKeys(ctx); err != nil {
|
|
return user, err
|
|
}
|
|
}
|
|
} else {
|
|
user = &user_model.User{
|
|
LowerName: strings.ToLower(sr.Username),
|
|
Name: sr.Username,
|
|
FullName: composeFullName(sr.Name, sr.Surname, sr.Username),
|
|
Email: sr.Mail,
|
|
LoginType: source.AuthSource.Type,
|
|
LoginSource: source.AuthSource.ID,
|
|
LoginName: userName,
|
|
IsAdmin: sr.IsAdmin,
|
|
}
|
|
overwriteDefault := &user_model.CreateUserOverwriteOptions{
|
|
IsRestricted: optional.Some(sr.IsRestricted),
|
|
IsActive: optional.Some(true),
|
|
}
|
|
|
|
err := user_model.CreateUser(ctx, user, &user_model.Meta{}, overwriteDefault)
|
|
if err != nil {
|
|
return user, err
|
|
}
|
|
|
|
audit.Record(ctx, audit_model.UserCreate, user)
|
|
|
|
if isAttributeSSHPublicKeySet && asymkey_service.AddPublicKeysBySource(ctx, user, source.AuthSource, sr.SSHPublicKey, source.SSHKeysAreVerified) {
|
|
if err := asymkey_service.RewriteAllPublicKeys(ctx); err != nil {
|
|
return user, err
|
|
}
|
|
}
|
|
if source.AttributeAvatar != "" {
|
|
_ = user_service.UploadAvatar(ctx, user, sr.Avatar)
|
|
}
|
|
}
|
|
|
|
if source.GroupsEnabled && (source.GroupTeamMap != "" || source.GroupTeamMapRemoval) {
|
|
groupTeamMapping, err := auth_module.UnmarshalGroupTeamMapping(source.GroupTeamMap)
|
|
if err != nil {
|
|
return user, err
|
|
}
|
|
if err := source_service.SyncGroupsToTeams(ctx, user, sr.Groups, groupTeamMapping, source.GroupTeamMapRemoval); err != nil {
|
|
return user, err
|
|
}
|
|
}
|
|
|
|
return user, nil
|
|
}
|