mirror of
https://github.com/go-gitea/gitea.git
synced 2026-11-19 15:14:40 +09:00
Several entry points change users, credentials or 2FA without writing an audit event, while the equivalent web or service path does. This records the existing actions on those paths: - `user:create` for self sign-up, OAuth2 auto-registration, link-account registration and `gitea admin user create` - `user:accesstoken:add` for `gitea admin user generate-access-token` and `user create --access-token`; `user:accesstoken:remove` for `DELETE /api/v1/token` - `user:twofactor:disable` for the admin "reset 2FA" option and `gitea admin user disable-2fa` - `user:key:ssh:add`, `user:key:gpg:add/remove` for the API - `user:email:primary`, `user:email:activate`, `user:status:active` for settings, the activation page/links and OAuth2 source sync deactivation - `user:oauth2application:grant` when a grant's scope changes, `user:externallogin:add` on registration via an external login - `user:authentication:fail:twofactor` for wrong recovery codes, failed WebAuthn assertions and 2FA during password reset Should be backported to v28. --------- Co-authored-by: silverwind <me@silverwind.io>
98 lines
2.6 KiB
Go
98 lines
2.6 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package oauth2
|
|
|
|
import (
|
|
"testing"
|
|
|
|
audit_model "gitea.dev/models/audit"
|
|
"gitea.dev/models/auth"
|
|
"gitea.dev/models/unittest"
|
|
user_model "gitea.dev/models/user"
|
|
"gitea.dev/modules/setting"
|
|
"gitea.dev/modules/test"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestSource(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
defer test.MockVariableValue(&setting.Audit.RecordOutput, setting.AuditRecordOutputDatabase)()
|
|
|
|
source := &Source{
|
|
Provider: "fake",
|
|
ConfigBase: auth.ConfigBase{
|
|
AuthSource: &auth.Source{
|
|
ID: 12,
|
|
Type: auth.OAuth2,
|
|
Name: "fake",
|
|
IsActive: true,
|
|
IsSyncEnabled: true,
|
|
},
|
|
},
|
|
}
|
|
|
|
user := &user_model.User{
|
|
LoginName: "external",
|
|
LoginType: auth.OAuth2,
|
|
LoginSource: source.AuthSource.ID,
|
|
Name: "test",
|
|
Email: "external@example.com",
|
|
}
|
|
|
|
err := user_model.CreateUser(t.Context(), user, &user_model.Meta{}, &user_model.CreateUserOverwriteOptions{})
|
|
assert.NoError(t, err)
|
|
|
|
e := &user_model.ExternalLoginUser{
|
|
ExternalID: "external",
|
|
UserID: user.ID,
|
|
LoginSourceID: user.LoginSource,
|
|
RefreshToken: "valid",
|
|
}
|
|
err = user_model.LinkExternalToUser(t.Context(), user, e)
|
|
assert.NoError(t, err)
|
|
|
|
provider, err := createProvider(source.AuthSource.Name, source)
|
|
assert.NoError(t, err)
|
|
|
|
t.Run("refresh", func(t *testing.T) {
|
|
t.Run("valid", func(t *testing.T) {
|
|
err := source.refresh(t.Context(), provider, e)
|
|
assert.NoError(t, err)
|
|
|
|
e, ok, err := user_model.GetExternalLogin(t.Context(), e.LoginSourceID, e.ExternalID)
|
|
assert.NoError(t, err)
|
|
assert.True(t, ok)
|
|
assert.Equal(t, "refresh", e.RefreshToken)
|
|
assert.Equal(t, "token", e.AccessToken)
|
|
|
|
u, err := user_model.GetUserByID(t.Context(), user.ID)
|
|
assert.NoError(t, err)
|
|
assert.True(t, u.IsActive)
|
|
})
|
|
|
|
t.Run("expired", func(t *testing.T) {
|
|
for range 2 {
|
|
assert.NoError(t, source.refresh(t.Context(), provider, &user_model.ExternalLoginUser{
|
|
ExternalID: "external",
|
|
UserID: user.ID,
|
|
LoginSourceID: user.LoginSource,
|
|
RefreshToken: "expired",
|
|
}))
|
|
}
|
|
unittest.AssertCount(t, &audit_model.Event{Action: audit_model.UserActive, ScopeID: user.ID, ActorID: user_model.AuthSourceUserID}, 1)
|
|
|
|
e, ok, err := user_model.GetExternalLogin(t.Context(), e.LoginSourceID, e.ExternalID)
|
|
assert.NoError(t, err)
|
|
assert.True(t, ok)
|
|
assert.Empty(t, e.RefreshToken)
|
|
assert.Empty(t, e.AccessToken)
|
|
|
|
u, err := user_model.GetUserByID(t.Context(), user.ID)
|
|
assert.NoError(t, err)
|
|
assert.False(t, u.IsActive)
|
|
})
|
|
})
|
|
}
|