mirror of
https://github.com/go-gitea/gitea.git
synced 2026-10-11 15:04:02 +09:00
Giteabotandsilverwind
998a06627e
Backport #39728 by @silverwind Since https://github.com/go-gitea/gitea/pull/39703, Gitea fails to start when its gitconfig holds a `gc.reflogExpire` other than `90` (e.g. `30.days`), because `git config --unset-all` exits 5 when no value matches. Value patterns were also unanchored regexps, so `90` also removed `90.days`. - Match values exactly in `configUnsetAll` and `configAddNonExist` - Treat "nothing to unset" as success - Use `--replace-all` in `configSet` so a key with multiple values no longer fails startup Co-authored-by: silverwind <me@silverwind.io>
80 lines
2.8 KiB
Go
80 lines
2.8 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package git
|
|
|
|
import (
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
|
|
"gitea.dev/modules/git/gitcmd"
|
|
"gitea.dev/modules/setting"
|
|
"gitea.dev/modules/test"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func gitConfigContains(sub string) bool {
|
|
if b, err := os.ReadFile(gitcmd.HomeDir() + "/.gitconfig"); err == nil {
|
|
return strings.Contains(string(b), sub)
|
|
}
|
|
return false
|
|
}
|
|
|
|
func TestGitConfig(t *testing.T) {
|
|
ctx := t.Context()
|
|
assert.False(t, gitConfigContains("key-a"))
|
|
|
|
assert.NoError(t, configSetNonExist(ctx, "test.key-a", "val-a"))
|
|
assert.True(t, gitConfigContains("key-a = val-a"))
|
|
|
|
assert.NoError(t, configSetNonExist(ctx, "test.key-a", "val-a-changed"))
|
|
assert.False(t, gitConfigContains("key-a = val-a-changed"))
|
|
|
|
assert.NoError(t, configAddNonExist(ctx, "test.key-a", "val-a2"))
|
|
assert.NoError(t, configSet(ctx, "test.key-a", "val-a-changed"))
|
|
assert.NoError(t, configUnsetAll(ctx, "test.key-a", "val-a"))
|
|
assert.True(t, gitConfigContains("key-a = val-a-changed"))
|
|
|
|
assert.NoError(t, configAddNonExist(ctx, "test.key-b", "val-b"))
|
|
assert.True(t, gitConfigContains("key-b = val-b"))
|
|
|
|
assert.NoError(t, configAddNonExist(ctx, "test.key-b", "val-2b"))
|
|
assert.True(t, gitConfigContains("key-b = val-b"))
|
|
assert.True(t, gitConfigContains("key-b = val-2b"))
|
|
assert.NoError(t, configAddNonExist(ctx, "test.key-b", "val"))
|
|
assert.True(t, gitConfigContains("key-b = val\n"))
|
|
|
|
assert.NoError(t, configUnsetAll(ctx, "test.key-b", "val-b"))
|
|
assert.False(t, gitConfigContains("key-b = val-b"))
|
|
assert.True(t, gitConfigContains("key-b = val-2b"))
|
|
|
|
assert.NoError(t, configUnsetAll(ctx, "test.key-b", "val-2b"))
|
|
assert.False(t, gitConfigContains("key-b = val-2b"))
|
|
|
|
assert.NoError(t, configSet(ctx, "test.key-x", "*"))
|
|
assert.True(t, gitConfigContains("key-x = *"))
|
|
assert.NoError(t, configSetNonExist(ctx, "test.key-x", "*"))
|
|
assert.NoError(t, configUnsetAll(ctx, "test.key-x", "*"))
|
|
assert.False(t, gitConfigContains("key-x = *"))
|
|
}
|
|
|
|
func TestSyncGitConfig(t *testing.T) {
|
|
defer test.MockVariableValue(&setting.GitConfig)()
|
|
|
|
assert.Empty(t, setting.GitConfig.Options)
|
|
assert.NoError(t, configSet(t.Context(), "gc.reflogExpire", "90"))
|
|
assert.NoError(t, syncGitConfig(t.Context()))
|
|
assert.True(t, gitConfigContains("commitGraph = true")) // builtin default config
|
|
assert.False(t, gitConfigContains("reflogExpire"))
|
|
|
|
setting.GitConfig.Options["sync-test.cfg-key-a"] = "CfgValA"
|
|
setting.GitConfig.Options["core.commitgraph"] = "false"
|
|
assert.NoError(t, syncGitConfig(t.Context()))
|
|
assert.True(t, gitConfigContains("[sync-test]"))
|
|
assert.True(t, gitConfigContains("cfg-key-a = CfgValA"))
|
|
assert.False(t, gitConfigContains("commitGraph")) // builtin default config can be overridden
|
|
assert.True(t, gitConfigContains("commitgraph = false")) // git config key is case-insensitive
|
|
}
|