mirror of
https://github.com/go-gitea/gitea.git
synced 2026-11-19 15:14:40 +09:00
Concurrent requests could create teams with the same name in one
organization, because only the service checked the name. Editing such a
team, or renaming a team to a taken name, then failed with a 500.
- Add a unique index on `team (org_id, lower_name)`. Migration 368
renames every duplicate except the oldest to a free `<name>-<n>` and
logs each rename. IDs, members, repositories and permissions are kept,
but lookups by the old name (CODEOWNERS, group-to-team sync, mentions,
URLs) now reach only the kept team.
- Team writes report a name rejected by the index as
`ErrTeamAlreadyExist`, so duplicates, concurrent ones included, return
409 from `POST /orgs/{org}/teams` (previously 422) and `PATCH
/teams/{id}`, and a form error in the web UI.
Fixes https://github.com/go-gitea/gitea/issues/39632
---------
Co-authored-by: silverwind <me@silverwind.io>
53 lines
1.6 KiB
Go
53 lines
1.6 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package v29
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"gitea.dev/modelmigration/migrationtest"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestAddUniqueTeamNameIndex(t *testing.T) {
|
|
type Team struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
OrgID int64 `xorm:"INDEX"`
|
|
LowerName, Name string
|
|
}
|
|
|
|
x, cleanup := migrationtest.PrepareTestEnv(t, 0, new(Team))
|
|
defer cleanup()
|
|
if x == nil || t.Failed() {
|
|
return
|
|
}
|
|
|
|
_, err := x.Insert(
|
|
&Team{OrgID: 1, Name: "Team", LowerName: "team"},
|
|
&Team{OrgID: 1, Name: "Team", LowerName: "team"},
|
|
&Team{OrgID: 1, Name: "Team-2", LowerName: "team-2"},
|
|
&Team{OrgID: 2, Name: "Team", LowerName: "team"},
|
|
&Team{OrgID: 1, Name: strings.Repeat("A", 255), LowerName: strings.Repeat("a", 255)},
|
|
&Team{OrgID: 1, Name: strings.Repeat("A", 255), LowerName: strings.Repeat("a", 255)},
|
|
)
|
|
require.NoError(t, err)
|
|
for range 2 {
|
|
require.NoError(t, AddUniqueTeamNameIndex(t.Context(), x))
|
|
var teams []Team
|
|
require.NoError(t, x.Asc("id").Find(&teams))
|
|
require.Equal(t, []Team{
|
|
{ID: 1, OrgID: 1, Name: "Team", LowerName: "team"},
|
|
{ID: 2, OrgID: 1, Name: "Team-3", LowerName: "team-3"},
|
|
{ID: 3, OrgID: 1, Name: "Team-2", LowerName: "team-2"},
|
|
{ID: 4, OrgID: 2, Name: "Team", LowerName: "team"},
|
|
{ID: 5, OrgID: 1, Name: strings.Repeat("A", 255), LowerName: strings.Repeat("a", 255)},
|
|
{ID: 6, OrgID: 1, Name: strings.Repeat("A", 253) + "-6", LowerName: strings.Repeat("a", 253) + "-6"},
|
|
}, teams)
|
|
}
|
|
_, err = x.Insert(&Team{OrgID: 1, Name: "TEAM", LowerName: "team"})
|
|
require.Error(t, err)
|
|
}
|