mirror of
https://github.com/go-gitea/gitea.git
synced 2026-11-02 13:44:16 +09:00
Backport https://github.com/go-gitea/gitea/pull/39945 API tokens and Actions task tokens could see data beyond their scope through user-scoped API routes and web profile pages. - Actions task tokens authenticate as a shared system user with a negative ID, which org, project and SSH/GPG key filters treated as "no owner filter". These filters now check `!= 0`, so system users own nothing. The `/api/v1/user` routes except `GET /api/v1/user` only accept individual and bot accounts, and repo search no longer skips access checks for the owner. - `/{username}` only accepts tokens for RSS/Atom feeds. HTML profile and org pages render as anonymous for token requests. - User and org feeds require `read:user` or `read:organization` from tokens, the same way repo feeds require `read:repository`. `release/v28` lacks https://github.com/go-gitea/gitea/pull/39967, so `/{username}` enables basic auth only for feed requests through a middleware. The profile page token tests from https://github.com/go-gitea/gitea/pull/39853 are folded into `TestFeedUser`, because profile pages no longer accept tokens. Co-authored-by: bircni <bircni@icloud.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>
115 lines
3.5 KiB
Go
115 lines
3.5 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package feed
|
|
|
|
import (
|
|
"time"
|
|
|
|
activities_model "gitea.dev/models/activities"
|
|
auth_model "gitea.dev/models/auth"
|
|
"gitea.dev/models/organization"
|
|
"gitea.dev/models/renderhelper"
|
|
user_model "gitea.dev/models/user"
|
|
"gitea.dev/modules/markup/markdown"
|
|
"gitea.dev/modules/setting"
|
|
"gitea.dev/modules/util"
|
|
"gitea.dev/services/context"
|
|
feed_service "gitea.dev/services/feed"
|
|
|
|
"github.com/gorilla/feeds"
|
|
)
|
|
|
|
// ShowUserFeedRSS show user activity as RSS feed
|
|
func ShowUserFeedRSS(ctx *context.Context) {
|
|
showUserFeed(ctx, "rss")
|
|
}
|
|
|
|
// ShowUserFeedAtom show user activity as Atom feed
|
|
func ShowUserFeedAtom(ctx *context.Context) {
|
|
showUserFeed(ctx, "atom")
|
|
}
|
|
|
|
// showUserFeed show user activity as RSS / Atom feed
|
|
func showUserFeed(ctx *context.Context, formatType string) {
|
|
isOrganisation := ctx.ContextUser.IsOrganization()
|
|
if !setting.Other.EnableFeed ||
|
|
isOrganisation && !organization.HasOrgOrUserVisible(ctx, ctx.ContextUser, ctx.Doer) ||
|
|
!isOrganisation && !user_model.IsUserVisibleToViewer(ctx, ctx.ContextUser, ctx.Doer) {
|
|
ctx.NotFound(nil)
|
|
return
|
|
}
|
|
context.CheckTokenScopes(ctx, nil, util.Iif(ctx.ContextUser.IsOrganization(), auth_model.AccessTokenScopeReadOrganization, auth_model.AccessTokenScopeReadUser))
|
|
if ctx.Written() {
|
|
return
|
|
}
|
|
|
|
includePrivate := ctx.IsSigned && (ctx.Doer.IsAdmin || ctx.Doer.ID == ctx.ContextUser.ID)
|
|
if ctx.IsSigned && isOrganisation && !includePrivate {
|
|
// When feed is requested by a member of the organization,
|
|
// include the private repo's the member has access to.
|
|
isOrgMember, err := organization.IsOrganizationMember(ctx, ctx.ContextUser.ID, ctx.Doer.ID)
|
|
if err != nil {
|
|
ctx.ServerError("IsOrganizationMember", err)
|
|
return
|
|
}
|
|
includePrivate = isOrgMember
|
|
}
|
|
|
|
// a public-only API token must not surface private activity, even for its own owner
|
|
if includePrivate && context.TokenIsPublicOnly(ctx) {
|
|
includePrivate = false
|
|
}
|
|
|
|
actions, _, err := feed_service.GetFeeds(ctx, activities_model.GetFeedsOptions{
|
|
RequestedUser: ctx.ContextUser,
|
|
Actor: ctx.Doer,
|
|
IncludePrivate: includePrivate,
|
|
OnlyPerformedBy: !isOrganisation,
|
|
IncludeDeleted: false,
|
|
Date: ctx.FormString("date"),
|
|
})
|
|
if err != nil {
|
|
ctx.ServerError("GetFeeds", err)
|
|
return
|
|
}
|
|
|
|
rctx := renderhelper.NewRenderContextSimpleDocument(ctx, ctx.ContextUser.HTMLURL(ctx))
|
|
ctxUserDescription, err := markdown.RenderString(rctx,
|
|
ctx.ContextUser.Description)
|
|
if err != nil {
|
|
ctx.ServerError("RenderString", err)
|
|
return
|
|
}
|
|
|
|
feed := &feeds.Feed{
|
|
Title: ctx.Locale.TrString("home.feed_of", ctx.ContextUser.DisplayName()),
|
|
Link: &feeds.Link{Href: ctx.ContextUser.HTMLURL(ctx)},
|
|
Description: string(ctxUserDescription),
|
|
Created: time.Now(),
|
|
}
|
|
|
|
feed.Items, err = feedActionsToFeedItems(ctx, actions)
|
|
if err != nil {
|
|
ctx.ServerError("convert feed", err)
|
|
return
|
|
}
|
|
|
|
writeFeed(ctx, feed, formatType)
|
|
}
|
|
|
|
// writeFeed write a feeds.Feed as atom or rss to ctx.Resp
|
|
func writeFeed(ctx *context.Context, feed *feeds.Feed, formatType string) {
|
|
if formatType == "atom" {
|
|
ctx.Resp.Header().Set("Content-Type", "application/atom+xml;charset=utf-8")
|
|
if err := feed.WriteAtom(ctx.Resp); err != nil {
|
|
ctx.ServerError("Render Atom failed", err)
|
|
}
|
|
} else {
|
|
ctx.Resp.Header().Set("Content-Type", "application/rss+xml;charset=utf-8")
|
|
if err := feed.WriteRss(ctx.Resp); err != nil {
|
|
ctx.ServerError("Render RSS failed", err)
|
|
}
|
|
}
|
|
}
|