mirror of
https://github.com/go-gitea/gitea.git
synced 2026-05-06 04:01:05 +09:00
184ce17167
Fixes #37415. Pin the review submission form action to the canonical PR files route --------- Co-authored-by: cyphercodes <cyphercodes@users.noreply.github.com> Co-authored-by: Hermes Agent (OpenAI GPT-5.5) <noreply@nousresearch.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
68 lines
2.5 KiB
Go
68 lines
2.5 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/tests"
|
|
|
|
"github.com/PuerkitoBio/goquery"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestPullDiff(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
t.Run("CompletePRDiff", func(t *testing.T) {
|
|
testPullDiffAssertPage(t, "/user2/commitsonpr/pulls/1/files", false, []string{"test1.txt", "test10.txt", "test2.txt", "test3.txt", "test4.txt", "test5.txt", "test6.txt", "test7.txt", "test8.txt", "test9.txt"})
|
|
})
|
|
t.Run("SingleCommitPRDiff", func(t *testing.T) {
|
|
testPullDiffAssertPage(t, "/user2/commitsonpr/pulls/1/commits/c5626fc9eff57eb1bb7b796b01d4d0f2f3f792a2", true, []string{"test3.txt"})
|
|
})
|
|
t.Run("CommitRangePRDiff", func(t *testing.T) {
|
|
testPullDiffAssertPage(t, "/user2/commitsonpr/pulls/1/files/4ca8bcaf27e28504df7bf996819665986b01c847..23576dd018294e476c06e569b6b0f170d0558705", true, []string{"test2.txt", "test3.txt", "test4.txt"})
|
|
})
|
|
t.Run("SingleHeadCommitReviewFormAction", testPullDiffSingleHeadCommitReviewFormAction)
|
|
}
|
|
|
|
func testPullDiffSingleHeadCommitReviewFormAction(t *testing.T) {
|
|
session := loginUser(t, "user2")
|
|
req := NewRequest(t, "GET", "/user2/commitsonpr/pulls/1/commits/1978192d98bb1b65e11c2cf37da854fbf94bffd6")
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
doc := NewHTMLParser(t, resp.Body)
|
|
|
|
btn := doc.Find(".js-btn-review")
|
|
assert.True(t, btn.Length() == 1 && !btn.HasClass("disabled"))
|
|
form := doc.Find(".review-box-panel form")
|
|
assert.Equal(t, 1, form.Length())
|
|
assert.Equal(t, "/user2/commitsonpr/pulls/1/files/reviews/submit", form.AttrOr("action", ""))
|
|
}
|
|
|
|
func testPullDiffAssertPage(t *testing.T, prDiffURL string, reviewBtnDisabled bool, expectedFilenames []string) {
|
|
session := loginUser(t, "user2")
|
|
|
|
req := NewRequest(t, "GET", "/user2/commitsonpr/pulls")
|
|
session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
// Get the given PR diff url
|
|
req = NewRequest(t, "GET", prDiffURL)
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
doc := NewHTMLParser(t, resp.Body)
|
|
|
|
// Assert all files are visible.
|
|
fileContents := doc.Find(".file-content")
|
|
numberOfFiles := fileContents.Length()
|
|
|
|
assert.Equal(t, len(expectedFilenames), numberOfFiles)
|
|
|
|
fileContents.Each(func(i int, s *goquery.Selection) {
|
|
filename, _ := s.Attr("data-old-filename")
|
|
assert.Equal(t, expectedFilenames[i], filename)
|
|
})
|
|
|
|
// Ensure the review button is enabled for full PR reviews
|
|
assert.Equal(t, reviewBtnDisabled, doc.Find(".js-btn-review").HasClass("disabled"))
|
|
}
|