Files
gitea/tests/e2e/webauthn.test.ts
T
c54ec52f0f fix(auth): limit failed TOTP attempts per account (#39993)
Gitea accepted unlimited wrong TOTP passcodes, so anyone holding an
account's password could enumerate the 6-digit code in minutes. This
allows 5 failed attempts per account, then refuses TOTP until 15 minutes
after the last one.

- The count lives in the cache, and the global lock spans the check,
validation and counting, so new sessions and concurrent requests cannot
widen it. With Redis, both are shared across instances
- Applies to every TOTP check: the web 2FA page, account recovery and
Basic auth with `X-Gitea-OTP` (API, git, packages)
- Only wrong or replayed passcodes count, server errors do not
- Scratch codes and WebAuthn stay usable as the recovery path while
locked
- Failures log `Failed authentication attempt for <user> from <ip>`,
which the fail2ban filter already matches

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2026-11-07 23:01:49 +00:00

63 lines
2.6 KiB
TypeScript

import {platform} from 'node:process';
import {test, expect, type Page} from '@playwright/test';
import {apiCreateUser, loginUser, randomString, signInWithPassword} from './utils.ts';
const signedIn = /^(?!.*\/user\/(login|webauthn))/; // the target of a finished login varies
async function registerKey(page: Page, nickname: string) {
await page.goto('/user/settings/security');
await page.getByRole('textbox', {name: 'Nickname'}).fill(nickname);
await page.getByRole('button', {name: 'Add Security Key'}).click();
}
// regression: credProtect level 3 hid the credential from the second-factor login
test('security key survives credProtect', async ({page, request, browserName}) => {
test.skip(browserName !== 'chromium', 'only the CDP authenticator emulates credProtect'); // eslint-disable-line playwright/no-skipped-test -- conditional skip, the reason is in the message
const username = `e2e-credprotect-${randomString(8)}`;
await apiCreateUser(request, username);
const cdp = await page.context().newCDPSession(page);
await cdp.send('WebAuthn.enable');
await cdp.send('WebAuthn.addVirtualAuthenticator', {options: {
protocol: 'ctap2',
ctap2Version: 'ctap2_1',
transport: 'usb',
hasResidentKey: true,
hasUserVerification: true,
hasCredBlob: true, // CDP only emulates credProtect together with credBlob
isUserVerified: true,
}});
await loginUser(page, username);
await registerKey(page, 'e2e-key');
await expect(page.getByText('e2e-key')).toBeVisible();
await registerKey(page, 'e2e-key-again');
await expect(page.locator('#webauthn-error-msg')).toContainText('already registered');
await signInWithPassword(page, username);
await expect(page).toHaveURL(signedIn);
});
// this authenticator has no credProtect, so it cannot replace the test above
test('security key signs in as second factor and as passkey', async ({page, request, browserName}) => {
test.skip(browserName === 'webkit' && platform === 'linux', 'linux webkit has no webauthn, playwright only stubs PublicKeyCredential'); // eslint-disable-line playwright/no-skipped-test -- conditional skip, the reason is in the message
const username = `e2e-passkey-${randomString(8)}`;
await apiCreateUser(request, username);
await page.context().credentials.install();
await loginUser(page, username);
await registerKey(page, 'e2e-key');
await expect(page.getByText('e2e-key')).toBeVisible();
await signInWithPassword(page, username);
await expect(page).toHaveURL(signedIn);
await page.context().clearCookies();
await page.goto('/user/login');
await page.getByText('Sign in with a passkey').click();
await expect(page).toHaveURL(signedIn);
});