mirror of
https://github.com/go-gitea/gitea.git
synced 2026-11-02 13:44:16 +09:00
a4d1711777
Fixes https://github.com/go-gitea/gitea/issues/40037 `DELETE /repos/{owner}/{repo}/push_mirrors/{name}` only deleted the `push_mirror` row and left the `remote_mirror_*` git remotes, which embed the mirror credentials, in the repository and wiki config. Each create/delete cycle through the API left more credentials behind. - Remove the git remotes before deleting the row and record it in the audit log, like the web settings handler. - Return 404 for an unknown name, as documented, instead of 204. - Ignore an already missing code remote, so the wiki remote is still removed and such mirrors can be deleted through both the API and the web settings. --- AI disclosure: I used an AI coding assistant to help write this change and the PR description. I reviewed the code and ran the tests myself. --------- Signed-off-by: sarankumar1325 <120080287+sarankumar1325@users.noreply.github.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
218 lines
9.1 KiB
Go
218 lines
9.1 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"net/url"
|
|
"strconv"
|
|
"testing"
|
|
"time"
|
|
|
|
auth_model "gitea.dev/models/auth"
|
|
"gitea.dev/models/db"
|
|
repo_model "gitea.dev/models/repo"
|
|
"gitea.dev/models/unittest"
|
|
user_model "gitea.dev/models/user"
|
|
"gitea.dev/modules/git"
|
|
"gitea.dev/modules/setting"
|
|
api "gitea.dev/modules/structs"
|
|
"gitea.dev/modules/test"
|
|
mirror_service "gitea.dev/services/mirror"
|
|
repo_service "gitea.dev/services/repository"
|
|
wiki_service "gitea.dev/services/wiki"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestMirrorPush(t *testing.T) {
|
|
onGiteaRun(t, func(t *testing.T, serverURL *url.URL) {
|
|
t.Run("SettingsUpdate", func(t *testing.T) {
|
|
session := loginUser(t, "user2")
|
|
repo2 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 2})
|
|
testCreatePushMirror(t, session, "user2", "repo2", "https://127.0.0.1/user1/repo1.git", "", "", "24h")
|
|
|
|
pushMirrors, cnt, err := repo_model.GetPushMirrorsByRepoID(t.Context(), repo2.ID, db.ListOptions{})
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 1, cnt)
|
|
assert.Equal(t, 24*time.Hour, pushMirrors[0].Interval)
|
|
repo2PushMirrorID := pushMirrors[0].ID
|
|
|
|
// update repo2 push mirror
|
|
assert.True(t, doUpdatePushMirror(t, session, "user2", "repo2", repo2PushMirrorID, "10m0s"))
|
|
pushMirror := unittest.AssertExistsAndLoadBean(t, &repo_model.PushMirror{ID: repo2PushMirrorID})
|
|
assert.Equal(t, 10*time.Minute, pushMirror.Interval)
|
|
|
|
// avoid updating repo2 push mirror from repo1
|
|
assert.False(t, doUpdatePushMirror(t, session, "user2", "repo1", repo2PushMirrorID, "20m0s"))
|
|
pushMirror = unittest.AssertExistsAndLoadBean(t, &repo_model.PushMirror{ID: repo2PushMirrorID})
|
|
assert.Equal(t, 10*time.Minute, pushMirror.Interval) // not changed
|
|
|
|
// avoid deleting repo2 push mirror from repo1
|
|
assert.False(t, doRemovePushMirror(t, session, "user2", "repo1", repo2PushMirrorID))
|
|
unittest.AssertExistsAndLoadBean(t, &repo_model.PushMirror{ID: repo2PushMirrorID})
|
|
|
|
// delete repo2 push mirror
|
|
assert.True(t, doRemovePushMirror(t, session, "user2", "repo2", repo2PushMirrorID))
|
|
unittest.AssertNotExistsBean(t, &repo_model.PushMirror{ID: repo2PushMirrorID})
|
|
})
|
|
t.Run("APIDelete", func(t *testing.T) {
|
|
testMirrorPushAPIDelete(t, serverURL)
|
|
})
|
|
t.Run("Push", func(t *testing.T) {
|
|
testMirrorPush(t, serverURL)
|
|
})
|
|
t.Run("WikiDefaultBranchMismatch", func(t *testing.T) {
|
|
testMirrorPushWikiDefaultBranchMismatch(t, serverURL)
|
|
})
|
|
})
|
|
}
|
|
|
|
func testMirrorPushAPIDelete(t *testing.T, u *url.URL) {
|
|
repo1 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
token := getUserToken(t, "user2", auth_model.AccessTokenScopeWriteRepository)
|
|
createPushMirror := func() string {
|
|
req := NewRequestWithJSON(t, "POST", "/api/v1/repos/user2/repo1/push_mirrors", &api.CreatePushMirrorOption{
|
|
RemoteAddress: u.String() + "user2/repo1.git",
|
|
RemoteUsername: "user2",
|
|
RemotePassword: userPassword,
|
|
Interval: "0",
|
|
}).AddTokenAuth(token)
|
|
return DecodeJSON(t, MakeRequest(t, req, http.StatusOK), &api.PushMirror{}).RemoteName
|
|
}
|
|
|
|
remoteName := createPushMirror()
|
|
MakeRequest(t, NewRequest(t, "DELETE", "/api/v1/repos/user2/repo1/push_mirrors/"+remoteName).AddTokenAuth(token), http.StatusNoContent)
|
|
_, err := git.GetRemoteAddress(t.Context(), repo1, remoteName)
|
|
assert.True(t, git.IsRemoteNotExistError(err))
|
|
MakeRequest(t, NewRequest(t, "DELETE", "/api/v1/repos/user2/repo1/push_mirrors/"+remoteName).AddTokenAuth(token), http.StatusNotFound)
|
|
|
|
remoteName = createPushMirror()
|
|
_, err = git.GetRemoteAddress(t.Context(), repo1.WikiStorageRepo(), remoteName)
|
|
require.NoError(t, err)
|
|
require.NoError(t, git.ManagedRemoteRemove(t.Context(), repo1, remoteName))
|
|
MakeRequest(t, NewRequest(t, "DELETE", "/api/v1/repos/user2/repo1/push_mirrors/"+remoteName).AddTokenAuth(token), http.StatusNoContent)
|
|
_, err = git.GetRemoteAddress(t.Context(), repo1.WikiStorageRepo(), remoteName)
|
|
assert.True(t, git.IsRemoteNotExistError(err))
|
|
}
|
|
|
|
func testMirrorPush(t *testing.T, u *url.URL) {
|
|
_ = db.TruncateBeans(t.Context(), &repo_model.PushMirror{})
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
srcRepo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
|
|
mirrorRepo, err := repo_service.CreateRepositoryDirectly(t.Context(), user, user, repo_service.CreateRepoOptions{
|
|
Name: "test-push-mirror",
|
|
}, true)
|
|
assert.NoError(t, err)
|
|
|
|
session := loginUser(t, user.Name)
|
|
|
|
pushMirrorURL := fmt.Sprintf("%s%s/%s", u.String(), url.PathEscape(user.Name), url.PathEscape(mirrorRepo.Name))
|
|
testCreatePushMirror(t, session, user.Name, srcRepo.Name, pushMirrorURL, user.LowerName, userPassword, "0")
|
|
|
|
mirrors, _, err := repo_model.GetPushMirrorsByRepoID(t.Context(), srcRepo.ID, db.ListOptions{})
|
|
assert.NoError(t, err)
|
|
assert.Len(t, mirrors, 1)
|
|
|
|
ok := mirror_service.SyncPushMirror(t.Context(), mirrors[0].ID)
|
|
assert.True(t, ok)
|
|
assert.NotZero(t, unittest.AssertExistsAndLoadBean(t, &repo_model.PushMirror{ID: mirrors[0].ID}).LastUpdateUnix)
|
|
|
|
srcGitRepo, err := git.OpenRepository(t.Context(), srcRepo)
|
|
assert.NoError(t, err)
|
|
defer srcGitRepo.Close()
|
|
|
|
srcCommit, err := srcGitRepo.GetBranchCommit(t.Context(), "master")
|
|
assert.NoError(t, err)
|
|
|
|
mirrorGitRepo, err := git.OpenRepository(t.Context(), mirrorRepo)
|
|
assert.NoError(t, err)
|
|
defer mirrorGitRepo.Close()
|
|
|
|
mirrorCommit, err := mirrorGitRepo.GetBranchCommit(t.Context(), "master")
|
|
assert.NoError(t, err)
|
|
|
|
assert.Equal(t, srcCommit.ID, mirrorCommit.ID)
|
|
|
|
defer test.MockVariableValue(&setting.Migrations.AllowedHostList, "")()
|
|
assert.False(t, mirror_service.SyncPushMirror(t.Context(), mirrors[0].ID))
|
|
assert.NotEmpty(t, unittest.AssertExistsAndLoadBean(t, &repo_model.PushMirror{ID: mirrors[0].ID}).LastError)
|
|
|
|
// Cleanup
|
|
assert.True(t, doRemovePushMirror(t, session, user.Name, srcRepo.Name, mirrors[0].ID))
|
|
mirrors, _, err = repo_model.GetPushMirrorsByRepoID(t.Context(), srcRepo.ID, db.ListOptions{})
|
|
assert.NoError(t, err)
|
|
assert.Empty(t, mirrors)
|
|
}
|
|
|
|
func testMirrorPushWikiDefaultBranchMismatch(t *testing.T, u *url.URL) {
|
|
_ = db.TruncateBeans(t.Context(), &repo_model.PushMirror{})
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
srcRepo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
|
|
mirrorRepo, err := repo_service.CreateRepositoryDirectly(t.Context(), user, user, repo_service.CreateRepoOptions{
|
|
Name: "test-push-mirror-wiki",
|
|
}, true)
|
|
assert.NoError(t, err)
|
|
|
|
assert.NoError(t, wiki_service.AddWikiPage(t.Context(), user, mirrorRepo, wiki_service.WebPath("Home"), "Mirror wiki content", "init wiki"))
|
|
|
|
mirrorRepo.DefaultBranch = "mirror-head"
|
|
assert.NoError(t, repo_model.UpdateRepositoryColsNoAutoTime(t.Context(), mirrorRepo, "default_branch"))
|
|
|
|
wikiCommitID, err := git.GetBranchCommitID(t.Context(), mirrorRepo.WikiStorageRepo(), mirrorRepo.DefaultWikiBranch)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, git.CreateBranch(t.Context(), mirrorRepo.WikiStorageRepo(), "mirror-head", wikiCommitID))
|
|
|
|
session := loginUser(t, user.Name)
|
|
|
|
pushMirrorURL := fmt.Sprintf("%s%s/%s", u.String(), url.PathEscape(user.Name), url.PathEscape(mirrorRepo.Name))
|
|
testCreatePushMirror(t, session, user.Name, srcRepo.Name, pushMirrorURL, user.LowerName, userPassword, "0")
|
|
|
|
mirrors, _, err := repo_model.GetPushMirrorsByRepoID(t.Context(), srcRepo.ID, db.ListOptions{})
|
|
assert.NoError(t, err)
|
|
assert.Len(t, mirrors, 1)
|
|
|
|
ok := mirror_service.SyncPushMirror(t.Context(), mirrors[0].ID)
|
|
assert.True(t, ok)
|
|
}
|
|
|
|
func testCreatePushMirror(t *testing.T, session *TestSession, owner, repo, address, username, password, interval string) {
|
|
req := NewRequestWithValues(t, "POST", fmt.Sprintf("/%s/%s/settings", url.PathEscape(owner), url.PathEscape(repo)), map[string]string{
|
|
"action": "push-mirror-add",
|
|
"push_mirror_address": address,
|
|
"push_mirror_username": username,
|
|
"push_mirror_password": password,
|
|
"push_mirror_interval": interval,
|
|
})
|
|
session.MakeRequest(t, req, http.StatusSeeOther)
|
|
|
|
flashMsg := session.GetCookieFlashMessage()
|
|
assert.NotEmpty(t, flashMsg.SuccessMsg)
|
|
}
|
|
|
|
func doRemovePushMirror(t *testing.T, session *TestSession, owner, repo string, pushMirrorID int64) bool {
|
|
req := NewRequestWithValues(t, "POST", fmt.Sprintf("/%s/%s/settings", url.PathEscape(owner), url.PathEscape(repo)), map[string]string{
|
|
"action": "push-mirror-remove",
|
|
"push_mirror_id": strconv.FormatInt(pushMirrorID, 10),
|
|
})
|
|
resp := session.MakeRequest(t, req, NoExpectedStatus)
|
|
flashMsg := session.GetCookieFlashMessage()
|
|
return resp.Code == http.StatusSeeOther && assert.NotEmpty(t, flashMsg.SuccessMsg)
|
|
}
|
|
|
|
func doUpdatePushMirror(t *testing.T, session *TestSession, owner, repo string, pushMirrorID int64, interval string) bool {
|
|
req := NewRequestWithValues(t, "POST", fmt.Sprintf("/%s/%s/settings", owner, repo), map[string]string{
|
|
"action": "push-mirror-update",
|
|
"push_mirror_id": strconv.FormatInt(pushMirrorID, 10),
|
|
"push_mirror_interval": interval,
|
|
"push_mirror_defer_sync": "true",
|
|
})
|
|
resp := session.MakeRequest(t, req, NoExpectedStatus)
|
|
return resp.Code == http.StatusSeeOther
|
|
}
|