mirror of
https://github.com/go-gitea/gitea.git
synced 2026-11-05 00:09:33 +09:00
wxiaoguangandsilverwind
d919301d36
Remove the `UnmarshalHandleDoubleEncode` runtime workaround for an old xorm bug, and normalize legacy double-encoded JSON in `repo_unit.config` and `login_source.cfg` with a migration instead. - Config `FromDB` no longer fails on corrupted values. A broken auth source is deactivated, so admins can still fix it in the admin panel - Remove `ProjectsConfig.GetProjectsMode`, `FromDB` already defaults `ProjectsMode` Actually it doesn't need so many changes, just because AI thinks it should handle "corrupted database value" for auth sources. --------- Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io>
106 lines
2.9 KiB
Go
106 lines
2.9 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package db
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"gitea.dev/modules/json"
|
|
"gitea.dev/modules/setting"
|
|
|
|
"xorm.io/xorm"
|
|
"xorm.io/xorm/convert"
|
|
"xorm.io/xorm/schemas"
|
|
)
|
|
|
|
// ConvertDatabaseTable converts database and tables from utf8 to utf8mb4 if it's mysql and set ROW_FORMAT=dynamic
|
|
func ConvertDatabaseTable() error {
|
|
if xormEngine.Dialect().URI().DBType != schemas.MYSQL {
|
|
return nil
|
|
}
|
|
|
|
r, err := CheckCollations(xormEngine)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
_, err = xormEngine.Exec(fmt.Sprintf("ALTER DATABASE `%s` CHARACTER SET utf8mb4 COLLATE %s", setting.Database.Name, r.ExpectedCollation))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
tables, err := xormEngine.DBMetas()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
for _, table := range tables {
|
|
if _, err := xormEngine.Exec(fmt.Sprintf("ALTER TABLE `%s` ROW_FORMAT=dynamic", table.Name)); err != nil {
|
|
return err
|
|
}
|
|
|
|
if _, err := xormEngine.Exec(fmt.Sprintf("ALTER TABLE `%s` CONVERT TO CHARACTER SET utf8mb4 COLLATE %s", table.Name, r.ExpectedCollation)); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// ConvertVarcharToNVarchar converts database and tables from varchar to nvarchar if it's mssql
|
|
func ConvertVarcharToNVarchar() error {
|
|
if xormEngine.Dialect().URI().DBType != schemas.MSSQL {
|
|
return nil
|
|
}
|
|
|
|
sess := xormEngine.NewSession()
|
|
defer sess.Close()
|
|
res, err := sess.QuerySliceString(`SELECT 'ALTER TABLE ' + OBJECT_NAME(SC.object_id) + ' MODIFY SC.name NVARCHAR(' + CONVERT(VARCHAR(5),SC.max_length) + ')'
|
|
FROM SYS.columns SC
|
|
JOIN SYS.types ST
|
|
ON SC.system_type_id = ST.system_type_id
|
|
AND SC.user_type_id = ST.user_type_id
|
|
WHERE ST.name ='varchar'`)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
for _, row := range res {
|
|
if len(row) == 1 {
|
|
if _, err = sess.Exec(row[0]); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
}
|
|
return err
|
|
}
|
|
|
|
// CellToInt converts a xorm.Cell field value to an int value
|
|
func CellToInt[T ~int | int64](cell xorm.Cell, def T) (ret T, has bool, err error) {
|
|
if *cell == nil {
|
|
return def, false, nil
|
|
}
|
|
val, err := convert.AsInt64(*cell)
|
|
if err != nil {
|
|
return def, false, err
|
|
}
|
|
return T(val), true, err
|
|
}
|
|
|
|
func UnmarshalFromDB(data []byte, v any) bool {
|
|
if len(data) == 0 {
|
|
return true
|
|
}
|
|
err := json.Unmarshal(data, v)
|
|
if err != nil {
|
|
// Even if database value is corrupted, we should not let it cause unnecessary 500 error or block user's operation
|
|
// Corrupted database value is a really rare case, it should never happen unless site admin manually modified the database.
|
|
// Although some database values will be printed into logs, it isn't a real problem
|
|
// because such case should never really happen. If it happens, logging the value
|
|
// is the only way to tell site admin which record is wrong since there is no other context information,
|
|
// and then they need to re-create the config (with new secrets)
|
|
setting.PanicInDevOrTesting("UnmarshalFromDB %q failed: %v", string(data), err)
|
|
return false
|
|
}
|
|
return true
|
|
}
|