mirror of
https://github.com/go-gitea/gitea.git
synced 2026-11-02 13:44:16 +09:00
Repo and org label endpoints accepted a label name for GET but only a
numeric ID for PATCH and DELETE, which breaks label-sync style tools.
- PATCH and DELETE on `/repos/{owner}/{repo}/labels/{id}` and
`/orgs/{org}/labels/{id}` accept a label name when the value is not
numeric, numeric values stay IDs
- A name shared by several labels returns 400 instead of acting on an
arbitrary one
- Deleting a missing label returns 404 instead of 204
- The swagger `id` parameter of these endpoints is now a string
Fixes: https://github.com/go-gitea/gitea/issues/34937
Co-authored-by: Hello-Liar <80651389+Hello-Liar@users.noreply.github.com>
Co-authored-by: silverwind <me@silverwind.io>
248 lines
6.2 KiB
Go
248 lines
6.2 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package org
|
|
|
|
import (
|
|
"net/http"
|
|
"strconv"
|
|
"strings"
|
|
|
|
issues_model "gitea.dev/models/issues"
|
|
"gitea.dev/modules/label"
|
|
api "gitea.dev/modules/structs"
|
|
"gitea.dev/modules/web"
|
|
"gitea.dev/routers/api/v1/utils"
|
|
"gitea.dev/services/context"
|
|
"gitea.dev/services/convert"
|
|
)
|
|
|
|
// ListLabels list all the labels of an organization
|
|
func ListLabels(ctx *context.APIContext) {
|
|
// swagger:operation GET /orgs/{org}/labels organization orgListLabels
|
|
// ---
|
|
// summary: List an organization's labels
|
|
// produces:
|
|
// - application/json
|
|
// parameters:
|
|
// - name: org
|
|
// in: path
|
|
// description: name of the organization
|
|
// type: string
|
|
// required: true
|
|
// - name: page
|
|
// in: query
|
|
// description: page number of results to return (1-based)
|
|
// type: integer
|
|
// - name: limit
|
|
// in: query
|
|
// description: page size of results
|
|
// type: integer
|
|
// responses:
|
|
// "200":
|
|
// "$ref": "#/responses/LabelList"
|
|
// default:
|
|
// "$ref": "#/responses/error"
|
|
|
|
labels, err := issues_model.GetLabelsByOrgID(ctx, ctx.Org.Organization.ID, ctx.FormString("sort"), utils.GetListOptions(ctx))
|
|
if err != nil {
|
|
ctx.APIErrorInternal(err)
|
|
return
|
|
}
|
|
|
|
count, err := issues_model.CountLabelsByOrgID(ctx, ctx.Org.Organization.ID)
|
|
if err != nil {
|
|
ctx.APIErrorInternal(err)
|
|
return
|
|
}
|
|
|
|
ctx.SetTotalCountHeader(count)
|
|
ctx.JSON(http.StatusOK, convert.ToLabelList(labels, nil, ctx.Org.Organization.AsUser()))
|
|
}
|
|
|
|
// CreateLabel create a label for a repository
|
|
func CreateLabel(ctx *context.APIContext) {
|
|
// swagger:operation POST /orgs/{org}/labels organization orgCreateLabel
|
|
// ---
|
|
// summary: Create a label for an organization
|
|
// consumes:
|
|
// - application/json
|
|
// produces:
|
|
// - application/json
|
|
// parameters:
|
|
// - name: org
|
|
// in: path
|
|
// description: name of the organization
|
|
// type: string
|
|
// required: true
|
|
// - name: body
|
|
// in: body
|
|
// schema:
|
|
// "$ref": "#/definitions/CreateLabelOption"
|
|
// responses:
|
|
// "201":
|
|
// "$ref": "#/responses/Label"
|
|
// default:
|
|
// "$ref": "#/responses/error"
|
|
form := web.GetForm[*api.CreateLabelOption](ctx)
|
|
form.Color = strings.Trim(form.Color, " ")
|
|
color, err := label.NormalizeColor(form.Color)
|
|
if err != nil {
|
|
ctx.APIError(http.StatusUnprocessableEntity, err.Error())
|
|
return
|
|
}
|
|
form.Color = color
|
|
|
|
label := &issues_model.Label{
|
|
Name: form.Name,
|
|
Exclusive: form.Exclusive,
|
|
Color: form.Color,
|
|
OrgID: ctx.Org.Organization.ID,
|
|
Description: form.Description,
|
|
}
|
|
if err := issues_model.NewLabel(ctx, label); err != nil {
|
|
ctx.APIErrorInternal(err)
|
|
return
|
|
}
|
|
|
|
ctx.JSON(http.StatusCreated, convert.ToLabel(label, nil, ctx.Org.Organization.AsUser()))
|
|
}
|
|
|
|
func getOrgLabelByIDOrName(ctx *context.APIContext) (*issues_model.Label, error) {
|
|
idOrName := ctx.PathParam("id")
|
|
if labelID, err := strconv.ParseInt(idOrName, 10, 64); err == nil {
|
|
return issues_model.GetLabelInOrgByID(ctx, ctx.Org.Organization.ID, labelID)
|
|
}
|
|
return issues_model.GetLabelInOrgByName(ctx, ctx.Org.Organization.ID, idOrName)
|
|
}
|
|
|
|
// GetLabel get label by organization and label id or name
|
|
func GetLabel(ctx *context.APIContext) {
|
|
// swagger:operation GET /orgs/{org}/labels/{id} organization orgGetLabel
|
|
// ---
|
|
// summary: Get a single label
|
|
// produces:
|
|
// - application/json
|
|
// parameters:
|
|
// - name: org
|
|
// in: path
|
|
// description: name of the organization
|
|
// type: string
|
|
// required: true
|
|
// - name: id
|
|
// in: path
|
|
// description: id of the label to get, or its name when not numeric
|
|
// type: string
|
|
// required: true
|
|
// responses:
|
|
// "200":
|
|
// "$ref": "#/responses/Label"
|
|
// default:
|
|
// "$ref": "#/responses/error"
|
|
|
|
l, err := getOrgLabelByIDOrName(ctx)
|
|
if err != nil {
|
|
ctx.APIErrorAuto(err)
|
|
return
|
|
}
|
|
|
|
ctx.JSON(http.StatusOK, convert.ToLabel(l, nil, ctx.Org.Organization.AsUser()))
|
|
}
|
|
|
|
// EditLabel modify a label for an Organization
|
|
func EditLabel(ctx *context.APIContext) {
|
|
// swagger:operation PATCH /orgs/{org}/labels/{id} organization orgEditLabel
|
|
// ---
|
|
// summary: Update a label
|
|
// consumes:
|
|
// - application/json
|
|
// produces:
|
|
// - application/json
|
|
// parameters:
|
|
// - name: org
|
|
// in: path
|
|
// description: name of the organization
|
|
// type: string
|
|
// required: true
|
|
// - name: id
|
|
// in: path
|
|
// description: id of the label to edit, or its name when not numeric
|
|
// type: string
|
|
// required: true
|
|
// - name: body
|
|
// in: body
|
|
// schema:
|
|
// "$ref": "#/definitions/EditLabelOption"
|
|
// responses:
|
|
// "200":
|
|
// "$ref": "#/responses/Label"
|
|
// default:
|
|
// "$ref": "#/responses/error"
|
|
form := web.GetForm[*api.EditLabelOption](ctx)
|
|
l, err := getOrgLabelByIDOrName(ctx)
|
|
if err != nil {
|
|
ctx.APIErrorAuto(err)
|
|
return
|
|
}
|
|
|
|
if form.Name != nil {
|
|
l.Name = *form.Name
|
|
}
|
|
if form.Exclusive != nil {
|
|
l.Exclusive = *form.Exclusive
|
|
}
|
|
if form.Color != nil {
|
|
color, err := label.NormalizeColor(*form.Color)
|
|
if err != nil {
|
|
ctx.APIError(http.StatusUnprocessableEntity, err.Error())
|
|
return
|
|
}
|
|
l.Color = color
|
|
}
|
|
if form.Description != nil {
|
|
l.Description = *form.Description
|
|
}
|
|
l.SetArchived(form.IsArchived != nil && *form.IsArchived)
|
|
if err := issues_model.UpdateLabel(ctx, l); err != nil {
|
|
ctx.APIErrorInternal(err)
|
|
return
|
|
}
|
|
|
|
ctx.JSON(http.StatusOK, convert.ToLabel(l, nil, ctx.Org.Organization.AsUser()))
|
|
}
|
|
|
|
// DeleteLabel delete a label for an organization
|
|
func DeleteLabel(ctx *context.APIContext) {
|
|
// swagger:operation DELETE /orgs/{org}/labels/{id} organization orgDeleteLabel
|
|
// ---
|
|
// summary: Delete a label
|
|
// parameters:
|
|
// - name: org
|
|
// in: path
|
|
// description: name of the organization
|
|
// type: string
|
|
// required: true
|
|
// - name: id
|
|
// in: path
|
|
// description: id of the label to delete, or its name when not numeric
|
|
// type: string
|
|
// required: true
|
|
// responses:
|
|
// "204":
|
|
// "$ref": "#/responses/empty"
|
|
// default:
|
|
// "$ref": "#/responses/error"
|
|
|
|
l, err := getOrgLabelByIDOrName(ctx)
|
|
if err != nil {
|
|
ctx.APIErrorAuto(err)
|
|
return
|
|
}
|
|
if err := issues_model.DeleteOrgLabel(ctx, ctx.Org.Organization.ID, l.ID); err != nil {
|
|
ctx.APIErrorInternal(err)
|
|
return
|
|
}
|
|
|
|
ctx.Status(http.StatusNoContent)
|
|
}
|