gitea/services/audit/scoped_test.go

// Copyright 2026 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT

package audit

import (
	"testing"

	audit_model "gitea.dev/models/audit"
	repository_model "gitea.dev/models/repo"
	user_model "gitea.dev/models/user"

	"github.com/stretchr/testify/assert"
)

func TestResolveScope(t *testing.T) {
	actions := WebhookAdd

	org := &user_model.User{ID: 10, Name: "MyOrg", Type: user_model.UserTypeOrganization}
	usr := &user_model.User{ID: 11, Name: "MyUser", Type: user_model.UserTypeIndividual}
	repo := &repository_model.Repository{ID: 12, Name: "repo", OwnerName: "MyOrg"}

	t.Run("repo wins over owner", func(t *testing.T) {
		action, scope := resolveScope(actions, org, repo)
		assert.Equal(t, audit_model.RepositoryWebhookAdd, action)
		assert.Equal(t, audit_model.ScopeRepository, scope.Type)
		assert.Equal(t, "MyOrg/repo", scope.Name)
	})

	t.Run("organization owner", func(t *testing.T) {
		action, scope := resolveScope(actions, org, nil)
		assert.Equal(t, audit_model.OrganizationWebhookAdd, action)
		assert.Equal(t, audit_model.ScopeOrganization, scope.Type)
		assert.Equal(t, "MyOrg", scope.Name)
	})

	t.Run("user owner", func(t *testing.T) {
		action, scope := resolveScope(actions, usr, nil)
		assert.Equal(t, audit_model.UserWebhookAdd, action)
		assert.Equal(t, audit_model.ScopeUser, scope.Type)
		assert.Equal(t, "MyUser", scope.Name)
	})

	t.Run("system when no owner and no repo", func(t *testing.T) {
		action, scope := resolveScope(actions, nil, nil)
		assert.Equal(t, audit_model.SystemWebhookAdd, action)
		assert.Equal(t, audit_model.ScopeSystem, scope.Type)
	})
}

// Audit recording must never crash the request that triggered it.
func TestRecordHelpersNeverPanic(t *testing.T) {
	t.Run("metaPairs skips non-string keys", func(t *testing.T) {
		var m map[string]any
		assert.NotPanics(t, func() {
			m = metaPairs("ok", 1, 42 /* bad key */, "value", "second", 2)
		})
		assert.Equal(t, 1, m["ok"])
		assert.Equal(t, 2, m["second"])
		assert.Len(t, m, 2) // the pair with the non-string key is dropped
	})

	t.Run("scopeRef falls back to system on unsupported type", func(t *testing.T) {
		var ref audit_model.EntityRef
		assert.NotPanics(t, func() {
			ref = scopeRef(struct{ Foo string }{Foo: "bar"})
		})
		assert.Equal(t, audit_model.ScopeSystem, ref.Type)
	})
}