mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-27 00:23:41 +09:00 
			
		
		
		
	Extract from #33934 In the same goroutine, we should reuse the exist cat file sub process which exist in `git.Repository` to avoid creating a unnecessary temporary subprocess. This PR reuse the exist cate file writer and reader in `getCommitFromBatchReader`. It also move `prepareLatestCommitInfo` before creating dataRc which will hold the writer so other git operation will create a temporary cat file subprocess.
		
			
				
	
	
		
			103 lines
		
	
	
		
			2.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			103 lines
		
	
	
		
			2.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2020 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| //go:build !gogit
 | |
| 
 | |
| package git
 | |
| 
 | |
| import (
 | |
| 	"io"
 | |
| )
 | |
| 
 | |
| func (repo *Repository) getTree(id ObjectID) (*Tree, error) {
 | |
| 	wr, rd, cancel, err := repo.CatFileBatch(repo.Ctx)
 | |
| 	if err != nil {
 | |
| 		return nil, err
 | |
| 	}
 | |
| 	defer cancel()
 | |
| 
 | |
| 	_, _ = wr.Write([]byte(id.String() + "\n"))
 | |
| 
 | |
| 	// ignore the SHA
 | |
| 	_, typ, size, err := ReadBatchLine(rd)
 | |
| 	if err != nil {
 | |
| 		return nil, err
 | |
| 	}
 | |
| 
 | |
| 	switch typ {
 | |
| 	case "tag":
 | |
| 		resolvedID := id
 | |
| 		data, err := io.ReadAll(io.LimitReader(rd, size))
 | |
| 		if err != nil {
 | |
| 			return nil, err
 | |
| 		}
 | |
| 		tag, err := parseTagData(id.Type(), data)
 | |
| 		if err != nil {
 | |
| 			return nil, err
 | |
| 		}
 | |
| 
 | |
| 		if _, err := wr.Write([]byte(tag.Object.String() + "\n")); err != nil {
 | |
| 			return nil, err
 | |
| 		}
 | |
| 		commit, err := repo.getCommitFromBatchReader(wr, rd, tag.Object)
 | |
| 		if err != nil {
 | |
| 			return nil, err
 | |
| 		}
 | |
| 		commit.Tree.ResolvedID = resolvedID
 | |
| 		return &commit.Tree, nil
 | |
| 	case "commit":
 | |
| 		commit, err := CommitFromReader(repo, id, io.LimitReader(rd, size))
 | |
| 		if err != nil {
 | |
| 			return nil, err
 | |
| 		}
 | |
| 		if _, err := rd.Discard(1); err != nil {
 | |
| 			return nil, err
 | |
| 		}
 | |
| 		commit.Tree.ResolvedID = commit.ID
 | |
| 		return &commit.Tree, nil
 | |
| 	case "tree":
 | |
| 		tree := NewTree(repo, id)
 | |
| 		tree.ResolvedID = id
 | |
| 		objectFormat, err := repo.GetObjectFormat()
 | |
| 		if err != nil {
 | |
| 			return nil, err
 | |
| 		}
 | |
| 		tree.entries, err = catBatchParseTreeEntries(objectFormat, tree, rd, size)
 | |
| 		if err != nil {
 | |
| 			return nil, err
 | |
| 		}
 | |
| 		tree.entriesParsed = true
 | |
| 		return tree, nil
 | |
| 	default:
 | |
| 		if err := DiscardFull(rd, size+1); err != nil {
 | |
| 			return nil, err
 | |
| 		}
 | |
| 		return nil, ErrNotExist{
 | |
| 			ID: id.String(),
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // GetTree find the tree object in the repository.
 | |
| func (repo *Repository) GetTree(idStr string) (*Tree, error) {
 | |
| 	objectFormat, err := repo.GetObjectFormat()
 | |
| 	if err != nil {
 | |
| 		return nil, err
 | |
| 	}
 | |
| 	if len(idStr) != objectFormat.FullLength() {
 | |
| 		res, err := repo.GetRefCommitID(idStr)
 | |
| 		if err != nil {
 | |
| 			return nil, err
 | |
| 		}
 | |
| 		if len(res) > 0 {
 | |
| 			idStr = res
 | |
| 		}
 | |
| 	}
 | |
| 	id, err := NewIDFromString(idStr)
 | |
| 	if err != nil {
 | |
| 		return nil, err
 | |
| 	}
 | |
| 
 | |
| 	return repo.getTree(id)
 | |
| }
 |