Files
gitea/services/issue/label.go
T
Myers Carpenterandsilverwind 58279e39fd fix(actions): match pull_request unlabeled on label removal (#40215)
Fixes https://github.com/go-gitea/gitea/issues/34317

Removing a label from a pull request still started workflows with
`types: [labeled]` and never matched `types: [unlabeled]`.
https://github.com/go-gitea/gitea/pull/34316 derived
`labeled`/`unlabeled` from the added and removed labels for issues only,
while pull requests kept mapping every `label_updated` to `labeled`.
Both events now share one conversion, so they cannot drift apart again.

Two other label changes also triggered the wrong workflows:

- Clearing all labels started no `unlabeled` workflow, because the
Actions notifier ignored it
- Replacing labels reported every old label as removed, so a replace
that kept a label also matched `unlabeled`

AI disclosure: written with Claude Code (claude-opus-5-5), session
https://claude.ai/code/session_01Kw9ySGNd4ynmyX9GcVdUfw

---------

Co-authored-by: silverwind <me@silverwind.io>
2026-11-04 17:24:33 +00:00

137 lines
3.9 KiB
Go

// Copyright 2019 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package issue
import (
"context"
"slices"
"gitea.dev/models/db"
issues_model "gitea.dev/models/issues"
access_model "gitea.dev/models/perm/access"
user_model "gitea.dev/models/user"
notify_service "gitea.dev/services/notify"
)
// ClearLabels clears all of an issue's labels
func ClearLabels(ctx context.Context, issue *issues_model.Issue, doer *user_model.User) error {
if err := issue.LoadLabels(ctx); err != nil {
return err
}
hadLabels := len(issue.Labels) > 0
if err := issues_model.ClearIssueLabels(ctx, issue, doer); err != nil {
return err
}
if hadLabels {
notify_service.IssueClearLabels(ctx, doer, issue)
}
return nil
}
// AddLabel adds a new label to the issue.
func AddLabel(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, label *issues_model.Label) error {
if err := issues_model.NewIssueLabel(ctx, issue, label, doer); err != nil {
return err
}
notify_service.IssueChangeLabels(ctx, doer, issue, []*issues_model.Label{label}, nil)
return nil
}
// AddLabels adds a list of new labels to the issue.
func AddLabels(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, labels []*issues_model.Label) error {
if err := issues_model.NewIssueLabels(ctx, issue, labels, doer); err != nil {
return err
}
notify_service.IssueChangeLabels(ctx, doer, issue, labels, nil)
return nil
}
// RemoveLabel removes a label from issue by given ID.
func RemoveLabel(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, label *issues_model.Label) error {
if err := db.WithTx(ctx, func(ctx context.Context) error {
if err := issue.LoadRepo(ctx); err != nil {
return err
}
perm, err := access_model.GetDoerRepoPermission(ctx, issue.Repo, doer)
if err != nil {
return err
}
if !perm.CanWriteIssuesOrPulls(issue.IsPull) {
if label.OrgID > 0 {
return issues_model.ErrOrgLabelNotExist{}
}
return issues_model.ErrRepoLabelNotExist{}
}
return issues_model.DeleteIssueLabel(ctx, issue, label, doer)
}); err != nil {
return err
}
notify_service.IssueChangeLabels(ctx, doer, issue, nil, []*issues_model.Label{label})
return nil
}
// ReplaceLabels removes all current labels and add new labels to the issue.
func ReplaceLabels(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, labels []*issues_model.Label) error {
old, err := issues_model.GetLabelsByIssueID(ctx, issue.ID)
if err != nil {
return err
}
if err := issues_model.ReplaceIssueLabels(ctx, issue, labels, doer); err != nil {
return err
}
notifyLabelChanges(ctx, doer, issue, old)
return nil
}
func AddRemoveLabels(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, toAdd, toRemove []*issues_model.Label) error {
oldLabels, err := issues_model.GetLabelsByIssueID(ctx, issue.ID)
if err != nil {
return err
}
if err := db.WithTx(ctx, func(ctx context.Context) error {
if err := issues_model.NewIssueLabels(ctx, issue, toAdd, doer); err != nil {
return err
}
for _, label := range toRemove {
if err := issues_model.DeleteIssueLabel(ctx, issue, label, doer); err != nil {
return err
}
}
return nil
}); err != nil {
return err
}
notifyLabelChanges(ctx, doer, issue, oldLabels)
return nil
}
func notifyLabelChanges(ctx context.Context, doer *user_model.User, issue *issues_model.Issue, oldLabels []*issues_model.Label) {
var added, removed []*issues_model.Label
for _, label := range issue.Labels {
if !slices.ContainsFunc(oldLabels, func(old *issues_model.Label) bool { return old.ID == label.ID }) {
added = append(added, label)
}
}
for _, label := range oldLabels {
if !slices.ContainsFunc(issue.Labels, func(current *issues_model.Label) bool { return current.ID == label.ID }) {
removed = append(removed, label)
}
}
if len(added) > 0 || len(removed) > 0 {
notify_service.IssueChangeLabels(ctx, doer, issue, added, removed)
}
}